ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2024-12-22 09:23:13 +01:00
Code Issues Releases Wiki Activity

Add ids to dropdown buttons, as per warnings

Browse Source 
Also helps us find these dropdown buttons with Gemini.
This commit is contained in:
Brett Sun 2016-01-29 11:20:27 +01:00
parent 7edddc4d5a
commit 01217318a4
5 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
js/components/ascribe_piece_list_toolbar/piece_list_toolbar_filter_widget.js
View File

@ -84,6 +84,7 @@ let PieceListToolbarFilterWidget = React.createClass({
if (this.props.filterParams && this.props.filterParams.length) { if (this.props.filterParams && this.props.filterParams.length) {
return ( return (
<DropdownButton <DropdownButton
id="ascribe-piece-list-toolbar-filter-widget-dropdown"
pullRight={true} pullRight={true}
title={filterIcon} title={filterIcon}
className="ascribe-piece-list-toolbar-filter-widget"> className="ascribe-piece-list-toolbar-filter-widget">

7
js/components/ascribe_piece_list_toolbar/piece_list_toolbar_order_widget.js
View File

@ -45,7 +45,7 @@ let PieceListToolbarOrderWidget = React.createClass({
}, },
render() { render() {
let filterIcon = ( let orderIcon = (
<span> <span>
<span className="ascribe-icon icon-ascribe-sort" aria-hidden="true"></span> <span className="ascribe-icon icon-ascribe-sort" aria-hidden="true"></span>
<span style={this.isOrderActive()}>&middot;</span> <span style={this.isOrderActive()}>&middot;</span>
@ -55,9 +55,10 @@ let PieceListToolbarOrderWidget = React.createClass({
if (this.props.orderParams && this.props.orderParams.length) { if (this.props.orderParams && this.props.orderParams.length) {
return ( return (
<DropdownButton <DropdownButton
id="ascribe-piece-list-toolbar-order-widget-dropdown"
pullRight={true} pullRight={true}
title={filterIcon} className="ascribe-piece-list-toolbar-filter-widget"
className="ascribe-piece-list-toolbar-filter-widget"> title={orderIcon}>
<li style={{'textAlign': 'center'}}> <li style={{'textAlign': 'center'}}>
<em>{getLangText('Sort by')}:</em> <em>{getLangText('Sort by')}:</em>
</li> </li>

1
js/components/header.js
View File

@ -163,6 +163,7 @@ let Header = React.createClass({
account = ( account = (
<DropdownButton <DropdownButton
ref='dropdownbutton' ref='dropdownbutton'
id="nav-route-user-dropdown"
eventKey="1" eventKey="1"
title={this.state.currentUser.username}> title={this.state.currentUser.username}>
<LinkContainer <LinkContainer

1
js/components/header_notification.js
View File

@ -126,6 +126,7 @@ let HeaderNotifications = React.createClass({
<Nav navbar right> <Nav navbar right>
<DropdownButton <DropdownButton
ref='dropdownbutton' ref='dropdownbutton'
id="header-notification-dropdown"
eventKey="1" eventKey="1"
title={ title={
<span> <span>

6
js/components/nav_routes_links_link.js
View File

@ -29,7 +29,9 @@ let NavRoutesLinksLink = React.createClass({
// with MenuItems // with MenuItems
if(children) { if(children) {
return ( return (
<DropdownButton title={headerTitle}> <DropdownButton
id={`nav-route-${headerTitle.toLowerCase()}-dropdown`}
title={headerTitle}>
{children} {children}
</DropdownButton> </DropdownButton>
); );
@ -55,4 +57,4 @@ let NavRoutesLinksLink = React.createClass({
} }
}); });
export default NavRoutesLinksLink; export default NavRoutesLinksLink;