From 01217318a437c296001240bd0f1527ca28137f27 Mon Sep 17 00:00:00 2001
From: Brett Sun <brett@ascribe.io>
Date: Fri, 29 Jan 2016 11:20:27 +0100
Subject: [PATCH] Add ids to dropdown buttons, as per warnings

Also helps us find these dropdown buttons with Gemini.
---
 .../piece_list_toolbar_filter_widget.js                    | 1 +
 .../piece_list_toolbar_order_widget.js                     | 7 ++++---
 js/components/header.js                                    | 1 +
 js/components/header_notification.js                       | 1 +
 js/components/nav_routes_links_link.js                     | 6 ++++--
 5 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_filter_widget.js b/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_filter_widget.js
index edb29e85..c9791dbe 100644
--- a/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_filter_widget.js
+++ b/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_filter_widget.js
@@ -84,6 +84,7 @@ let PieceListToolbarFilterWidget = React.createClass({
         if (this.props.filterParams && this.props.filterParams.length) {
             return (
                 <DropdownButton
+                    id="ascribe-piece-list-toolbar-filter-widget-dropdown"
                     pullRight={true}
                     title={filterIcon}
                     className="ascribe-piece-list-toolbar-filter-widget">
diff --git a/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_order_widget.js b/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_order_widget.js
index 5257cc07..da9bae43 100644
--- a/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_order_widget.js
+++ b/js/components/ascribe_piece_list_toolbar/piece_list_toolbar_order_widget.js
@@ -45,7 +45,7 @@ let PieceListToolbarOrderWidget = React.createClass({
     },
 
     render() {
-        let filterIcon = (
+        let orderIcon = (
             <span>
                 <span className="ascribe-icon icon-ascribe-sort" aria-hidden="true"></span>
                 <span style={this.isOrderActive()}>&middot;</span>
@@ -55,9 +55,10 @@ let PieceListToolbarOrderWidget = React.createClass({
         if (this.props.orderParams && this.props.orderParams.length) {
             return (
                 <DropdownButton
+                    id="ascribe-piece-list-toolbar-order-widget-dropdown"
                     pullRight={true}
-                    title={filterIcon}
-                    className="ascribe-piece-list-toolbar-filter-widget">
+                    className="ascribe-piece-list-toolbar-filter-widget"
+                    title={orderIcon}>
                     <li style={{'textAlign': 'center'}}>
                         <em>{getLangText('Sort by')}:</em>
                     </li>
diff --git a/js/components/header.js b/js/components/header.js
index c16cba86..4bb6881e 100644
--- a/js/components/header.js
+++ b/js/components/header.js
@@ -163,6 +163,7 @@ let Header = React.createClass({
             account = (
                 <DropdownButton
                     ref='dropdownbutton'
+                    id="nav-route-user-dropdown"
                     eventKey="1"
                     title={this.state.currentUser.username}>
                     <LinkContainer
diff --git a/js/components/header_notification.js b/js/components/header_notification.js
index 4b375685..784f8786 100644
--- a/js/components/header_notification.js
+++ b/js/components/header_notification.js
@@ -126,6 +126,7 @@ let HeaderNotifications = React.createClass({
                 <Nav navbar right>
                     <DropdownButton
                         ref='dropdownbutton'
+                        id="header-notification-dropdown"
                         eventKey="1"
                         title={
                             <span>
diff --git a/js/components/nav_routes_links_link.js b/js/components/nav_routes_links_link.js
index 11235ccd..e2bfb7ed 100644
--- a/js/components/nav_routes_links_link.js
+++ b/js/components/nav_routes_links_link.js
@@ -29,7 +29,9 @@ let NavRoutesLinksLink = React.createClass({
         // with MenuItems
         if(children) {
             return (
-                <DropdownButton title={headerTitle}>
+                <DropdownButton
+                    id={`nav-route-${headerTitle.toLowerCase()}-dropdown`}
+                    title={headerTitle}>
                     {children}
                 </DropdownButton>
             );
@@ -55,4 +57,4 @@ let NavRoutesLinksLink = React.createClass({
     }
 });
 
-export default NavRoutesLinksLink;
\ No newline at end of file
+export default NavRoutesLinksLink;