tornadocash/tornado-core
1
0
Fork 0
mirror of https://github.com/tornadocash/tornado-core.git synced 2025-01-06 11:55:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4 from peppersec/fix_overflow

Browse Source 
fix overflow
This commit is contained in:
Roman Semenov 2019-08-01 10:56:50 +03:00 committed by GitHub
commit 4663caa588
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package-lock.json generated
View File

@ -6403,8 +6403,8 @@
} }
}, },
"snarkjs": { "snarkjs": {
"version": "git+https://github.com/iden3/snarkjs.git#5fe2bd4642ec567c75ad5ac3f73687999c412e73", "version": "git+https://github.com/iden3/snarkjs.git#c428706ef69930e378c31199ff8d66ee13fada85",
"from": "git+https://github.com/iden3/snarkjs.git#5fe2bd4642ec567c75ad5ac3f73687999c412e73", "from": "git+https://github.com/iden3/snarkjs.git#c428706ef69930e378c31199ff8d66ee13fada85",
"requires": { "requires": {
"big-integer": "^1.6.43", "big-integer": "^1.6.43",
"chai": "^4.2.0", "chai": "^4.2.0",

4
package.json
View File

@ -27,10 +27,10 @@
"circom": "0.0.30", "circom": "0.0.30",
"circomlib": "^0.0.10", "circomlib": "^0.0.10",
"dotenv": "^8.0.0", "dotenv": "^8.0.0",
"express": "^4.17.1",
"eslint": "^6.0.1", "eslint": "^6.0.1",
"express": "^4.17.1",
"ganache-cli": "^6.4.5", "ganache-cli": "^6.4.5",
"snarkjs": "git+https://github.com/iden3/snarkjs.git#5fe2bd4642ec567c75ad5ac3f73687999c412e73", "snarkjs": "git+https://github.com/iden3/snarkjs.git#c428706ef69930e378c31199ff8d66ee13fada85",
"truffle": "^5.0.27", "truffle": "^5.0.27",
"truffle-artifactor": "^4.0.23", "truffle-artifactor": "^4.0.23",
"truffle-contract": "^4.0.24", "truffle-contract": "^4.0.24",

26
test/Mixer.test.js
View File

@ -236,7 +236,6 @@ contract('Mixer', accounts => {
pathElements: path_elements, pathElements: path_elements,
pathIndex: path_index, pathIndex: path_index,
}) })
const proof = await websnarkUtils.genWitnessAndProve(groth16, input, circuit, proving_key) const proof = await websnarkUtils.genWitnessAndProve(groth16, input, circuit, proving_key)
const { pi_a, pi_b, pi_c, publicSignals } = websnarkUtils.toSolidityInput(proof) const { pi_a, pi_b, pi_c, publicSignals } = websnarkUtils.toSolidityInput(proof)
await mixer.withdraw(pi_a, pi_b, pi_c, publicSignals, { from: relayer }).should.be.fulfilled await mixer.withdraw(pi_a, pi_b, pi_c, publicSignals, { from: relayer }).should.be.fulfilled
@ -244,6 +243,30 @@ contract('Mixer', accounts => {
error.reason.should.be.equal('The note has been already spent') error.reason.should.be.equal('The note has been already spent')
}) })
it('should prevent double spend with overflow', async () => {
const deposit = generateDeposit()
await tree.insert(deposit.commitment)
await mixer.deposit(toBN(deposit.commitment.toString()), { value, from: sender })
const { root, path_elements, path_index } = await tree.path(0)
const input = stringifyBigInts({
root,
nullifierHash: pedersenHash(deposit.nullifier.leInt2Buff(32)),
nullifier: deposit.nullifier,
receiver,
fee,
secret: deposit.secret,
pathElements: path_elements,
pathIndex: path_index,
})
const proof = await websnarkUtils.genWitnessAndProve(groth16, input, circuit, proving_key)
const { pi_a, pi_b, pi_c, publicSignals } = websnarkUtils.toSolidityInput(proof)
publicSignals[1] ='0x' + toBN(publicSignals[1]).add(toBN('21888242871839275222246405745257275088548364400416034343698204186575808495617')).toString('hex')
const error = await mixer.withdraw(pi_a, pi_b, pi_c, publicSignals, { from: relayer }).should.be.rejected
error.reason.should.be.equal('verifier-gte-snark-scalar-field')
})
it('fee should be less or equal transfer value', async () => { it('fee should be less or equal transfer value', async () => {
const deposit = generateDeposit() const deposit = generateDeposit()
await tree.insert(deposit.commitment) await tree.insert(deposit.commitment)
@ -312,7 +335,6 @@ contract('Mixer', accounts => {
pathElements: path_elements, pathElements: path_elements,
pathIndex: path_index, pathIndex: path_index,
}) })
const proof = await websnarkUtils.genWitnessAndProve(groth16, input, circuit, proving_key) const proof = await websnarkUtils.genWitnessAndProve(groth16, input, circuit, proving_key)
let { pi_a, pi_b, pi_c, publicSignals } = websnarkUtils.toSolidityInput(proof) let { pi_a, pi_b, pi_c, publicSignals } = websnarkUtils.toSolidityInput(proof)
const originalPublicSignals = publicSignals.slice() const originalPublicSignals = publicSignals.slice()