Fix linter issues manually.

.eslintrc

@@ -28,7 +28,14 @@
         "@typescript-eslint/no-var-requires": "off",
         "@typescript-eslint/no-use-before-define": "off",
         "@typescript-eslint/no-object-literal-type-assertion": "off",
-        "@typescript-eslint/no-parameter-properties": "off"
+        "@typescript-eslint/no-parameter-properties": "off",
+        "no-empty":  [
+            "error",
+            { "allowEmptyCatch": true }
+        ],
+        "prefer-destructuring": ["warn"],
+        "no-dupe-class-members": ["warn"],
+        "no-useless-constructor": ["warn"]
     },
     "env": {
         "es6": true,

integration/ocean/AssetOwners.test.ts

@@ -18,9 +18,7 @@ describe('Asset Owners', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        const accounts = await ocean.accounts.list()
+        ;[account1, account2] = await ocean.accounts.list()
-        account1 = accounts[0]
-        account2 = accounts[1]
     })
 
     it('should be set correctly the owner of a asset', async () => {

integration/ocean/AuthenticationToken.test.ts

@@ -18,9 +18,7 @@ describe('Authentication Token', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        const accounts = await ocean.accounts.list()
+        ;[account1, account2] = await ocean.accounts.list()
-        account1 = accounts[0]
-        account2 = accounts[1]
     })
 
     it('should generate a token', async () => {

integration/ocean/ConsumeAsset.test.ts

@@ -24,8 +24,7 @@ describe('Consume Asset', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        publisher = (await ocean.accounts.list())[0]
+        ;[publisher, consumer] = await ocean.accounts.list()
-        consumer = (await ocean.accounts.list())[1]
     })
 
     it('should regiester a asset', async () => {
@@ -164,7 +163,7 @@ describe('Consume Asset', () => {
         assert.include(path, folder, 'The storage path is not correct.')
 
         const files = await new Promise<string[]>(resolve => {
-            fs.readdir(path, (err, fileList) => {
+            fs.readdir(path, (e, fileList) => {
                 resolve(fileList)
             })
         })
@@ -192,7 +191,7 @@ describe('Consume Asset', () => {
         assert.include(path, folder, 'The storage path is not correct.')
 
         const files = await new Promise<string[]>(resolve => {
-            fs.readdir(path, (err, fileList) => {
+            fs.readdir(path, (e, fileList) => {
                 resolve(fileList)
             })
         })

integration/ocean/ConsumeAssetBrizo.test.ts

@@ -21,8 +21,7 @@ describe('Consume Asset (Brizo)', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        publisher = (await ocean.accounts.list())[0]
+        ;[publisher, consumer] = await ocean.accounts.list()
-        consumer = (await ocean.accounts.list())[1]
     })
 
     after(() => {
@@ -77,7 +76,7 @@ describe('Consume Asset (Brizo)', () => {
         assert.include(path, folder, 'The storage path is not correct.')
 
         const files = await new Promise<string[]>(resolve => {
-            fs.readdir(path, (err, fileList) => {
+            fs.readdir(path, (e, fileList) => {
                 resolve(fileList)
             })
         })

integration/ocean/ConsumeBigAsset.test.ts

@@ -33,8 +33,7 @@ xdescribe('Consume Asset (Large size)', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        publisher = (await ocean.accounts.list())[0]
+        ;[publisher, consumer] = await ocean.accounts.list()
-        consumer = (await ocean.accounts.list())[1]
     })
 
     it('should regiester an asset', async () => {
@@ -72,7 +71,7 @@ xdescribe('Consume Asset (Large size)', () => {
         assert.include(path, folder, 'The storage path is not correct.')
 
         const files = await new Promise<string[]>(resolve => {
-            fs.readdir(path, (err, fileList) => {
+            fs.readdir(path, (e, fileList) => {
                 resolve(fileList)
             })
         })

integration/ocean/RegisterEscrowAccessSecretStoreTemplate.test.ts

@@ -54,7 +54,7 @@ describe('Register Escrow Access Secret Store Template', () => {
                 true
             )
             // TODO: Use a event to detect template mined
-            await new Promise(_ => setTimeout(_, 2 * 1000))
+            await new Promise(resolve => setTimeout(resolve, 2 * 1000))
         })
 
         it('should approve the template', async () => {
@@ -64,7 +64,7 @@ describe('Register Escrow Access Secret Store Template', () => {
                 true
             )
             // TODO: Use a event to detect template mined
-            await new Promise(_ => setTimeout(_, 2 * 1000))
+            await new Promise(resolve => setTimeout(resolve, 2 * 1000))
         })
     })
 

integration/ocean/SearchAsset.test.ts

@@ -25,8 +25,7 @@ describe('Search Asset', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        publisher = (await ocean.accounts.list())[0]
+        ;[publisher] = await ocean.accounts.list()
-        publisher.setPassword(process.env.ACCOUNT_PASSWORD)
     })
 
     it('should be able to search the assets', async () => {

integration/ocean/SecretStore.test.ts

@@ -17,7 +17,7 @@ describe('Secret Store', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        account = (await ocean.accounts.list())[0]
+        ;[account] = await ocean.accounts.list()
     })
 
     it('should encrypt a text', async () => {

integration/ocean/Signature.test.ts

@@ -14,7 +14,7 @@ describe('Signature', () => {
         ocean = await Ocean.getInstance(config)
 
         // Accounts
-        consumer = (await ocean.accounts.list())[0]
+        ;[consumer] = await ocean.accounts.list()
     })
 
     it('should generate the correct signature', async () => {

package-lock.json

@@ -812,6 +812,21 @@
         "es-abstract": "^1.7.0"
       }
     },
+    "array-union": {
+      "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/array-union/-/array-union-1.0.2.tgz",
+      "integrity": "sha1-mjRBDk9OPaI96jdb5b5w8kd47Dk=",
+      "dev": true,
+      "requires": {
+        "array-uniq": "^1.0.1"
+      }
+    },
+    "array-uniq": {
+      "version": "1.0.3",
+      "resolved": "https://registry.npmjs.org/array-uniq/-/array-uniq-1.0.3.tgz",
+      "integrity": "sha1-r2rId6Jcx/dOBYiUdThY39sk/bY=",
+      "dev": true
+    },
     "array-unique": {
       "version": "0.3.2",
       "resolved": "https://registry.npmjs.org/array-unique/-/array-unique-0.3.2.tgz",
@@ -1463,6 +1478,38 @@
         }
       }
     },
+    "call-me-maybe": {
+      "version": "1.0.1",
+      "resolved": "https://registry.npmjs.org/call-me-maybe/-/call-me-maybe-1.0.1.tgz",
+      "integrity": "sha1-JtII6onje1y95gJQoV8DHBak1ms=",
+      "dev": true
+    },
+    "caller-callsite": {
+      "version": "2.0.0",
+      "resolved": "https://registry.npmjs.org/caller-callsite/-/caller-callsite-2.0.0.tgz",
+      "integrity": "sha1-hH4PzgoiN1CpoCfFSzNzGtMVQTQ=",
+      "dev": true,
+      "requires": {
+        "callsites": "^2.0.0"
+      },
+      "dependencies": {
+        "callsites": {
+          "version": "2.0.0",
+          "resolved": "https://registry.npmjs.org/callsites/-/callsites-2.0.0.tgz",
+          "integrity": "sha1-BuuE8A7qQT2oav/vrL/7Ngk7PFA=",
+          "dev": true
+        }
+      }
+    },
+    "caller-path": {
+      "version": "2.0.0",
+      "resolved": "https://registry.npmjs.org/caller-path/-/caller-path-2.0.0.tgz",
+      "integrity": "sha1-Ro+DBE42mrIBD6xfBs7uFbsssfQ=",
+      "dev": true,
+      "requires": {
+        "caller-callsite": "^2.0.0"
+      }
+    },
     "callsites": {
       "version": "3.1.0",
       "resolved": "https://registry.npmjs.org/callsites/-/callsites-3.1.0.tgz",
@@ -1528,6 +1575,12 @@
         }
       }
     },
+    "changelog-filename-regex": {
+      "version": "1.1.2",
+      "resolved": "https://registry.npmjs.org/changelog-filename-regex/-/changelog-filename-regex-1.1.2.tgz",
+      "integrity": "sha512-kpOfKlZ9x2UpeC4at6FAXHLKfi/JEUqUqkPCb1JUCa5FnNbJIzOHRM9RfeQ1QDcpj+Gxuc/UoHqASgmEeFDejQ==",
+      "dev": true
+    },
     "chardet": {
       "version": "0.7.0",
       "resolved": "https://registry.npmjs.org/chardet/-/chardet-0.7.0.tgz",
@@ -1630,6 +1683,12 @@
         }
       }
     },
+    "cli-boxes": {
+      "version": "1.0.0",
+      "resolved": "https://registry.npmjs.org/cli-boxes/-/cli-boxes-1.0.0.tgz",
+      "integrity": "sha1-T6kXw+WclKAEzWH47lCdplFocUM=",
+      "dev": true
+    },
     "cli-cursor": {
       "version": "2.1.0",
       "resolved": "https://registry.npmjs.org/cli-cursor/-/cli-cursor-2.1.0.tgz",
@@ -1639,6 +1698,12 @@
         "restore-cursor": "^2.0.0"
       }
     },
+    "cli-spinners": {
+      "version": "2.1.0",
+      "resolved": "https://registry.npmjs.org/cli-spinners/-/cli-spinners-2.1.0.tgz",
+      "integrity": "sha512-8B00fJOEh1HPrx4fo5eW16XmE1PcL1tGpGrxy63CXGP9nHdPBN63X75hA1zhvQuhVztJWLqV58Roj2qlNM7cAA==",
+      "dev": true
+    },
     "cli-width": {
       "version": "2.2.0",
       "resolved": "https://registry.npmjs.org/cli-width/-/cli-width-2.2.0.tgz",
@@ -1892,6 +1957,24 @@
         "is-directory": "^0.3.1",
         "js-yaml": "^3.13.0",
         "parse-json": "^4.0.0"
+      },
+      "dependencies": {
+        "import-fresh": {
+          "version": "2.0.0",
+          "resolved": "https://registry.npmjs.org/import-fresh/-/import-fresh-2.0.0.tgz",
+          "integrity": "sha1-2BNVwVYS04bGH53dOSLUMEgipUY=",
+          "dev": true,
+          "requires": {
+            "caller-path": "^2.0.0",
+            "resolve-from": "^3.0.0"
+          }
+        },
+        "resolve-from": {
+          "version": "3.0.0",
+          "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-3.0.0.tgz",
+          "integrity": "sha1-six699nWiBvItuZTM17rywoYh0g=",
+          "dev": true
+        }
       }
     },
     "cp-file": {
@@ -2152,12 +2235,24 @@
         "type-detect": "^4.0.0"
       }
     },
+    "deep-extend": {
+      "version": "0.6.0",
+      "resolved": "https://registry.npmjs.org/deep-extend/-/deep-extend-0.6.0.tgz",
+      "integrity": "sha512-LOHxIOaPYdHlJRtCQfDIVZtfw/ufM8+rVj649RIHzcm/vGwQRXFt6OPqIFWsm2XEMrNIEtWR64sY1LEKD2vAOA==",
+      "dev": true
+    },
     "deep-is": {
       "version": "0.1.3",
       "resolved": "https://registry.npmjs.org/deep-is/-/deep-is-0.1.3.tgz",
       "integrity": "sha1-s2nW+128E+7PUk+RsHD+7cNXzzQ=",
       "dev": true
     },
+    "deepmerge": {
+      "version": "3.2.0",
+      "resolved": "https://registry.npmjs.org/deepmerge/-/deepmerge-3.2.0.tgz",
+      "integrity": "sha512-6+LuZGU7QCNUnAJyX8cIrlzoEgggTM6B7mm+znKOX4t5ltluT9KLjN6g61ECMS0LTsLW7yDpNoxhix5FZcrIow==",
+      "dev": true
+    },
     "default-require-extensions": {
       "version": "2.0.0",
       "resolved": "https://registry.npmjs.org/default-require-extensions/-/default-require-extensions-2.0.0.tgz",
@@ -2324,6 +2419,15 @@
         "randombytes": "^2.0.0"
       }
     },
+    "dir-glob": {
+      "version": "2.2.2",
+      "resolved": "https://registry.npmjs.org/dir-glob/-/dir-glob-2.2.2.tgz",
+      "integrity": "sha512-f9LBi5QWzIW3I6e//uxZoLBlUt9kcp66qo0sSCxL6YZKc75R1c4MFCoe/LaZiBGmgujvQdxc5Bn3QhfyvK5Hsw==",
+      "dev": true,
+      "requires": {
+        "path-type": "^3.0.0"
+      }
+    },
     "doctrine": {
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/doctrine/-/doctrine-3.0.0.tgz",
@@ -3326,6 +3430,31 @@
       "integrity": "sha512-xJuoT5+L99XlZ8twedaRf6Ax2TgQVxvgZOYoPKqZufmJib0tL2tegPBOZb1pVNgIhlqDlA0eO0c3wBvQcmzx4w==",
       "dev": true
     },
+    "fast-glob": {
+      "version": "2.2.7",
+      "resolved": "https://registry.npmjs.org/fast-glob/-/fast-glob-2.2.7.tgz",
+      "integrity": "sha512-g1KuQwHOZAmOZMuBtHdxDtju+T2RT8jgCC9aANsbpdiDDTSnjgfuVsIBNKbUeJI3oKMRExcfNDtJl4OhbffMsw==",
+      "dev": true,
+      "requires": {
+        "@mrmlnc/readdir-enhanced": "^2.2.1",
+        "@nodelib/fs.stat": "^1.1.2",
+        "glob-parent": "^3.1.0",
+        "is-glob": "^4.0.0",
+        "merge2": "^1.2.3",
+        "micromatch": "^3.1.10"
+      },
+      "dependencies": {
+        "is-glob": {
+          "version": "4.0.1",
+          "resolved": "https://registry.npmjs.org/is-glob/-/is-glob-4.0.1.tgz",
+          "integrity": "sha512-5G0tKtBTFImOqDnLB2hG6Bp2qcKEFduo4tZu9MT/H6NQv/ghhy30o55ufafxJ/LdH79LLs2Kfrn85TLKyA7BUg==",
+          "dev": true,
+          "requires": {
+            "is-extglob": "^2.1.1"
+          }
+        }
+      }
+    },
     "fast-json-stable-stringify": {
       "version": "2.0.0",
       "resolved": "https://registry.npmjs.org/fast-json-stable-stringify/-/fast-json-stable-stringify-2.0.0.tgz",
@@ -3668,8 +3797,7 @@
         "ansi-regex": {
           "version": "2.1.1",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "aproba": {
           "version": "1.2.0",
@@ -3690,14 +3818,12 @@
         "balanced-match": {
           "version": "1.0.0",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "brace-expansion": {
           "version": "1.1.11",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "balanced-match": "^1.0.0",
             "concat-map": "0.0.1"
@@ -3712,20 +3838,17 @@
         "code-point-at": {
           "version": "1.1.0",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "concat-map": {
           "version": "0.0.1",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "console-control-strings": {
           "version": "1.1.0",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "core-util-is": {
           "version": "1.0.2",
@@ -3842,8 +3965,7 @@
         "inherits": {
           "version": "2.0.3",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "ini": {
           "version": "1.3.5",
@@ -3855,7 +3977,6 @@
           "version": "1.0.0",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "number-is-nan": "^1.0.0"
           }
@@ -3870,7 +3991,6 @@
           "version": "3.0.4",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "brace-expansion": "^1.1.7"
           }
@@ -3878,14 +3998,12 @@
         "minimist": {
           "version": "0.0.8",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "minipass": {
           "version": "2.3.5",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "safe-buffer": "^5.1.2",
             "yallist": "^3.0.0"
@@ -3904,7 +4022,6 @@
           "version": "0.5.1",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "minimist": "0.0.8"
           }
@@ -3985,8 +4102,7 @@
         "number-is-nan": {
           "version": "1.0.1",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "object-assign": {
           "version": "4.1.1",
@@ -3998,7 +4114,6 @@
           "version": "1.4.0",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "wrappy": "1"
           }
@@ -4084,8 +4199,7 @@
         "safe-buffer": {
           "version": "5.1.2",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "safer-buffer": {
           "version": "2.1.2",
@@ -4121,7 +4235,6 @@
           "version": "1.0.2",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "code-point-at": "^1.0.0",
             "is-fullwidth-code-point": "^1.0.0",
@@ -4141,7 +4254,6 @@
           "version": "3.0.1",
           "bundled": true,
           "dev": true,
-          "optional": true,
           "requires": {
             "ansi-regex": "^2.0.0"
           }
@@ -4185,14 +4297,12 @@
         "wrappy": {
           "version": "1.0.2",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         },
         "yallist": {
           "version": "3.0.3",
           "bundled": true,
-          "dev": true,
+          "dev": true
-          "optional": true
         }
       }
     },
@@ -4677,6 +4787,15 @@
       "integrity": "sha512-cyFDKrqc/YdcWFniJhzI42+AzS+gNwmUzOSFcRCQYwySuBBBy/KjuxWLZ/FHEH6Moq1NizMOBWyTcv8O4OZIMg==",
       "dev": true
     },
+    "import-cwd": {
+      "version": "2.1.0",
+      "resolved": "https://registry.npmjs.org/import-cwd/-/import-cwd-2.1.0.tgz",
+      "integrity": "sha1-qmzzbnInYShcs3HsZRn1PiQ1sKk=",
+      "dev": true,
+      "requires": {
+        "import-from": "^2.1.0"
+      }
+    },
     "import-fresh": {
       "version": "3.0.0",
       "resolved": "https://registry.npmjs.org/import-fresh/-/import-fresh-3.0.0.tgz",
@@ -4687,6 +4806,29 @@
         "resolve-from": "^4.0.0"
       }
     },
+    "import-from": {
+      "version": "2.1.0",
+      "resolved": "https://registry.npmjs.org/import-from/-/import-from-2.1.0.tgz",
+      "integrity": "sha1-M1238qev/VOqpHHUuAId7ja387E=",
+      "dev": true,
+      "requires": {
+        "resolve-from": "^3.0.0"
+      },
+      "dependencies": {
+        "resolve-from": {
+          "version": "3.0.0",
+          "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-3.0.0.tgz",
+          "integrity": "sha1-six699nWiBvItuZTM17rywoYh0g=",
+          "dev": true
+        }
+      }
+    },
+    "import-lazy": {
+      "version": "2.1.0",
+      "resolved": "https://registry.npmjs.org/import-lazy/-/import-lazy-2.1.0.tgz",
+      "integrity": "sha1-BWmOPUXIjo1+nZLLBYTnfwlvPkM=",
+      "dev": true
+    },
     "import-local": {
       "version": "2.0.0",
       "resolved": "https://registry.npmjs.org/import-local/-/import-local-2.0.0.tgz",
@@ -5050,6 +5192,12 @@
       "integrity": "sha1-eaKp7OfwlugPNtKy87wWwf9L8/o=",
       "dev": true
     },
+    "is-redirect": {
+      "version": "1.0.0",
+      "resolved": "https://registry.npmjs.org/is-redirect/-/is-redirect-1.0.0.tgz",
+      "integrity": "sha1-HQPd7VO9jbDzDCbk+V02/HyH3CQ=",
+      "dev": true
+    },
     "is-regex": {
       "version": "1.0.4",
       "resolved": "https://registry.npmjs.org/is-regex/-/is-regex-1.0.4.tgz",
@@ -5591,6 +5739,18 @@
       "integrity": "sha1-vyJJiGzlFM2hEvrpIYzcBlIR/Jw=",
       "dev": true
     },
+    "lodash.uniq": {
+      "version": "4.5.0",
+      "resolved": "https://registry.npmjs.org/lodash.uniq/-/lodash.uniq-4.5.0.tgz",
+      "integrity": "sha1-0CJTc662Uq3BvILklFM5qEJ1R3M=",
+      "dev": true
+    },
+    "lodash.uniqby": {
+      "version": "4.7.0",
+      "resolved": "https://registry.npmjs.org/lodash.uniqby/-/lodash.uniqby-4.7.0.tgz",
+      "integrity": "sha1-2ZwHpmnp5tJOE2Lf4mbGdhavEwI=",
+      "dev": true
+    },
     "log-symbols": {
       "version": "2.2.0",
       "resolved": "https://registry.npmjs.org/log-symbols/-/log-symbols-2.2.0.tgz",
@@ -6460,6 +6620,37 @@
         }
       }
     },
+    "ora": {
+      "version": "3.4.0",
+      "resolved": "https://registry.npmjs.org/ora/-/ora-3.4.0.tgz",
+      "integrity": "sha512-eNwHudNbO1folBP3JsZ19v9azXWtQZjICdr3Q0TDPIaeBQ3mXLrh54wM+er0+hSp+dWKf+Z8KM58CYzEyIYxYg==",
+      "dev": true,
+      "requires": {
+        "chalk": "^2.4.2",
+        "cli-cursor": "^2.1.0",
+        "cli-spinners": "^2.0.0",
+        "log-symbols": "^2.2.0",
+        "strip-ansi": "^5.2.0",
+        "wcwidth": "^1.0.1"
+      },
+      "dependencies": {
+        "ansi-regex": {
+          "version": "4.1.0",
+          "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-4.1.0.tgz",
+          "integrity": "sha512-1apePfXM1UOSqw0o9IiFAovVz9M5S1Dg+4TrDwfMewQ6p/rmMueb7tWZjQ1rx4Loy1ArBggoqGpfqqdI4rondg==",
+          "dev": true
+        },
+        "strip-ansi": {
+          "version": "5.2.0",
+          "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-5.2.0.tgz",
+          "integrity": "sha512-DuRs1gKbBqsMKIZlrffwlug8MHkcnpjs5VPmL1PAh+mA30U0DTotfDZ0d2UUsXpPmPmMMJ6W773MaA3J+lbiWA==",
+          "dev": true,
+          "requires": {
+            "ansi-regex": "^4.1.0"
+          }
+        }
+      }
+    },
     "ordered-read-streams": {
       "version": "1.0.1",
       "resolved": "https://registry.npmjs.org/ordered-read-streams/-/ordered-read-streams-1.0.1.tgz",
@@ -6492,6 +6683,16 @@
         "mem": "^4.0.0"
       }
     },
+    "os-name": {
+      "version": "3.1.0",
+      "resolved": "https://registry.npmjs.org/os-name/-/os-name-3.1.0.tgz",
+      "integrity": "sha512-h8L+8aNjNcMpo/mAIBPn5PXCM16iyPGjHNWo6U1YO8sJTMHtEtyczI6QJnLoplswm6goopQkqc7OAnjhWcugVg==",
+      "dev": true,
+      "requires": {
+        "macos-release": "^2.2.0",
+        "windows-release": "^3.1.0"
+      }
+    },
     "os-tmpdir": {
       "version": "1.0.2",
       "resolved": "https://registry.npmjs.org/os-tmpdir/-/os-tmpdir-1.0.2.tgz",
@@ -6883,6 +7084,12 @@
         "react-is": "^16.8.1"
       }
     },
+    "protocols": {
+      "version": "1.4.7",
+      "resolved": "https://registry.npmjs.org/protocols/-/protocols-1.4.7.tgz",
+      "integrity": "sha512-Fx65lf9/YDn3hUX08XUc0J8rSux36rEsyiv21ZGUC1mOyeM3lTRpZLcrm8aAolzS4itwVfm7TAPyxC2E5zd6xg==",
+      "dev": true
+    },
     "proxy-addr": {
       "version": "2.0.5",
       "resolved": "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.5.tgz",
@@ -7013,6 +7220,26 @@
         "unpipe": "1.0.0"
       }
     },
+    "rc": {
+      "version": "1.2.8",
+      "resolved": "https://registry.npmjs.org/rc/-/rc-1.2.8.tgz",
+      "integrity": "sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw==",
+      "dev": true,
+      "requires": {
+        "deep-extend": "^0.6.0",
+        "ini": "~1.3.0",
+        "minimist": "^1.2.0",
+        "strip-json-comments": "~2.0.1"
+      },
+      "dependencies": {
+        "minimist": {
+          "version": "1.2.0",
+          "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+          "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
+          "dev": true
+        }
+      }
+    },
     "react-is": {
       "version": "16.8.6",
       "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.8.6.tgz",
@@ -7096,6 +7323,152 @@
       "integrity": "sha512-lv0M6+TkDVniA3aD1Eg0DVpfU/booSu7Eev3TDO/mZKHBfVjgCGTV4t4buppESEYDtkArYFOxTJWv6S5C+iaNw==",
       "dev": true
     },
+    "registry-auth-token": {
+      "version": "3.4.0",
+      "resolved": "https://registry.npmjs.org/registry-auth-token/-/registry-auth-token-3.4.0.tgz",
+      "integrity": "sha512-4LM6Fw8eBQdwMYcES4yTnn2TqIasbXuwDx3um+QRs7S55aMKCBKBxvPXl2RiUjHwuJLTyYfxSpmfSAjQpcuP+A==",
+      "dev": true,
+      "requires": {
+        "rc": "^1.1.6",
+        "safe-buffer": "^5.0.1"
+      }
+    },
+    "registry-url": {
+      "version": "3.1.0",
+      "resolved": "https://registry.npmjs.org/registry-url/-/registry-url-3.1.0.tgz",
+      "integrity": "sha1-PU74cPc93h138M+aOBQyRE4XSUI=",
+      "dev": true,
+      "requires": {
+        "rc": "^1.0.1"
+      }
+    },
+    "release-it": {
+      "version": "12.3.0",
+      "resolved": "https://registry.npmjs.org/release-it/-/release-it-12.3.0.tgz",
+      "integrity": "sha512-mMEbdhyUDyX05viUl1pKcDLpNOxpgiig6OfvJXleNJqYKjIvNtYVkBxLHXH//kmT2NYnAkx8NvN8IZJQRei8zQ==",
+      "dev": true,
+      "requires": {
+        "@iarna/toml": "2.2.3",
+        "@octokit/rest": "16.25.0",
+        "async-retry": "1.2.3",
+        "chalk": "2.4.2",
+        "cosmiconfig": "5.2.0",
+        "debug": "4.1.1",
+        "deprecated-obj": "1.0.1",
+        "detect-repo-changelog": "1.0.1",
+        "find-up": "3.0.0",
+        "form-data": "2.3.3",
+        "git-url-parse": "11.1.2",
+        "globby": "9.2.0",
+        "got": "9.6.0",
+        "import-cwd": "2.1.0",
+        "inquirer": "6.3.1",
+        "is-ci": "2.0.0",
+        "lodash": "4.17.11",
+        "mime-types": "2.1.24",
+        "ora": "3.4.0",
+        "os-name": "3.1.0",
+        "semver": "6.0.0",
+        "shelljs": "0.8.3",
+        "supports-color": "6.1.0",
+        "update-notifier": "2.5.0",
+        "url-join": "4.0.0",
+        "uuid": "3.3.2",
+        "window-size": "1.1.1",
+        "yargs-parser": "13.0.0"
+      },
+      "dependencies": {
+        "debug": {
+          "version": "4.1.1",
+          "resolved": "https://registry.npmjs.org/debug/-/debug-4.1.1.tgz",
+          "integrity": "sha512-pYAIzeRo8J6KPEaJ0VWOh5Pzkbw/RetuzehGM7QRRX5he4fPHx2rdKMB256ehJCkX+XRQm16eZLqLNS8RSZXZw==",
+          "dev": true,
+          "requires": {
+            "ms": "^2.1.1"
+          }
+        },
+        "get-stream": {
+          "version": "4.1.0",
+          "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-4.1.0.tgz",
+          "integrity": "sha512-GMat4EJ5161kIy2HevLlr4luNjBgvmj413KaQA7jt4V8B4RDsfpHk7WQ9GVqfYyyx8OS/L66Kox+rJRNklLK7w==",
+          "dev": true,
+          "requires": {
+            "pump": "^3.0.0"
+          }
+        },
+        "got": {
+          "version": "9.6.0",
+          "resolved": "https://registry.npmjs.org/got/-/got-9.6.0.tgz",
+          "integrity": "sha512-R7eWptXuGYxwijs0eV+v3o6+XH1IqVK8dJOEecQfTmkncw9AV4dcw/Dhxi8MdlqPthxxpZyizMzyg8RTmEsG+Q==",
+          "dev": true,
+          "requires": {
+            "@sindresorhus/is": "^0.14.0",
+            "@szmarczak/http-timer": "^1.1.2",
+            "cacheable-request": "^6.0.0",
+            "decompress-response": "^3.3.0",
+            "duplexer3": "^0.1.4",
+            "get-stream": "^4.1.0",
+            "lowercase-keys": "^1.0.1",
+            "mimic-response": "^1.0.1",
+            "p-cancelable": "^1.0.0",
+            "to-readable-stream": "^1.0.0",
+            "url-parse-lax": "^3.0.0"
+          }
+        },
+        "ms": {
+          "version": "2.1.2",
+          "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.2.tgz",
+          "integrity": "sha512-sGkPx+VjMtmA6MX27oA4FBFELFCZZ4S4XqeGOXCv68tT+jb3vk/RyaKWP0PTKyWtmLSM0b+adUTEvbs1PEaH2w==",
+          "dev": true
+        },
+        "p-cancelable": {
+          "version": "1.1.0",
+          "resolved": "https://registry.npmjs.org/p-cancelable/-/p-cancelable-1.1.0.tgz",
+          "integrity": "sha512-s73XxOZ4zpt1edZYZzvhqFa6uvQc1vwUa0K0BdtIZgQMAJj9IbebH+JkgKZc9h+B05PKHLOTl4ajG1BmNrVZlw==",
+          "dev": true
+        },
+        "prepend-http": {
+          "version": "2.0.0",
+          "resolved": "https://registry.npmjs.org/prepend-http/-/prepend-http-2.0.0.tgz",
+          "integrity": "sha1-6SQ0v6XqjBn0HN/UAddBo8gZ2Jc=",
+          "dev": true
+        },
+        "pump": {
+          "version": "3.0.0",
+          "resolved": "https://registry.npmjs.org/pump/-/pump-3.0.0.tgz",
+          "integrity": "sha512-LwZy+p3SFs1Pytd/jYct4wpv49HiYCqd9Rlc5ZVdk0V+8Yzv6jR5Blk3TRmPL1ft69TxP0IMZGJ+WPFU2BFhww==",
+          "dev": true,
+          "requires": {
+            "end-of-stream": "^1.1.0",
+            "once": "^1.3.1"
+          }
+        },
+        "semver": {
+          "version": "6.0.0",
+          "resolved": "https://registry.npmjs.org/semver/-/semver-6.0.0.tgz",
+          "integrity": "sha512-0UewU+9rFapKFnlbirLi3byoOuhrSsli/z/ihNnvM24vgF+8sNBiI1LZPBSH9wJKUwaUbw+s3hToDLCXkrghrQ==",
+          "dev": true
+        },
+        "supports-color": {
+          "version": "6.1.0",
+          "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-6.1.0.tgz",
+          "integrity": "sha512-qe1jfm1Mg7Nq/NSh6XE24gPXROEVsWHxC1LIx//XNlD9iw7YZQGjZNjYN7xGaEG6iKdA8EtNFW6R0gjnVXp+wQ==",
+          "dev": true,
+          "requires": {
+            "has-flag": "^3.0.0"
+          }
+        },
+        "url-parse-lax": {
+          "version": "3.0.0",
+          "resolved": "https://registry.npmjs.org/url-parse-lax/-/url-parse-lax-3.0.0.tgz",
+          "integrity": "sha1-FrXK/Afb42dsGxmZF3gj1lA6yww=",
+          "dev": true,
+          "requires": {
+            "prepend-http": "^2.0.0"
+          }
+        }
+      }
+    },
     "release-zalgo": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/release-zalgo/-/release-zalgo-1.0.0.tgz",
@@ -7261,6 +7634,15 @@
       "integrity": "sha1-LGN/53yJOv0qZj/iGqkIAGjiBSo=",
       "dev": true
     },
+    "responselike": {
+      "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/responselike/-/responselike-1.0.2.tgz",
+      "integrity": "sha1-kYcg7ztjHFZCvgaPFa3lpG9Loec=",
+      "dev": true,
+      "requires": {
+        "lowercase-keys": "^1.0.0"
+      }
+    },
     "restore-cursor": {
       "version": "2.0.0",
       "resolved": "https://registry.npmjs.org/restore-cursor/-/restore-cursor-2.0.0.tgz",
@@ -7587,6 +7969,12 @@
       "resolved": "https://registry.npmjs.org/simple-mime/-/simple-mime-0.1.0.tgz",
       "integrity": "sha1-lfUXxPRm18/1YacfydqyWW6p7y4="
     },
+    "slash": {
+      "version": "2.0.0",
+      "resolved": "https://registry.npmjs.org/slash/-/slash-2.0.0.tgz",
+      "integrity": "sha512-ZYKh3Wh2z1PpEXWr0MpSBZ0V6mZHAQfYevttO11c51CaWjGTaadiKZ+wVt1PbMlDV5qhMFslpZCemhwOK7C89A==",
+      "dev": true
+    },
     "slice-ansi": {
       "version": "2.1.0",
       "resolved": "https://registry.npmjs.org/slice-ansi/-/slice-ansi-2.1.0.tgz",
@@ -9317,7 +9705,7 @@
       "requires": {
         "underscore": "1.8.3",
         "web3-core-helpers": "1.0.0-beta.37",
-        "websocket": "git://github.com/frozeman/WebSocket-Node.git#browserifyCompatible"
+        "websocket": "git://github.com/frozeman/WebSocket-Node.git#6c72925e3f8aaaea8dc8450f97627e85263999f2"
       }
     },
     "web3-shh": {

src/aquarius/Aquarius.ts

@@ -35,7 +35,7 @@ export class Aquarius extends Instantiable {
     }
 
     public async getVersionInfo() {
-        return await (await this.ocean.utils.fetch.get(this.url)).json()
+        return (await this.ocean.utils.fetch.get(this.url)).json()
     }
 
     public async getAccessUrl(accessToken: any, payload: any): Promise<string> {
@@ -213,18 +213,23 @@ export class Aquarius extends Instantiable {
     }
 
     private transformResult(
-        { results, page, total_pages, total_results }: any = {
+        {
+            results,
+            page,
+            total_pages: totalPages,
+            total_results: totalResults
+        }: any = {
             result: [],
             page: 0,
-            total_pages: 0,
+            total_pages: 0, // eslint-disable-line @typescript-eslint/camelcase
-            total_results: 0
+            total_results: 0 // eslint-disable-line @typescript-eslint/camelcase
         }
     ): QueryResult {
         return {
             results: (results || []).map(ddo => new DDO(ddo as DDO)),
             page,
-            totalPages: total_pages,
+            totalPages,
-            totalResults: total_results
+            totalResults
         }
     }
 }

src/brizo/Brizo.ts

@@ -23,7 +23,7 @@ export class Brizo extends Instantiable {
     }
 
     public async getVersionInfo() {
-        return await (await this.ocean.utils.fetch.get(this.url)).json()
+        return (await this.ocean.utils.fetch.get(this.url)).json()
     }
 
     public getPurchaseEndpoint() {
@@ -41,7 +41,7 @@ export class Brizo extends Instantiable {
     public getComputeEndpoint(
         pubKey: string,
         serviceId: string,
-        algo: string,
+        _notUsed: string,
         container: string
     ) {
         // tslint:disable-next-line
@@ -89,7 +89,7 @@ export class Brizo extends Instantiable {
                 account.getId()
             ))
         const filesPromises = files
-            .filter(({}, i) => index === -1 || i === index)
+            .filter((_, i) => index === -1 || i === index)
             .map(async ({ index: i }) => {
                 let consumeUrl = serviceEndpoint
                 consumeUrl += `?index=${i}`

src/ddo/MetaData.ts

@@ -149,7 +149,7 @@ export interface MetaDataBase {
      *    },
      *  ]
      */
-    links?: Array<{ [name: string]: string }>
+    links?: { [name: string]: string }[]
 
     /**
      * The language of the content. Please use one of the language
@@ -241,10 +241,10 @@ export interface AdditionalInformation {
      * describing the dataset.
      * @type {StructuredMarkup[]}
      */
-    structuredMarkup: Array<{
+    structuredMarkup: {
         uri: string
         mediaType: string
-    }>
+    }[]
 
     /**
      * Checksum of attributes to be able to compare if there are changes in

src/keeper/contracts/conditions/AccessSecretStoreCondition.ts

@@ -40,7 +40,7 @@ export class AccessSecretStoreCondition extends Condition {
 
     public async getGrantedDidByConsumer(
         consumer: string
-    ): Promise<Array<{ did: string; agreementId: string }>> {
+    ): Promise<{ did: string; agreementId: string }[]> {
         return (await this.getPastEvents('Fulfilled', {
             _grantee: zeroX(consumer)
         })).map(({ returnValues }) => ({

src/ocean/Account.ts

@@ -54,7 +54,7 @@ export default class Account extends Instantiable {
      * @return {Promise<string>} Account token.
      */
     public async getToken(): Promise<string> {
-        return this.token || (await this.ocean.auth.restore(this))
+        return this.token || this.ocean.auth.restore(this)
     }
 
     /**

src/ocean/OceanAssets.ts

@@ -316,7 +316,7 @@ export class OceanAssets extends Instantiable {
                     this.logger.error('Payment was KO')
                     this.logger.error('Agreement ID: ', agreementId)
                     this.logger.error('DID: ', ddo.id)
-                    reject('Error on payment')
+                    reject(new Error('Error on payment'))
                 }
 
                 await accessGranted

src/ocean/utils/SignatureUtils.ts

@@ -34,6 +34,6 @@ export class SignatureUtils extends Instantiable {
     }
 
     public async verifyText(text: string, signature: string): Promise<string> {
-        return await this.web3.eth.personal.ecRecover(text, signature)
+        return this.web3.eth.personal.ecRecover(text, signature)
     }
 }

src/utils/Logger.ts

@@ -35,7 +35,7 @@ export class Logger {
 
     private dispatch(verb: string, level: LogLevel, ...args: any[]) {
         if (this.logLevel >= level) {
-            console[verb](...args)
+            console[verb](...args) // eslint-disable-line
         }
     }
 }

test/ddo/DDO.test.ts

@@ -79,13 +79,13 @@ describe('DDO', () => {
             {
                 type: 'Consume',
                 serviceEndpoint:
-                    'http://mybrizo.org/api/v1/brizo/services/consume?pubKey=${pubKey}&serviceId={serviceId}&url={url}'
+                    'http://mybrizo.org/api/v1/brizo/services/consume?pubKey={pubKey}&serviceId={serviceId}&url={url}'
             },
             {
                 type: 'Compute',
                 // tslint:disable-next-line
                 serviceEndpoint:
-                    'http://mybrizo.org/api/v1/brizo/services/compute?pubKey=${pubKey}&serviceId={serviceId}&algo={algo}&container={container}'
+                    'http://mybrizo.org/api/v1/brizo/services/compute?pubKey={pubKey}&serviceId={serviceId}&algo={algo}&container={container}'
             },
             {
                 type: 'Metadata',

test/keeper/ContractEvent.test.ts

@@ -43,7 +43,7 @@ describe('ContractEvent', () => {
 
             await Promise.all([executeTransaction(), executeTransaction()])
 
-            await new Promise(_ => setTimeout(_, 2000))
+            await new Promise(resolve => setTimeout(resolve, 2000))
             validResolve = true
 
             await Promise.all([executeTransaction(), executeTransaction()])
@@ -67,7 +67,7 @@ describe('ContractEvent', () => {
             const waitUntilEvent = new Promise((resolve, reject) => {
                 event.once(events => {
                     if (canBeRejected) {
-                        reject()
+                        reject(new Error(''))
                     }
                     setTimeout(resolve, 600)
                 })
@@ -75,7 +75,7 @@ describe('ContractEvent', () => {
 
             await executeTransaction()
 
-            await new Promise(_ => setTimeout(_, 2000))
+            await new Promise(resolve => setTimeout(resolve, 2000))
             canBeRejected = true
 
             await executeTransaction()
@@ -93,7 +93,7 @@ describe('ContractEvent', () => {
 
             const waitUntilEvent = event.once()
 
-            await new Promise(_ => setTimeout(_, 400))
+            await new Promise(resolve => setTimeout(resolve, 400))
 
             await executeTransaction()
 

test/keeper/EventHandler.test.ts

@@ -75,12 +75,12 @@ describe('EventHandler', () => {
 
             const subscription = eventHandler.subscribe(callbackSpy)
 
-            await new Promise(_ => setTimeout(_, 300))
+            await new Promise(resolve => setTimeout(resolve, 300))
 
             expect(callbackSpy).not.to.has.been.called()
             blockNumber++
 
-            await new Promise(_ => setTimeout(_, 300))
+            await new Promise(resolve => setTimeout(resolve, 300))
 
             expect(callbackSpy).to.has.been.called.with(blockNumber)