adapt code rules from codacy

src/keeper/ContractWrapperBase.ts

@@ -1,7 +1,6 @@
 import Event from "web3"
 import Contract from "web3-eth-contract"
 import Config from "../models/Config"
-import Logger from "../utils/Logger"
 import ContractHandler from "./ContractHandler"
 import Web3Helper from "./Web3Helper"
 

src/keeper/Keeper.ts

@@ -8,7 +8,7 @@ export default class Keeper {
 
     public static async getInstance(config: Config, helper: Web3Helper) {
 
-        const contracts = new Keeper(config, helper)
+        const contracts = new Keeper(helper)
 
         contracts.market = await OceanMarket.getInstance(config, helper)
         contracts.auth = await OceanAuth.getInstance(config, helper)
@@ -22,10 +22,7 @@ export default class Keeper {
     public market: OceanMarket
     public auth: OceanAuth
 
-    private config: Config
-
-    private constructor(config: Config, helper: Web3Helper) {
-        this.config = config
+    private constructor(helper: Web3Helper) {
         this.web3Helper = helper
     }
 }

src/keeper/Market.ts

@@ -3,7 +3,6 @@ import {Receipt} from "web3-utils"
 import Asset from "../models/Asset"
 import Config from "../models/Config"
 import Order from "../models/Order"
-import Logger from "../utils/Logger"
 import ContractWrapperBase from "./ContractWrapperBase"
 import Web3Helper from "./Web3Helper"
 

src/ocean/Asset.ts

@@ -1,4 +1,3 @@
-import Keeper from "../keeper/Keeper"
 import AssetModel from "../models/Asset"
 import Logger from "../utils/Logger"
 import OceanBase from "./OceanBase"

src/ocean/Order.ts

@@ -104,7 +104,7 @@ export default class Order extends OceanBase {
         return order
         if (false) {
             // todo: AccessRequestCommitted event is not emitted in this flow
-            const finalOrder: OrderModel = await auth.listenToEventOnce(
+            await auth.listenToEventOnce(
                 "AccessRequestCommitted", {
                     filter: {
                         _id: order.id,

src/ocean/Tribe.ts

@@ -7,11 +7,8 @@ export default class Tribe {
         return new Tribe(web3Helper)
     }
 
-    private web3Helper: Web3Helper
-
     private constructor(web3Helper: Web3Helper) {
 
-        this.web3Helper = web3Helper
     }
 
     // did ddo for tribes/marketplaces

test/keeper/Keeper.test.ts

@@ -3,7 +3,6 @@ import ContractHandler from "../../src/keeper/ContractHandler"
 import Keeper from "../../src/keeper/Keeper"
 import Web3Helper from "../../src/keeper/Web3Helper"
 import Config from "../../src/models/Config"
-import Logger from "../../src/utils/Logger"
 
 let keeper: Keeper
 

test/ocean/Ocean.test.ts

@@ -3,7 +3,6 @@ import ContractHandler from "../../src/keeper/ContractHandler"
 import Web3Helper from "../../src/keeper/Web3Helper"
 import Config from "../../src/models/Config"
 import Ocean from "../../src/ocean/Ocean"
-import Logger from "../../src/utils/Logger"
 
 let ocean: Ocean
 

test/ocean/Order.test.ts

@@ -8,7 +8,6 @@ import OrderModel from "../../src/models/Order"
 import Account from "../../src/ocean/Account"
 import Asset from "../../src/ocean/Asset"
 import Order from "../../src/ocean/Order"
-import Logger from "../../src/utils/Logger";
 
 let keeper: Keeper
 let testAsset: AssetModel

tsconfig.json

@@ -6,6 +6,7 @@
       "es7"
     ],
     "declaration": true,
+    "noUnusedLocals": true,
     "module": "commonjs",
     "noImplicitAny": false,
     "removeComments": true,