oceanprotocol/ocean.js
1
0
Fork 0
mirror of https://github.com/oceanprotocol/ocean.js.git synced 2024-11-26 20:39:05 +01:00
Code Releases Activity

also check for validity of passed data token

Browse Source
This commit is contained in:
Matthias Kretschmann 2020-09-18 10:59:59 +02:00
parent 127b0c2fcc
commit 7d34e1c99c
Signed by: m
GPG Key ID: 606EEEF3C479A91F
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ocean/Assets.ts
View File

@ -67,6 +67,13 @@ export class Assets extends Instantiable {
name?: string,
symbol?: string
): SubscribablePromise<CreateProgressStep, DDO> {
if (!isAddress(dtAddress)) {
this.logger.error(
`Passed Data Token address ${dtAddress} is not valid. Aborting publishing.`
)
return null
}
this.logger.log('Creating asset')
return new SubscribablePromise(async (observer) => {
if (services.length === 0) {

15
test/integration/Marketplaceflow.test.ts
View File

@ -222,6 +222,21 @@ describe('Marketplace flow', () => {
assert.equal(metaData.attributes.additionalInformation.links, newMetaData.links)
})
it('Alice publishes a dataset but passed data token is invalid', async () => {
price = datatoken.toWei('10') // in datatoken
const publishedDate = new Date(Date.now()).toISOString().split('.')[0] + 'Z'
const timeout = 0
service1 = await ocean.assets.createAccessServiceAttributes(
alice,
price,
publishedDate,
timeout
)
ddo = await ocean.assets.create(asset, alice, [service1], 'gibberishDataToken')
assert.equal(ddo, null)
})
it('Alice publishes a dataset but created data token is invalid', async () => {
price = datatoken.toWei('10') // in datatoken
const publishedDate = new Date(Date.now()).toISOString().split('.')[0] + 'Z'