From 44db9db5a4a1c44c752d02c7ef91d827d9f72c1c Mon Sep 17 00:00:00 2001 From: Jamie Hewitt Date: Wed, 20 Apr 2022 14:42:51 +0200 Subject: [PATCH] Writting tests for setPublishingMarketFee --- src/tokens/Datatoken.ts | 6 +++--- test/unit/tokens/Datatoken.test.ts | 26 ++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/src/tokens/Datatoken.ts b/src/tokens/Datatoken.ts index 7a956b52..a9c69f02 100644 --- a/src/tokens/Datatoken.ts +++ b/src/tokens/Datatoken.ts @@ -47,7 +47,7 @@ export interface DispenserParams { export interface PublishingMarketFee { publishMarketFeeAddress: string publishMarketFeeToken: string - publishMarketFeeAmount: number + publishMarketFeeAmount: string } export class Datatoken { @@ -1371,14 +1371,14 @@ export class Datatoken { * @param {string} datatokenAddress Datatoken adress * @param {string} publishMarketFeeAddress new publish Market Fee Address * @param {string} publishMarketFeeToken new publish Market Fee Token - * @param {number} publishMarketFeeAmount new fee amount + * @param {string} publishMarketFeeAmount new fee amount * @param {String} address user adress */ public async setPublishingMarketFee( datatokenAddress: string, publishMarketFeeAddress: string, publishMarketFeeToken: string, - publishMarketFeeAmount: number, + publishMarketFeeAmount: string, address: string ) { const dtContract = new this.web3.eth.Contract(this.datatokensAbi, datatokenAddress, { diff --git a/test/unit/tokens/Datatoken.test.ts b/test/unit/tokens/Datatoken.test.ts index 8c84e8b0..9e8eea2b 100644 --- a/test/unit/tokens/Datatoken.test.ts +++ b/test/unit/tokens/Datatoken.test.ts @@ -552,4 +552,30 @@ describe('Datatoken', () => { const key = web3.utils.keccak256(datatokenAddress) assert((await nftDatatoken.getData(nftAddress, key)) === OldData) }) + + it('#setPublishingMarketFee - nftOwner should be able to set the Publishing Market Fee', async () => { + const originalPublishingMarketFee = await datatoken.getPublishingMarketFee( + datatokenAddress, + nftOwner + ) + try { + await datatoken.setPublishingMarketFee( + datatokenAddress, + nftOwner, + contracts.daiAddress, + web3.utils.toWei('10'), + nftOwner + ) + } catch (e) { + console.log('Error', e) + } + const newPublishingMarketFee = await datatoken.getPublishingMarketFee( + datatokenAddress, + nftOwner + ) + assert(newPublishingMarketFee !== originalPublishingMarketFee) + assert(newPublishingMarketFee.publishMarketFeeAddress === nftOwner) + assert(newPublishingMarketFee.publishMarketFeeToken === contracts.daiAddress) + assert(newPublishingMarketFee.publishMarketFeeAmount === web3.utils.toWei('10')) + }) })