more estGas split and test checks

src/pools/fixedRate/FixedRateExchange.ts

@@ -81,6 +81,7 @@ export class FixedRateExchange {
       defaultERC20ABI.abi as AbiItem[],
       token
     )
+    console.log('1')
     try {
       decimals = await tokenContract.methods.decimals().call()
     } catch (e) {
@@ -123,31 +124,55 @@ export class FixedRateExchange {
       .call()
     return exchangeId
   }
-
+  /**
+   * Estimate gas cost for buyDT
+   * @param {String} account
+   * @param {String} dtAmount datatoken amount we want to buy
+   * @param {String} datatokenAddress datatokenAddress
+   * @param {Contract} contractInstance optional contract instance
+   * @return {Promise<number>}
+   */
+   public async estBuyDT(
+    account: string,
+    datatokenAddress: string,
+    dtAmount:string,
+    maxBasetokenAmount: string,
+    contractInstance?: Contract
+  ): Promise<number> {
+    const fixedRate =
+      contractInstance || this.fixedRateContract
+    const gasLimitDefault = this.GASLIMIT_DEFAULT
+    let estGas
+    try {
+      estGas = await fixedRate.methods
+        .buyDT(datatokenAddress,dtAmount.toString(),maxBasetokenAmount.toString())
+        .estimateGas({ from: account }, (err, estGas) => (err ? gasLimitDefault : estGas))
+    } catch (e) {
+      estGas = gasLimitDefault
+    }
+    return estGas
+  }
   /**
    * Atomic swap
    * @param {String} exchangeId ExchangeId
-   * @param {Number} dataTokenAmount Amount of Data Tokens
+   * @param {String} datatokenAmount Amount of Data Tokens
+   * @param {String} maxBasetokenAmount max amount of basetoken we want to pay for dataTokenAmount
    * @param {String} address User address
    * @return {Promise<TransactionReceipt>} transaction receipt
    */
   public async buyDT(
+    address: string,
     exchangeId: string,
-    dataTokenAmount: string,
+    datatokenAmount: string,
-    address: string
+    maxBasetokenAmount:string
   ): Promise<TransactionReceipt> {
-    const gasLimitDefault = this.GASLIMIT_DEFAULT
+    const dtAmountFormatted = await this.amountToUnits(((await this.getExchange(exchangeId)).dataToken),datatokenAmount)
-    let estGas
+    const maxBtFormatted = await this.amountToUnits(((await this.getExchange(exchangeId)).baseToken),maxBasetokenAmount)
-    try {
+  
-      estGas = await this.contract.methods
+    const estGas = await this.estBuyDT(address,exchangeId,dtAmountFormatted,maxBtFormatted)
-        .swap(exchangeId, this.web3.utils.toWei(String(dataTokenAmount)))
-        .estimateGas({ from: address }, (err, estGas) => (err ? gasLimitDefault : estGas))
-    } catch (e) {
-      estGas = gasLimitDefault
-    }
     try {
       const trxReceipt = await this.contract.methods
-        .swap(exchangeId, this.web3.utils.toWei(String(dataTokenAmount)))
+        .buyDT(exchangeId, dtAmountFormatted,maxBtFormatted)
         .send({
           from: address,
           gas: estGas + 1,
@@ -160,6 +185,67 @@ export class FixedRateExchange {
     }
   }
 
+  /**
+   * Estimate gas cost for sellDT
+   * @param {String} account
+   * @param {String} dtAmount datatoken amount we want to sell
+   * @param {String} datatokenAddress datatokenAddress
+   * @param {Contract} contractInstance optional contract instance
+   * @return {Promise<number>}
+   */
+   public async estSellDT(
+    account: string,
+    datatokenAddress: string,
+    dtAmount:string,
+    maxBasetokenAmount: string,
+    contractInstance?: Contract
+  ): Promise<number> {
+    const fixedRate =
+      contractInstance || this.fixedRateContract
+    const gasLimitDefault = this.GASLIMIT_DEFAULT
+    let estGas
+    try {
+      estGas = await fixedRate.methods
+        .sellDT(datatokenAddress,dtAmount,maxBasetokenAmount)
+        .estimateGas({ from: account }, (err, estGas) => (err ? gasLimitDefault : estGas))
+    } catch (e) {
+      estGas = gasLimitDefault
+    }
+    return estGas
+  }
+  /**
+   * Atomic swap
+   * @param {String} exchangeId ExchangeId
+   * @param {String} datatokenAmount Amount of Data Tokens
+   * @param {String} minBasetokenAmount min amount of basetoken we want to receive back
+   * @param {String} address User address
+   * @return {Promise<TransactionReceipt>} transaction receipt
+   */
+  public async sellDT(
+    address: string,
+    exchangeId: string,
+    datatokenAmount: string,
+    minBasetokenAmount:string
+  ): Promise<TransactionReceipt> {
+    
+    const dtAmountFormatted = await this.amountToUnits((await this.getExchange(exchangeId)).dataToken,datatokenAmount)
+    const minBtFormatted = await this.amountToUnits((await this.getExchange(exchangeId)).baseToken,minBasetokenAmount)
+    const estGas = await this.estBuyDT(address,exchangeId,dtAmountFormatted,minBtFormatted)
+    try {
+      const trxReceipt = await this.contract.methods
+        .sellDT(exchangeId, dtAmountFormatted,minBtFormatted)
+        .send({
+          from: address,
+          gas: estGas + 1,
+          gasPrice: await getFairGasPrice(this.web3)
+        })
+      return trxReceipt
+    } catch (e) {
+      this.logger.error(`ERROR: Failed to sell datatokens: ${e.message}`)
+      return null
+    }
+  }
+
   /**
    * Gets total number of exchanges
    * @param {String} exchangeId ExchangeId
@@ -171,6 +257,34 @@ export class FixedRateExchange {
     return numExchanges
   }
 
+  /**
+   * Estimate gas cost for setRate
+   * @param {String} account
+   * @param {String} exchangeId ExchangeId
+   * @param {Number} newRate New rate
+   * @param {Contract} contractInstance optional contract instance
+   * @return {Promise<number>}
+   */
+   public async estSetRate(
+    account: string,
+    exchangeId: string,
+    newRate:string,
+    contractInstance?: Contract
+  ): Promise<number> {
+    const fixedRate =
+      contractInstance || this.fixedRateContract
+    const gasLimitDefault = this.GASLIMIT_DEFAULT
+    let estGas
+    try {
+      estGas = await fixedRate.methods
+        .setRate(exchangeId,newRate)
+        .estimateGas({ from: account }, (err, estGas) => (err ? gasLimitDefault : estGas))
+    } catch (e) {
+      estGas = gasLimitDefault
+    }
+    return estGas
+  }
+
   /**
    * Set new rate
    * @param {String} exchangeId ExchangeId
@@ -179,19 +293,13 @@ export class FixedRateExchange {
    * @return {Promise<TransactionReceipt>} transaction receipt
    */
   public async setRate(
+    address: string,
     exchangeId: string,
     newRate: number,
-    address: string
+    
   ): Promise<TransactionReceipt> {
-    const gasLimitDefault = this.GASLIMIT_DEFAULT
+ 
-    let estGas
+    const estGas = await this.estSetRate(address,exchangeId,this.web3.utils.toWei(String(newRate)))
-    try {
-      estGas = await this.contract.methods
-        .setRate(exchangeId, this.web3.utils.toWei(String(newRate)))
-        .estimateGas({ from: address }, (err, estGas) => (err ? gasLimitDefault : estGas))
-    } catch (e) {
-      estGas = gasLimitDefault
-    }
     const trxReceipt = await this.contract.methods
       .setRate(exchangeId, this.web3.utils.toWei(String(newRate)))
       .send({
@@ -202,6 +310,32 @@ export class FixedRateExchange {
     return trxReceipt
   }
 
+    /**
+   * Estimate gas cost for activate
+   * @param {String} account
+   * @param {String} exchangeId ExchangeId
+   * @param {Contract} contractInstance optional contract instance
+   * @return {Promise<number>}
+   */
+     public async estActivate(
+      account: string,
+      exchangeId: string,
+      contractInstance?: Contract
+    ): Promise<number> {
+      const fixedRate =
+        contractInstance || this.fixedRateContract
+      const gasLimitDefault = this.GASLIMIT_DEFAULT
+      let estGas
+      try {
+        estGas = await fixedRate.methods
+        .toggleExchangeState(exchangeId)
+          .estimateGas({ from: account }, (err, estGas) => (err ? gasLimitDefault : estGas))
+      } catch (e) {
+        estGas = gasLimitDefault
+      }
+      return estGas
+    }
+
   /**
    * Activate an exchange
    * @param {String} exchangeId ExchangeId
@@ -209,21 +343,15 @@ export class FixedRateExchange {
    * @return {Promise<TransactionReceipt>} transaction receipt
    */
   public async activate(
-    exchangeId: string,
+    address: string,
-    address: string
+    exchangeId: string
   ): Promise<TransactionReceipt> {
     const exchange = await this.getExchange(exchangeId)
     if (!exchange) return null
     if (exchange.active === true) return null
     const gasLimitDefault = this.GASLIMIT_DEFAULT
-    let estGas
+    
-    try {
+    const estGas = await this.estActivate(address,exchangeId)
-      estGas = await this.contract.methods
-        .toggleExchangeState(exchangeId)
-        .estimateGas({ from: address }, (err, estGas) => (err ? gasLimitDefault : estGas))
-    } catch (e) {
-      estGas = gasLimitDefault
-    }
     const trxReceipt = await this.contract.methods.toggleExchangeState(exchangeId).send({
       from: address,
       gas: estGas + 1,
@@ -232,6 +360,34 @@ export class FixedRateExchange {
     return trxReceipt
   }
 
+      /**
+   * Estimate gas cost for deactivate
+   * @param {String} account
+   * @param {String} exchangeId ExchangeId
+   * @param {Contract} contractInstance optional contract instance
+   * @return {Promise<number>}
+   */
+       public async estDeactivate(
+        account: string,
+        exchangeId: string,
+        contractInstance?: Contract
+      ): Promise<number> {
+        const fixedRate =
+          contractInstance || this.fixedRateContract
+        const gasLimitDefault = this.GASLIMIT_DEFAULT
+        let estGas
+        try {
+          estGas = await fixedRate.methods
+          .toggleExchangeState(exchangeId)
+            .estimateGas({ from: account }, (err, estGas) => (err ? gasLimitDefault : estGas))
+        } catch (e) {
+          estGas = gasLimitDefault
+        }
+        return estGas
+      }
+
+      
+
   /**
    * Deactivate an exchange
    * @param {String} exchangeId ExchangeId
@@ -239,21 +395,15 @@ export class FixedRateExchange {
    * @return {Promise<TransactionReceipt>} transaction receipt
    */
   public async deactivate(
-    exchangeId: string,
+    address: string,
-    address: string
+    exchangeId: string
+    
   ): Promise<TransactionReceipt> {
     const exchange = await this.getExchange(exchangeId)
     if (!exchange) return null
     if (exchange.active === false) return null
-    const gasLimitDefault = this.GASLIMIT_DEFAULT
+   
-    let estGas
+    const estGas = await this.estDeactivate(address,exchangeId)
-    try {
-      estGas = await this.contract.methods
-        .toggleExchangeState(exchangeId)
-        .estimateGas({ from: address }, (err, estGas) => (err ? gasLimitDefault : estGas))
-    } catch (e) {
-      estGas = gasLimitDefault
-    }
     const trxReceipt = await this.contract.methods.toggleExchangeState(exchangeId).send({
       from: address,
       gas: estGas + 1,
@@ -293,7 +443,7 @@ export class FixedRateExchange {
     dataTokenAmount: string
   ): Promise<string> {
     const weiRate = await this.contract.methods
-      .CalcInGivenOut(exchangeId, this.web3.utils.toWei(dataTokenAmount))
+      .calcBaseInGivenOutDT(exchangeId, this.web3.utils.toWei(dataTokenAmount))
       .call()
     return this.web3.utils.fromWei(weiRate)
   }
@@ -307,9 +457,9 @@ export class FixedRateExchange {
     const result: FixedPriceExchange = await this.contract.methods
       .getExchange(exchangeId)
       .call()
-    result.fixedRate = this.web3.utils.fromWei(result.fixedRate)
+  //  result.fixedRate = this.web3.utils.fromWei(result.fixedRate)
-    result.supply = this.web3.utils.fromWei(result.supply)
+  //  result.supply = this.web3.utils.fromWei(result.supply)
-    result.exchangeID = exchangeId
+   // result.exchangeID = exchangeId
     return result
   }
 

test/unit/pools/fixedRate/FixedRateExchange.test.ts

@@ -18,6 +18,7 @@ import { LoggerInstance } from '../../../../src/utils'
 import { NFTFactory } from '../../../../src/factories/NFTFactory'
 import { Pool } from '../../../../src/pools/balancer/Pool'
 import { FixedRateExchange } from '../../../../src/pools/fixedRate/FixedRateExchange'
+import { BADFAMILY } from 'dns'
 const { keccak256 } = require('@ethersproject/keccak256')
 const web3 = new Web3('http://127.0.0.1:8545')
 const communityCollector = '0xeE9300b7961e0a01d9f0adb863C7A227A07AaD75'
@@ -157,5 +158,34 @@ describe('Fixed Rate unit test', () => {
       )
     })
 
+    it('#buyDT - user2 should buy some dt', async () => {
+      await dtContract.methods.mint(exchangeOwner,web3.utils.toWei('1000')).send({from:exchangeOwner})
+      await dtContract.methods.approve(fixedRateAddress,web3.utils.toWei('1000')).send({from:exchangeOwner})
+      await daiContract.methods.transfer(user2,web3.utils.toWei('100')).send({from:exchangeOwner})
+      await daiContract.methods.approve(fixedRateAddress,web3.utils.toWei('100')).send({from:user2})
+      const tx = await fixedRate.buyDT(user2,exchangeId,'10','11')
+    //  console.log(tx.events.Swapped.returnValues)
+      assert(tx.events.Swapped != null)
+      const args = tx.events.Swapped.returnValues
+      expect(args.exchangeId).to.equal(exchangeId)
+      expect(args.by).to.equal(user2)
+      expect(args.dataTokenSwappedAmount).to.equal(web3.utils.toWei('10'))
+      expect(args.tokenOutAddress).to.equal(dtAddress)
+
+    })
+
+    it('#sellDT - user2 should sell some dt', async () => {
+ 
+      await dtContract.methods.approve(fixedRateAddress,web3.utils.toWei('10')).send({from:user2})
+      const tx = await fixedRate.sellDT(user2,exchangeId,'10','9')
+     // console.log(tx.events.Swapped.returnValues)
+      assert(tx.events.Swapped != null)
+      const args = tx.events.Swapped.returnValues
+      expect(args.exchangeId).to.equal(exchangeId)
+      expect(args.by).to.equal(user2)
+      expect(args.dataTokenSwappedAmount).to.equal(web3.utils.toWei('10'))
+      expect(args.tokenOutAddress).to.equal(contracts.daiAddress)
+    })
+
   })
 })