1
0
mirror of https://github.com/oceanprotocol/market.git synced 2024-07-01 06:11:43 +02:00

run validation only when custom image is selected

This commit is contained in:
Bogdan Fazakas 2021-02-26 16:15:41 +02:00
parent a770fdac55
commit f4f7ecefc8
2 changed files with 31 additions and 24 deletions

View File

@ -156,35 +156,36 @@ export default function PublishPage({
) => void
): Promise<void> {
const metadata = transformPublishAlgorithmFormToMetadata(values)
const validDockerImage =
values.dockerImage === 'custom image'
? await validateDockerImage(values.image, values.containerTag)
: true
try {
Logger.log('Publish Algorithm with ', metadata)
if (validDockerImage) {
Logger.log('Publish Algorithm with ', metadata)
const validImage = await validateDockerImage(
values.image,
values.containerTag
)
const ddo = await publish(
(metadata as unknown) as Metadata,
values.algorithmPrivacy === true ? 'compute' : 'access'
)
const ddo = await publish(
(metadata as unknown) as Metadata,
values.algorithmPrivacy === true ? 'compute' : 'access'
)
// Publish failed
if (!ddo || publishError) {
setError(publishError || 'Publishing DDO failed.')
Logger.error(publishError || 'Publishing DDO failed.')
return
}
// Publish failed
if (!ddo || publishError) {
setError(publishError || 'Publishing DDO failed.')
Logger.error(publishError || 'Publishing DDO failed.')
return
// Publish succeeded
setDid(ddo.id)
setSuccess(
'🎉 Successfully published. 🎉 Now create a price for your algorithm.'
)
resetForm({
values: initialValuesAlgorithm as MetadataPublishFormAlgorithm,
status: 'empty'
})
}
// Publish succeeded
setDid(ddo.id)
setSuccess(
'🎉 Successfully published. 🎉 Now create a price for your algorithm.'
)
resetForm({
values: initialValuesAlgorithm as MetadataPublishFormAlgorithm,
status: 'empty'
})
} catch (error) {
setError(error.message)
Logger.error(error.message)

View File

@ -148,6 +148,9 @@ async function isDockerHubImageValid(
return true
} catch (error) {
Logger.error(error.message)
toast.error(
'Could not fetch docker hub image info. Please check image name and tag and try again'
)
return false
}
}
@ -164,6 +167,9 @@ async function is3rdPartyImageValid(imageURL: string): Promise<boolean> {
return true
} catch (error) {
Logger.error(error.message)
toast.error(
'Could not fetch docker image info. Please check URL and try again'
)
return false
}
}