From ef00160f65b379667b9d9039b8dca2ae05fda6cd Mon Sep 17 00:00:00 2001 From: Matthias Kretschmann Date: Thu, 24 Sep 2020 13:33:33 +0200 Subject: [PATCH] run type checking as part of linting --- package.json | 2 +- src/components/atoms/Table/ActionsCell.tsx | 25 ------------------- tests/unit/__mocks__/@oceanprotocol/react.tsx | 6 ++--- 3 files changed, 4 insertions(+), 29 deletions(-) delete mode 100644 src/components/atoms/Table/ActionsCell.tsx diff --git a/package.json b/package.json index 989c23a45..02b7ef0bf 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "jest": "NODE_ENV=test jest -c tests/unit/jest.config.js", "test": "npm run lint && npm run jest", "test:watch": "npm run lint && npm run jest -- --watch", - "lint": "eslint --ignore-path .gitignore --ext .js --ext .ts --ext .tsx .", + "lint": "eslint --ignore-path .gitignore --ext .js --ext .ts --ext .tsx . && npm run type-check", "format": "prettier --ignore-path .gitignore './**/*.{css,yml,js,ts,tsx,json}' --write", "type-check": "tsc --noEmit", "analyze": "npm run build && source-map-explorer 'public/*.js'", diff --git a/src/components/atoms/Table/ActionsCell.tsx b/src/components/atoms/Table/ActionsCell.tsx deleted file mode 100644 index c91318358..000000000 --- a/src/components/atoms/Table/ActionsCell.tsx +++ /dev/null @@ -1,25 +0,0 @@ -import React, { ReactElement } from 'react' -import Eye from '../../../images/eye.svg' -import Button from '../Button' -import Tooltip from '../Tooltip' -import { ComputeItem } from '@oceanprotocol/react' - -export declare type ActionsCellProps = { - handleOnClickViewJobDetails?: (computeItem: ComputeItem) => void -} - -export default function ActionsCell({ - handleOnClickViewJobDetails -}: ActionsCellProps): ReactElement { - return ( - <> - {handleOnClickViewJobDetails && ( - - - - )} - - ) -} diff --git a/tests/unit/__mocks__/@oceanprotocol/react.tsx b/tests/unit/__mocks__/@oceanprotocol/react.tsx index 60bd01590..0d1c65f4e 100644 --- a/tests/unit/__mocks__/@oceanprotocol/react.tsx +++ b/tests/unit/__mocks__/@oceanprotocol/react.tsx @@ -13,9 +13,9 @@ const reactMock = { return { ocean: libMock.ocean, config: {}, - web3: null, - web3Modal: null, - web3Provider: null, + web3: null as any, + web3Modal: null as any, + web3Provider: null as any, accountId: '0x0000000011111111aaaaaaaabbbbbbbb22222222', balance: '0.12' }