From 53188875c027e8ab5c213fad845ca174214fa7f5 Mon Sep 17 00:00:00 2001
From: Matthias Kretschmann <m@kretschmann.io>
Date: Mon, 12 Oct 2020 13:22:59 +0200
Subject: [PATCH] refactor

---
 .../Pool/PoolStatistics.module.css            |  3 --
 .../AssetActions/Pool/PoolStatistics.tsx      | 41 -------------------
 .../AssetActions/Pool/TokenList.module.css    | 25 ++++++++++-
 .../organisms/AssetActions/Pool/TokenList.tsx | 27 +++++++++++-
 .../AssetActions/Pool/index.module.css        | 15 -------
 .../organisms/AssetActions/Pool/index.tsx     | 40 +++++++++---------
 6 files changed, 69 insertions(+), 82 deletions(-)
 delete mode 100644 src/components/organisms/AssetActions/Pool/PoolStatistics.module.css
 delete mode 100644 src/components/organisms/AssetActions/Pool/PoolStatistics.tsx

diff --git a/src/components/organisms/AssetActions/Pool/PoolStatistics.module.css b/src/components/organisms/AssetActions/Pool/PoolStatistics.module.css
deleted file mode 100644
index edf3b9cde..000000000
--- a/src/components/organisms/AssetActions/Pool/PoolStatistics.module.css
+++ /dev/null
@@ -1,3 +0,0 @@
-.totalLiquidity {
-  composes: totalLiquidity from './index.module.css';
-}
diff --git a/src/components/organisms/AssetActions/Pool/PoolStatistics.tsx b/src/components/organisms/AssetActions/Pool/PoolStatistics.tsx
deleted file mode 100644
index 2b5620d97..000000000
--- a/src/components/organisms/AssetActions/Pool/PoolStatistics.tsx
+++ /dev/null
@@ -1,41 +0,0 @@
-import React, { ReactElement } from 'react'
-import { Balance } from '.'
-import styles from './PoolStatistics.module.css'
-import Token from './Token'
-import Conversion from '../../../atoms/Price/Conversion'
-import TokenList from './TokenList'
-
-export default function PoolStatistics({
-  price,
-  dtSymbol,
-  totalBalance,
-  totalPoolTokens,
-  swapFee
-}: {
-  price: string
-  dtSymbol: string
-  totalBalance: Balance
-  totalPoolTokens: string
-  swapFee: string
-}): ReactElement {
-  const totalLiquidityInOcean =
-    totalBalance.ocean + totalBalance.datatoken * Number(price)
-
-  return (
-    <TokenList title="Pool Statistics">
-      <div>
-        <Token symbol="OCEAN" balance={`${totalBalance.ocean}`} />
-        <Token symbol={dtSymbol} balance={`${totalBalance.datatoken}`} />
-      </div>
-      <div>
-        <Token symbol="pool shares" balance={totalPoolTokens} noIcon />
-        <Token symbol="% swap fee" balance={swapFee} noIcon />
-      </div>
-
-      <Conversion
-        price={`${totalLiquidityInOcean}`}
-        className={styles.totalLiquidity}
-      />
-    </TokenList>
-  )
-}
diff --git a/src/components/organisms/AssetActions/Pool/TokenList.module.css b/src/components/organisms/AssetActions/Pool/TokenList.module.css
index eb94b2a25..da7e29f59 100644
--- a/src/components/organisms/AssetActions/Pool/TokenList.module.css
+++ b/src/components/organisms/AssetActions/Pool/TokenList.module.css
@@ -5,7 +5,15 @@
 .tokens {
   display: grid;
   grid-template-columns: 1fr 1fr;
-  grid-auto-flow: row;
+}
+
+/* visually tweak the order so tokens are underneath each other */
+.tokens > *:nth-child(1) {
+  grid-row: 1 / 2;
+}
+
+.tokens > *:nth-child(2) {
+  grid-row: 2 / 2;
 }
 
 .title {
@@ -22,3 +30,18 @@
   margin-left: -2rem;
   margin-right: -2rem;
 }
+
+.totalLiquidity {
+  composes: token from './Token.module.css';
+  margin-bottom: 0;
+  font-weight: var(--font-weight-base) !important;
+  font-size: var(--font-size-small);
+  padding-left: var(--font-size-base);
+  padding-top: calc(var(--spacer) / 10);
+}
+
+.totalLiquidity strong {
+  font-size: var(--font-size-base);
+  color: var(--brand-grey-dark);
+  line-height: 1;
+}
diff --git a/src/components/organisms/AssetActions/Pool/TokenList.tsx b/src/components/organisms/AssetActions/Pool/TokenList.tsx
index 91acdc066..c6ca8fa49 100644
--- a/src/components/organisms/AssetActions/Pool/TokenList.tsx
+++ b/src/components/organisms/AssetActions/Pool/TokenList.tsx
@@ -1,19 +1,44 @@
+import Conversion from '../../../atoms/Price/Conversion'
 import React, { ReactElement, ReactNode } from 'react'
+import Token from './Token'
 import styles from './TokenList.module.css'
 
 export default function TokenList({
   title,
   children,
+  ocean,
+  dt,
+  dtSymbol,
+  poolShares,
+  conversion,
   highlight
 }: {
   title: string | ReactNode
   children: ReactNode
+  ocean: string
+  dt: string
+  dtSymbol: string
+  poolShares: string
+  conversion: number
   highlight?: boolean
 }): ReactElement {
   return (
     <div className={`${styles.tokeninfo} ${highlight ? styles.highlight : ''}`}>
       <h3 className={styles.title}>{title}</h3>
-      <div className={styles.tokens}>{children}</div>
+      <div className={styles.tokens}>
+        <Token symbol="OCEAN" balance={ocean} />
+        <Token symbol={dtSymbol} balance={dt} />
+        <Token symbol="pool shares" balance={poolShares} noIcon />
+
+        {children}
+
+        {conversion > 0 && (
+          <Conversion
+            price={`${conversion}`}
+            className={styles.totalLiquidity}
+          />
+        )}
+      </div>
     </div>
   )
 }
diff --git a/src/components/organisms/AssetActions/Pool/index.module.css b/src/components/organisms/AssetActions/Pool/index.module.css
index b886d7e22..dc618def9 100644
--- a/src/components/organisms/AssetActions/Pool/index.module.css
+++ b/src/components/organisms/AssetActions/Pool/index.module.css
@@ -20,18 +20,3 @@
   margin-left: calc(var(--spacer) / 3);
   margin-right: calc(var(--spacer) / 3);
 }
-
-.totalLiquidity {
-  composes: token from './Token.module.css';
-  margin-bottom: 0;
-  font-weight: var(--font-weight-base) !important;
-  font-size: var(--font-size-small);
-  padding-left: var(--font-size-base);
-  padding-top: calc(var(--spacer) / 10);
-}
-
-.totalLiquidity strong {
-  font-size: var(--font-size-base);
-  color: var(--brand-grey-dark);
-  line-height: 1;
-}
diff --git a/src/components/organisms/AssetActions/Pool/index.tsx b/src/components/organisms/AssetActions/Pool/index.tsx
index 0d0dff7c6..6c17ffad7 100644
--- a/src/components/organisms/AssetActions/Pool/index.tsx
+++ b/src/components/organisms/AssetActions/Pool/index.tsx
@@ -11,7 +11,6 @@ import Remove from './Remove'
 import Tooltip from '../../../atoms/Tooltip'
 import Conversion from '../../../atoms/Price/Conversion'
 import EtherscanLink from '../../../atoms/EtherscanLink'
-import PoolStatistics from './PoolStatistics'
 import Token from './Token'
 import TokenList from './TokenList'
 
@@ -38,6 +37,8 @@ export default function Pool({ ddo }: { ddo: DDO }): ReactElement {
   const [showRemove, setShowRemove] = useState(false)
   const [isLoading, setIsLoading] = useState(true)
 
+  // TODO: put all these variables behind some useEffect
+  // to prevent unneccessary updating on every render
   const hasAddedLiquidity =
     userLiquidity && (userLiquidity.ocean > 0 || userLiquidity.datatoken > 0)
 
@@ -50,6 +51,8 @@ export default function Pool({ ddo }: { ddo: DDO }): ReactElement {
   const totalUserLiquidityInOcean =
     userLiquidity?.ocean + userLiquidity?.datatoken * price?.value
 
+  const totalLiquidityInOcean = price?.ocean + price?.datatoken * price?.value
+
   useEffect(() => {
     if (!ocean || !accountId || !price || !price.value) return
 
@@ -153,31 +156,26 @@ export default function Pool({ ddo }: { ddo: DDO }): ReactElement {
                 <Tooltip content="Explain what this represents, advantage of providing liquidity..." />
               </>
             }
+            ocean={`${userLiquidity.ocean}`}
+            dt={`${userLiquidity.datatoken}`}
+            dtSymbol={dtSymbol}
+            poolShares={poolTokens}
+            conversion={totalUserLiquidityInOcean}
             highlight
           >
-            <div>
-              <Token symbol="OCEAN" balance={`${userLiquidity.ocean}`} />
-              <Token symbol={dtSymbol} balance={`${userLiquidity.datatoken}`} />
-            </div>
-            <div>
-              <Token symbol="pool shares" balance={poolTokens} noIcon />
-              <Token symbol="% of pool" balance={poolShare} noIcon />
-            </div>
-            {totalUserLiquidityInOcean > 0 && (
-              <Conversion
-                price={`${totalUserLiquidityInOcean}`}
-                className={styles.totalLiquidity}
-              />
-            )}
+            <Token symbol="% of pool" balance={poolShare} noIcon />
           </TokenList>
 
-          <PoolStatistics
-            price={`${price.value}`}
-            totalPoolTokens={totalPoolTokens}
-            totalBalance={{ ocean: price.ocean, datatoken: price.datatoken }}
-            swapFee={swapFee}
+          <TokenList
+            title="Pool Statistics"
+            ocean={`${price.ocean}`}
+            dt={`${price.datatoken}`}
             dtSymbol={dtSymbol}
-          />
+            poolShares={totalPoolTokens}
+            conversion={totalLiquidityInOcean}
+          >
+            <Token symbol="% swap fee" balance={swapFee} noIcon />
+          </TokenList>
 
           <div className={stylesActions.actions}>
             <Button