1
0
mirror of https://github.com/oceanprotocol/market.git synced 2024-11-16 02:04:54 +01:00

add eslint-plugin-react-hooks

This commit is contained in:
Matthias Kretschmann 2020-09-16 11:08:35 +02:00
parent 350ad32e05
commit 067c211258
Signed by: m
GPG Key ID: 606EEEF3C479A91F
5 changed files with 21 additions and 17 deletions

View File

@ -22,7 +22,8 @@
"plugin:prettier/recommended", "plugin:prettier/recommended",
"prettier/react", "prettier/react",
"prettier/standard", "prettier/standard",
"prettier/@typescript-eslint" "prettier/@typescript-eslint",
"plugin:react-hooks/recommended"
], ],
"plugins": ["@typescript-eslint", "prettier"], "plugins": ["@typescript-eslint", "prettier"],
"rules": { "rules": {

12
package-lock.json generated
View File

@ -13923,9 +13923,10 @@
} }
}, },
"eslint-plugin-react-hooks": { "eslint-plugin-react-hooks": {
"version": "1.7.0", "version": "4.1.2",
"resolved": "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-1.7.0.tgz", "resolved": "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-4.1.2.tgz",
"integrity": "sha512-iXTCFcOmlWvw4+TOE8CLWj6yX1GwzT0Y6cUfHHZqWnSk144VmVIRcVGtUAzrLES7C798lmvnt02C7rxaOX1HNA==" "integrity": "sha512-ykUeqkGyUGgwTtk78C0o8UG2fzwmgJ0qxBGPp2WqRKsTwcLuVf01kTDRAtOsd4u6whX2XOC8749n2vPydP82fg==",
"dev": true
}, },
"eslint-plugin-security": { "eslint-plugin-security": {
"version": "1.4.0", "version": "1.4.0",
@ -16437,6 +16438,11 @@
} }
} }
}, },
"eslint-plugin-react-hooks": {
"version": "1.7.0",
"resolved": "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-1.7.0.tgz",
"integrity": "sha512-iXTCFcOmlWvw4+TOE8CLWj6yX1GwzT0Y6cUfHHZqWnSk144VmVIRcVGtUAzrLES7C798lmvnt02C7rxaOX1HNA=="
},
"execa": { "execa": {
"version": "4.0.3", "version": "4.0.3",
"resolved": "https://registry.npmjs.org/execa/-/execa-4.0.3.tgz", "resolved": "https://registry.npmjs.org/execa/-/execa-4.0.3.tgz",

View File

@ -105,6 +105,7 @@
"eslint-config-prettier": "^6.11.0", "eslint-config-prettier": "^6.11.0",
"eslint-plugin-prettier": "^3.1.4", "eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.20.6", "eslint-plugin-react": "^7.20.6",
"eslint-plugin-react-hooks": "^4.1.2",
"identity-obj-proxy": "^3.0.0", "identity-obj-proxy": "^3.0.0",
"jest": "^26.4.2", "jest": "^26.4.2",
"prettier": "^2.1.2", "prettier": "^2.1.2",

View File

@ -11,11 +11,9 @@ const cx = classNames.bind(styles)
export default function Conversion({ export default function Conversion({
price, price,
update = true,
className className
}: { }: {
price: string // expects price in OCEAN, not wei price: string // expects price in OCEAN, not wei
update?: boolean
className?: string className?: string
}): ReactElement { }): ReactElement {
const { appConfig } = useSiteMetadata() const { appConfig } = useSiteMetadata()
@ -56,15 +54,13 @@ export default function Conversion({
if (isBrowser && price !== '0') { if (isBrowser && price !== '0') {
getData() getData()
} }
}, [price, currency]) }, [price, currency, url])
if (update) {
// Fetch new prices periodically with swr // Fetch new prices periodically with swr
useSWR(url, fetchData, { useSWR(url, fetchData, {
refreshInterval: 30000, // 30 sec. refreshInterval: 30000, // 30 sec.
onSuccess onSuccess
}) })
}
return ( return (
<span <span

View File

@ -15,8 +15,6 @@ export default function Pagination({
hrefBuilder, hrefBuilder,
onPageChange onPageChange
}: PaginationProps): ReactElement { }: PaginationProps): ReactElement {
if (!totalPages || totalPages < 2) return null
const [smallViewport, setSmallViewport] = useState(true) const [smallViewport, setSmallViewport] = useState(true)
function viewportChange(mq: { matches: boolean }) { function viewportChange(mq: { matches: boolean }) {
@ -24,6 +22,8 @@ export default function Pagination({
} }
useEffect(() => { useEffect(() => {
if (!totalPages || totalPages < 2) return null
const mq = window.matchMedia('(min-width: 600px)') const mq = window.matchMedia('(min-width: 600px)')
viewportChange(mq) viewportChange(mq)
mq.addListener(viewportChange) mq.addListener(viewportChange)
@ -31,7 +31,7 @@ export default function Pagination({
return () => { return () => {
mq.removeListener(viewportChange) mq.removeListener(viewportChange)
} }
}, []) }, [totalPages])
return ( return (
<ReactPaginate <ReactPaginate