Fixed change labels display.

This commit is contained in:
Mike Cao 2024-06-05 15:09:33 -07:00
parent 6c79175077
commit 9abb201d86
2 changed files with 7 additions and 6 deletions

View File

@ -62,7 +62,7 @@ export function WebsiteMetricsBar({
change:
(Math.min(visitors.value, bounces.value) / visitors.value) * 100 -
(Math.min(visitors.prev, bounces.prev) / visitors.prev) * 100,
formatValue: n => Number(n).toFixed(0) + '%',
formatValue: n => Math.round(+n) + '%',
reverseColors: true,
},
{

View File

@ -19,21 +19,22 @@ export function ChangeLabel({
className?: string;
children?: ReactNode;
}) {
const positive = value * (reverseColors ? -1 : 1) >= 0;
const negative = value * (reverseColors ? -1 : 1) < 0;
const positive = value >= 0;
const negative = value < 0;
const neutral = value === 0 || isNaN(value);
const good = reverseColors ? negative : positive;
return (
<div
className={classNames(styles.label, className, {
[styles.positive]: positive,
[styles.negative]: negative,
[styles.positive]: good,
[styles.negative]: !good,
[styles.neutral]: neutral,
})}
title={title}
>
{!neutral && (
<Icon rotate={value === 0 ? 0 : positive || reverseColors ? -90 : 90} size={size}>
<Icon rotate={positive ? -90 : 90} size={size}>
<Icons.ArrowRight />
</Icon>
)}