Added limit to metrics queries.

This commit is contained in:
Mike Cao 2023-12-12 19:00:44 -08:00
parent a851ebf124
commit 907685b96e
7 changed files with 32 additions and 12 deletions

View File

@ -144,7 +144,6 @@ export default function WebsiteExpandedView({
<DetailsComponent <DetailsComponent
websiteId={websiteId} websiteId={websiteId}
websiteDomain={websiteDomain} websiteDomain={websiteDomain}
limit={false}
animate={false} animate={false}
virtualize={true} virtualize={true}
itemCount={25} itemCount={25}

View File

@ -77,6 +77,7 @@ export function MetricsTable({
type, type,
startAt: +startDate, startAt: +startDate,
endAt: +endDate, endAt: +endDate,
limit,
...filters, ...filters,
}); });

View File

@ -135,7 +135,11 @@ function normalizeFilters(filters = {}) {
}, {}); }, {});
} }
async function parseFilters(websiteId, filters: QueryFilters = {}, options: QueryOptions = {}) { async function parseFilters(
websiteId: string,
filters: QueryFilters = {},
options: QueryOptions = {},
) {
const website = await loadWebsite(websiteId); const website = await loadWebsite(websiteId);
return { return {

View File

@ -206,6 +206,7 @@ export interface QueryFilters {
export interface QueryOptions { export interface QueryOptions {
joinSession?: boolean; joinSession?: boolean;
columns?: { [key: string]: string }; columns?: { [key: string]: string };
limit?: number;
} }
export interface RealtimeData { export interface RealtimeData {

View File

@ -25,6 +25,7 @@ export interface WebsiteMetricsRequestQuery {
city?: string; city?: string;
language?: string; language?: string;
event?: string; event?: string;
limit?: number;
} }
const schema = { const schema = {
@ -45,6 +46,7 @@ const schema = {
city: yup.string(), city: yup.string(),
language: yup.string(), language: yup.string(),
event: yup.string(), event: yup.string(),
limit: yup.number(),
}), }),
}; };
@ -71,6 +73,7 @@ export default async (
city, city,
language, language,
event, event,
limit,
} = req.query; } = req.query;
if (req.method === 'GET') { if (req.method === 'GET') {
@ -100,7 +103,7 @@ export default async (
const column = FILTER_COLUMNS[type] || type; const column = FILTER_COLUMNS[type] || type;
if (SESSION_COLUMNS.includes(type)) { if (SESSION_COLUMNS.includes(type)) {
const data = await getSessionMetrics(websiteId, column, filters); const data = await getSessionMetrics(websiteId, column, filters, limit);
if (type === 'language') { if (type === 'language') {
const combined = {}; const combined = {};
@ -122,7 +125,7 @@ export default async (
} }
if (EVENT_COLUMNS.includes(type)) { if (EVENT_COLUMNS.includes(type)) {
const data = await getPageviewMetrics(websiteId, column, filters); const data = await getPageviewMetrics(websiteId, column, filters, limit);
return ok(res, data); return ok(res, data);
} }

View File

@ -5,7 +5,7 @@ import { EVENT_TYPE, SESSION_COLUMNS } from 'lib/constants';
import { QueryFilters } from 'lib/types'; import { QueryFilters } from 'lib/types';
export async function getPageviewMetrics( export async function getPageviewMetrics(
...args: [websiteId: string, columns: string, filters: QueryFilters] ...args: [websiteId: string, columns: string, filters: QueryFilters, limit?: number]
) { ) {
return runQuery({ return runQuery({
[PRISMA]: () => relationalQuery(...args), [PRISMA]: () => relationalQuery(...args),
@ -13,7 +13,12 @@ export async function getPageviewMetrics(
}); });
} }
async function relationalQuery(websiteId: string, column: string, filters: QueryFilters) { async function relationalQuery(
websiteId: string,
column: string,
filters: QueryFilters,
limit: number = 100,
) {
const { rawQuery, parseFilters } = prisma; const { rawQuery, parseFilters } = prisma;
const { filterQuery, joinSession, params } = await parseFilters( const { filterQuery, joinSession, params } = await parseFilters(
websiteId, websiteId,
@ -42,7 +47,7 @@ async function relationalQuery(websiteId: string, column: string, filters: Query
${filterQuery} ${filterQuery}
group by 1 group by 1
order by 2 desc order by 2 desc
limit 100 limit ${limit}
`, `,
params, params,
); );
@ -52,6 +57,7 @@ async function clickhouseQuery(
websiteId: string, websiteId: string,
column: string, column: string,
filters: QueryFilters, filters: QueryFilters,
limit: number = 100,
): Promise<{ x: string; y: number }[]> { ): Promise<{ x: string; y: number }[]> {
const { rawQuery, parseFilters } = clickhouse; const { rawQuery, parseFilters } = clickhouse;
const { filterQuery, params } = await parseFilters(websiteId, { const { filterQuery, params } = await parseFilters(websiteId, {
@ -75,7 +81,7 @@ async function clickhouseQuery(
${filterQuery} ${filterQuery}
group by x group by x
order by y desc order by y desc
limit 100 limit ${limit}
`, `,
params, params,
).then(a => { ).then(a => {

View File

@ -5,7 +5,7 @@ import { EVENT_TYPE, SESSION_COLUMNS } from 'lib/constants';
import { QueryFilters } from 'lib/types'; import { QueryFilters } from 'lib/types';
export async function getSessionMetrics( export async function getSessionMetrics(
...args: [websiteId: string, column: string, filters: QueryFilters] ...args: [websiteId: string, column: string, filters: QueryFilters, limit?: number]
) { ) {
return runQuery({ return runQuery({
[PRISMA]: () => relationalQuery(...args), [PRISMA]: () => relationalQuery(...args),
@ -13,7 +13,12 @@ export async function getSessionMetrics(
}); });
} }
async function relationalQuery(websiteId: string, column: string, filters: QueryFilters) { async function relationalQuery(
websiteId: string,
column: string,
filters: QueryFilters,
limit: number = 100,
) {
const { parseFilters, rawQuery } = prisma; const { parseFilters, rawQuery } = prisma;
const { filterQuery, joinSession, params } = await parseFilters( const { filterQuery, joinSession, params } = await parseFilters(
websiteId, websiteId,
@ -42,7 +47,7 @@ async function relationalQuery(websiteId: string, column: string, filters: Query
group by 1 group by 1
${includeCountry ? ', 3' : ''} ${includeCountry ? ', 3' : ''}
order by 2 desc order by 2 desc
limit 100`, limit ${limit}`,
params, params,
); );
} }
@ -51,6 +56,7 @@ async function clickhouseQuery(
websiteId: string, websiteId: string,
column: string, column: string,
filters: QueryFilters, filters: QueryFilters,
limit: number = 100,
): Promise<{ x: string; y: number }[]> { ): Promise<{ x: string; y: number }[]> {
const { parseFilters, rawQuery } = clickhouse; const { parseFilters, rawQuery } = clickhouse;
const { filterQuery, params } = await parseFilters(websiteId, { const { filterQuery, params } = await parseFilters(websiteId, {
@ -73,7 +79,7 @@ async function clickhouseQuery(
group by x group by x
${includeCountry ? ', country' : ''} ${includeCountry ? ', country' : ''}
order by y desc order by y desc
limit 100 limit ${limit}
`, `,
params, params,
).then(a => { ).then(a => {