From 28921a7cd5cad000cb5dde100acc7e82162ed1ff Mon Sep 17 00:00:00 2001 From: Mike Cao Date: Tue, 14 Feb 2023 17:23:20 -0800 Subject: [PATCH] Updates to realtime. Fixed refresh button. --- components/common/DateFilter.js | 89 ++++++++++------- components/common/FilterLink.js | 4 +- components/icons.ts | 4 + components/input/RefreshButton.js | 20 +--- components/layout/Grid.js | 13 +++ components/layout/Grid.module.css | 35 +++++++ components/messages.js | 14 ++- components/metrics/ActiveUsers.js | 1 + components/metrics/DatePickerForm.js | 2 +- components/metrics/FilterTags.js | 23 ++++- components/metrics/MetricsTable.js | 4 +- components/metrics/RealtimeHeader.js | 52 ---------- components/metrics/RealtimeHeader.module.css | 11 --- components/metrics/WebsiteChart.js | 46 ++------- components/metrics/WebsiteChart.module.css | 16 ++- .../pages/realtime/RealtimeDashboard.js | 99 ++++++++++--------- .../realtime/RealtimeDashboard.module.css | 9 ++ components/pages/realtime/RealtimeHeader.js | 44 +++++++++ .../pages/realtime/RealtimeHeader.module.css | 9 ++ .../realtime}/RealtimeLog.js | 45 +++++---- .../realtime}/RealtimeLog.module.css | 0 .../realtime}/RealtimeViews.js | 29 +++--- components/pages/websites/WebsiteDetails.js | 4 - components/pages/websites/WebsiteMenuView.js | 24 ++--- .../pages/websites/WebsiteMenuView.module.css | 14 --- components/pages/websites/WebsiteTableView.js | 56 +++++------ hooks/usePageQuery.js | 4 +- pages/api/realtime/init.ts | 3 +- pages/api/realtime/update.ts | 3 +- store/queries.js | 8 +- store/websites.js | 2 +- 31 files changed, 373 insertions(+), 314 deletions(-) create mode 100644 components/layout/Grid.js create mode 100644 components/layout/Grid.module.css delete mode 100644 components/metrics/RealtimeHeader.js delete mode 100644 components/metrics/RealtimeHeader.module.css create mode 100644 components/pages/realtime/RealtimeHeader.js create mode 100644 components/pages/realtime/RealtimeHeader.module.css rename components/{metrics => pages/realtime}/RealtimeLog.js (81%) rename components/{metrics => pages/realtime}/RealtimeLog.module.css (100%) rename components/{metrics => pages/realtime}/RealtimeViews.js (74%) diff --git a/components/common/DateFilter.js b/components/common/DateFilter.js index 77bab32f..a340fe48 100644 --- a/components/common/DateFilter.js +++ b/components/common/DateFilter.js @@ -1,68 +1,74 @@ -import { endOfYear, isSameDay } from 'date-fns'; import { useState } from 'react'; -import { Icon, Modal, Dropdown, Item } from 'react-basics'; -import { useIntl, defineMessages } from 'react-intl'; +import { Icon, Modal, Dropdown, Item, Text, Flexbox } from 'react-basics'; +import { useIntl } from 'react-intl'; +import { endOfYear, isSameDay } from 'date-fns'; import DatePickerForm from 'components/metrics/DatePickerForm'; import useLocale from 'hooks/useLocale'; -import { dateFormat } from 'lib/date'; -import Calendar from 'assets/calendar.svg'; +import { dateFormat, getDateRangeValues } from 'lib/date'; +import Icons from 'components/icons'; +import { labels } from 'components/messages'; +import useApi from 'hooks/useApi'; +import useDateRange from 'hooks/useDateRange'; -const messages = defineMessages({ - today: { id: 'label.today', defaultMessage: 'Today' }, - lastHours: { id: 'label.last-hours', defaultMessage: 'Last {x} hours' }, - yesterday: { id: 'label.yesterday', defaultMessage: 'Yesterday' }, - thisWeek: { id: 'label.this-week', defaultMessage: 'This week' }, - lastDays: { id: 'label.last-days', defaultMessage: 'Last {x} days' }, - thisMonth: { id: 'label.this-month', defaultMessage: 'This month' }, - thisYear: { id: 'label.this-year', defaultMessage: 'This year' }, - allTime: { id: 'label.all-time', defaultMessage: 'All time' }, - customRange: { id: 'label.custom-range', defaultMessage: 'Custom-range' }, -}); - -function DateFilter({ value, startDate, endDate, onChange, className }) { +function DateFilter({ websiteId, value, className }) { const { formatMessage } = useIntl(); + const { get } = useApi(); + const [dateRange, setDateRange] = useDateRange(websiteId); + const { startDate, endDate } = dateRange; const [showPicker, setShowPicker] = useState(false); + async function handleDateChange(value) { + if (value === 'all') { + const data = await get(`/websites/${websiteId}`); + + if (data) { + setDateRange({ value, ...getDateRangeValues(new Date(data.createdAt), Date.now()) }); + } + } else { + setDateRange(value); + } + } + const options = [ - { label: formatMessage(messages.today), value: '1day' }, + { label: formatMessage(labels.today), value: '1day' }, { - label: formatMessage(messages.lastHours, { x: 24 }), + label: formatMessage(labels.lastHours, { x: 24 }), value: '24hour', }, { - label: formatMessage(messages.yesterday), + label: formatMessage(labels.yesterday), value: '-1day', }, { - label: formatMessage(messages.thisWeek), + label: formatMessage(labels.thisWeek), value: '1week', divider: true, }, { - label: formatMessage(messages.lastDays, { x: 7 }), + label: formatMessage(labels.lastDays, { x: 7 }), value: '7day', }, { - label: formatMessage(messages.thisMonth), + label: formatMessage(labels.thisMonth), value: '1month', divider: true, }, { - label: formatMessage(messages.lastDays, { x: 30 }), + label: formatMessage(labels.lastDays, { x: 30 }), value: '30day', }, { - label: formatMessage(messages.lastDays, { x: 90 }), + label: formatMessage(labels.lastDays, { x: 90 }), value: '90day', }, - { label: formatMessage(messages.thisYear), value: '1year' }, + { label: formatMessage(labels.thisYear), value: '1year' }, { - label: formatMessage(messages.allTime), + label: formatMessage(labels.allTime), value: 'all', divider: true, }, { - label: formatMessage(messages.customRange), + label: formatMessage(labels.customRange), value: 'custom', divider: true, }, @@ -76,17 +82,17 @@ function DateFilter({ value, startDate, endDate, onChange, className }) { ); }; - const handleChange = async value => { + const handleChange = value => { if (value === 'custom') { setShowPicker(true); return; } - onChange(value); + handleDateChange(value); }; const handlePickerChange = value => { setShowPicker(false); - onChange(value); + handleDateChange(value); }; const handleClose = () => setShowPicker(false); @@ -98,9 +104,14 @@ function DateFilter({ value, startDate, endDate, onChange, className }) { items={options} renderValue={renderValue} value={value} + alignment="end" onChange={handleChange} > - {({ label, value }) => {label}} + {({ label, value, divider }) => ( + + {label} + + )} {showPicker && ( @@ -128,13 +139,15 @@ const CustomRange = ({ startDate, endDate, onClick }) => { } return ( - <> + - + - {dateFormat(startDate, 'd LLL y', locale)} - {!isSameDay(startDate, endDate) && ` — ${dateFormat(endDate, 'd LLL y', locale)}`} - + + {dateFormat(startDate, 'd LLL y', locale)} + {!isSameDay(startDate, endDate) && ` — ${dateFormat(endDate, 'd LLL y', locale)}`} + + ); }; diff --git a/components/common/FilterLink.js b/components/common/FilterLink.js index f91d4764..eb410719 100644 --- a/components/common/FilterLink.js +++ b/components/common/FilterLink.js @@ -6,13 +6,13 @@ import { Icon, Icons } from 'react-basics'; import styles from './FilterLink.module.css'; export default function FilterLink({ id, value, label, externalUrl }) { - const { resolve, query } = usePageQuery(); + const { resolveUrl, query } = usePageQuery(); const active = query[id] !== undefined; const selected = query[id] === value; return (
- + state[`/websites/${websiteId}/stats`], [websiteId]); - const completed = useStore(selector); function handleClick() { - if (!loading && dateRange) { - setLoading(true); + if (!isLoading && dateRange) { if (/^\d+/.test(dateRange.value)) { setDateRange(websiteId, dateRange.value); } else { @@ -25,17 +19,13 @@ function RefreshButton({ websiteId }) { } } - useEffect(() => { - setLoading(false); - }, [completed]); - return ( - + ); } diff --git a/components/layout/Grid.js b/components/layout/Grid.js new file mode 100644 index 00000000..0276063b --- /dev/null +++ b/components/layout/Grid.js @@ -0,0 +1,13 @@ +import { Row, Column } from 'react-basics'; +import classNames from 'classnames'; +import styles from './Grid.module.css'; + +export function GridRow(props) { + const { className, ...otherProps } = props; + return ; +} + +export function GridColumn(props) { + const { className, ...otherProps } = props; + return ; +} diff --git a/components/layout/Grid.module.css b/components/layout/Grid.module.css new file mode 100644 index 00000000..20df43c9 --- /dev/null +++ b/components/layout/Grid.module.css @@ -0,0 +1,35 @@ +.col { + display: flex; + flex-direction: column; + padding: 20px; +} + +.row { + border-top: 1px solid var(--base300); + min-height: 430px; +} + +.row > .col { + border-left: 1px solid var(--base300); +} + +.row > .col:first-child { + border-left: 0; + padding-left: 0; +} + +.row > .col:last-child { + padding-right: 0; +} + +@media only screen and (max-width: 992px) { + .row { + border: 0; + } + + .row > .col { + border-top: 1px solid var(--base300); + border-left: 0; + padding: 20px 0; + } +} diff --git a/components/messages.js b/components/messages.js index c29432b1..ce506fd1 100644 --- a/components/messages.js +++ b/components/messages.js @@ -81,9 +81,21 @@ export const labels = defineMessages({ visitors: { id: 'label.visitors', defaultMessage: 'Visitors' }, filterCombined: { id: 'label.filter-combined', defaultMessage: 'Combined' }, filterRaw: { id: 'label.filter-raw', defaultMessage: 'Raw' }, - views: { id: 'label.views', defaultMessage: 'View' }, + views: { id: 'label.views', defaultMessage: 'Views' }, none: { id: 'label.none', defaultMessage: 'None' }, clearAll: { id: 'label.clear-all', defaultMessage: 'Clear all' }, + today: { id: 'label.today', defaultMessage: 'Today' }, + lastHours: { id: 'label.last-hours', defaultMessage: 'Last {x} hours' }, + yesterday: { id: 'label.yesterday', defaultMessage: 'Yesterday' }, + thisWeek: { id: 'label.this-week', defaultMessage: 'This week' }, + lastDays: { id: 'label.last-days', defaultMessage: 'Last {x} days' }, + thisMonth: { id: 'label.this-month', defaultMessage: 'This month' }, + thisYear: { id: 'label.this-year', defaultMessage: 'This year' }, + allTime: { id: 'label.all-time', defaultMessage: 'All time' }, + customRange: { id: 'label.custom-range', defaultMessage: 'Custom-range' }, + selectWebsite: { id: 'label.select-website', defaultMessage: 'Select website' }, + all: { id: 'label.all', defaultMessage: 'All' }, + sessions: { id: 'label.sessions', defaultMessage: 'Sessions' }, }); export const messages = defineMessages({ diff --git a/components/metrics/ActiveUsers.js b/components/metrics/ActiveUsers.js index 664e23a9..cb3afe80 100644 --- a/components/metrics/ActiveUsers.js +++ b/components/metrics/ActiveUsers.js @@ -13,6 +13,7 @@ export default function ActiveUsers({ websiteId, value, refetchInterval = 60000 () => get(`/websites/${websiteId}/active`), { refetchInterval, + enabled: !!websiteId, }, ); diff --git a/components/metrics/DatePickerForm.js b/components/metrics/DatePickerForm.js index 17c7b5e5..5235d339 100644 --- a/components/metrics/DatePickerForm.js +++ b/components/metrics/DatePickerForm.js @@ -42,7 +42,7 @@ export default function DatePickerForm({ return (
- + diff --git a/components/metrics/FilterTags.js b/components/metrics/FilterTags.js index 0e68504b..37f5981c 100644 --- a/components/metrics/FilterTags.js +++ b/components/metrics/FilterTags.js @@ -1,26 +1,39 @@ import { useIntl } from 'react-intl'; -import classNames from 'classnames'; import { safeDecodeURI } from 'next-basics'; import { Button, Icon, Icons, Text } from 'react-basics'; import { labels } from 'components/messages'; +import usePageQuery from 'hooks/usePageQuery'; import styles from './FilterTags.module.css'; -export default function FilterTags({ className, params, onClick }) { +export default function FilterTags({ websiteId, params, onClick }) { const { formatMessage } = useIntl(); + const { + router, + resolveUrl, + query: { view }, + } = usePageQuery(); if (Object.keys(params).filter(key => params[key]).length === 0) { return null; } + function handleCloseFilter(param) { + if (param === null) { + router.push(`/websites/${websiteId}/?view=${view}`); + } else { + router.push(resolveUrl({ [param]: undefined })); + } + } + return ( -
+
{Object.keys(params).map(key => { if (!params[key]) { return null; } return (
-
); })} -
} + {filter === FILTER_REFERRERS && ( } - metric={} + title={formatMessage(labels.referrers)} + metric={formatMessage(labels.views)} renderLabel={renderLink} data={referrers} /> )} {filter === FILTER_PAGES && ( } - metric={} + title={formatMessage(labels.pages)} + metric={formatMessage(labels.views)} renderLabel={renderLink} data={pages} /> diff --git a/components/pages/websites/WebsiteDetails.js b/components/pages/websites/WebsiteDetails.js index 903a482a..d5b1c655 100644 --- a/components/pages/websites/WebsiteDetails.js +++ b/components/pages/websites/WebsiteDetails.js @@ -8,13 +8,10 @@ import WebsiteChart from 'components/metrics/WebsiteChart'; import useApi from 'hooks/useApi'; import usePageQuery from 'hooks/usePageQuery'; import { DEFAULT_ANIMATION_DURATION } from 'lib/constants'; -import { labels } from 'components/messages'; -import styles from './WebsiteDetails.module.css'; import WebsiteTableView from './WebsiteTableView'; import WebsiteMenuView from './WebsiteMenuView'; export default function WebsiteDetails({ websiteId }) { - const { formatMessage } = useIntl(); const { get, useQuery } = useApi(); const { data, isLoading, error } = useQuery(['websites', websiteId], () => get(`/websites/${websiteId}`), @@ -22,7 +19,6 @@ export default function WebsiteDetails({ websiteId }) { const [chartLoaded, setChartLoaded] = useState(false); const { - resolve, query: { view }, } = usePageQuery(); diff --git a/components/pages/websites/WebsiteMenuView.js b/components/pages/websites/WebsiteMenuView.js index 07a93268..c8b9db9c 100644 --- a/components/pages/websites/WebsiteMenuView.js +++ b/components/pages/websites/WebsiteMenuView.js @@ -1,7 +1,7 @@ -import { Row, Column, Menu, Item, Icon, Button, Flexbox, Text } from 'react-basics'; +import { Menu, Item, Icon, Button, Flexbox, Text } from 'react-basics'; import { useIntl } from 'react-intl'; import Link from 'next/link'; -import classNames from 'classnames'; +import { GridRow, GridColumn } from 'components/layout/Grid'; import BrowsersTable from 'components/metrics/BrowsersTable'; import CountriesTable from 'components/metrics/CountriesTable'; import DevicesTable from 'components/metrics/DevicesTable'; @@ -33,7 +33,7 @@ const views = { export default function WebsiteMenuView({ websiteId, websiteDomain }) { const { formatMessage } = useIntl(); const { - resolve, + resolveUrl, query: { view }, } = usePageQuery(); @@ -80,12 +80,12 @@ export default function WebsiteMenuView({ websiteId, websiteDomain }) { }, ]; - const DetailsComponent = views[view]; + const DetailsComponent = views[view] || (() => null); return ( - - - + + +