From 0d5b0f223f67d21d24874474d44115ae8f3c7a1a Mon Sep 17 00:00:00 2001 From: Matthias Kretschmann Date: Tue, 22 May 2018 22:41:59 +0200 Subject: [PATCH 1/2] refactor --- README.md | 3 ++- src/components/atoms/Animations.jsx | 10 ++++------ src/templates/Project.jsx | 22 +++++++++++++++++----- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 04668de..cb52bb7 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,8 @@ matthiaskretschmann.com

- + +

diff --git a/src/components/atoms/Animations.jsx b/src/components/atoms/Animations.jsx index beb405b..b36aadf 100644 --- a/src/components/atoms/Animations.jsx +++ b/src/components/atoms/Animations.jsx @@ -2,21 +2,19 @@ import React from 'react' import CSSTransition from 'react-transition-group/CSSTransition' import './Animations.scss' +const Animation = props => + export const FadeIn = props => ( - ) export const MoveIn = props => ( - diff --git a/src/templates/Project.jsx b/src/templates/Project.jsx index 6fd18b3..0aa410a 100644 --- a/src/templates/Project.jsx +++ b/src/templates/Project.jsx @@ -11,6 +11,17 @@ import ProjectNav from '../components/molecules/ProjectNav' import SEO from '../components/atoms/SEO' import './Project.scss' +const ProjectMeta = props => { + const { links, techstack } = props + + return ( +
+ {!!links && } + {!!techstack && } +
+ ) +} + class Project extends Component { constructor(props) { super(props) @@ -27,7 +38,6 @@ class Project extends Component { const project = this.props.data.projectsYaml const projectImages = this.props.data.projectImages.edges const pathContext = this.props.pathContext - const { title, links, techstack } = project const { next, previous } = pathContext @@ -53,10 +63,7 @@ class Project extends Component { ))} -
- {!!links && } - {!!techstack && } -
+ @@ -66,6 +73,11 @@ class Project extends Component { } } +ProjectMeta.propTypes = { + links: PropTypes.array, + techstack: PropTypes.array +} + Project.propTypes = { data: PropTypes.object.isRequired, pathContext: PropTypes.object.isRequired From 6dcf3ce2fec7b8939edd265bcbda780cf24e716c Mon Sep 17 00:00:00 2001 From: Matthias Kretschmann Date: Tue, 22 May 2018 22:51:41 +0200 Subject: [PATCH 2/2] lint fixes --- src/lib/vcf/vcard.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/vcf/vcard.js b/src/lib/vcf/vcard.js index d1838ed..8eadb08 100644 --- a/src/lib/vcf/vcard.js +++ b/src/lib/vcf/vcard.js @@ -278,7 +278,6 @@ vCard.prototype = { * @return {String} */ toString: function(version, charset) { - // eslint-disable-line no-unused-vars version = version || this.version return vCard.format(this, version) },