mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-27 21:00:13 +01:00
5363d6aa2a
* Prevent multiple warnings for the same locale message
Our i18n helper issues warnings whenever a requested message is
missing. These warnings are helpful in assisting translation efforts,
but they can be distracting otherwise. They're especially problematic
for locales that are missing many messages. My browser ended up
crashing on more than one occasion due to the sheer volume of warnings.
The warning has been updated to only be issued once per missing key.
This required updating the method to pass in the current locale. The
current locale was added to the warning itself as well, which could be
helpful for cases where a message is missing in both the current locale
and the fallback ('en').
* Change locale and localeMessages as single action
Updating the current locale and the locale messages resulted in two
renders, and during the first the state was inconsistent (it would say
the locale had changed to the new one, but still be using the old set
of locale messages). Instead the locale is now updated with one atomic
action.
This was required after adding the locale to the missing locale message
warning, as otherwise it would say the message was missing from the
wrong locale.
18 lines
425 B
JavaScript
18 lines
425 B
JavaScript
const extend = require('xtend')
|
|
const actions = require('../../store/actions')
|
|
|
|
module.exports = reduceMetamask
|
|
|
|
function reduceMetamask (state, action) {
|
|
const localeMessagesState = extend({}, state.localeMessages)
|
|
|
|
switch (action.type) {
|
|
case actions.SET_CURRENT_LOCALE:
|
|
return extend(localeMessagesState, {
|
|
current: action.value.messages,
|
|
})
|
|
default:
|
|
return localeMessagesState
|
|
}
|
|
}
|