mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
5ee1291662
Previously all browser globals were allowed to be used anywhere by ESLint because we had set the `env` property to `browser` in the ESLint config. This has made it easy to accidentally use browser globals (e.g. #8338), so it has been removed. Instead we now have a short list of allowed globals. All browser globals are now accessed as properties on `window`. Unfortunately this change resulted in a few different confusing unit test errors, as some of our unit tests setup assumed that a particular global would be used via `window` or `global`. In particular, `window.fetch` didn't work correctly because it wasn't patched by the AbortController polyfill (only `global.fetch` was being patched). The `jsdom-global` package we were using complicated matters by setting all of the JSDOM `window` properties directly on `global`, overwriting the `AbortController` for example. The `helpers.js` test setup module has been simplified somewhat by removing `jsdom-global` and constructing the JSDOM instance manually. The JSDOM window is set on `window`, and a few properties are set on `global` as well as needed by various dependencies. `node-fetch` and the AbortController polyfill/patch now work as expected as well, though `fetch` is only available on `window` now.
39 lines
973 B
JavaScript
39 lines
973 B
JavaScript
export default setupFetchDebugging
|
|
|
|
//
|
|
// This is a utility to help resolve cases where `window.fetch` throws a
|
|
// `TypeError: Failed to Fetch` without any stack or context for the request
|
|
// https://github.com/getsentry/sentry-javascript/pull/1293
|
|
//
|
|
|
|
function setupFetchDebugging () {
|
|
if (!window.fetch) {
|
|
return
|
|
}
|
|
const originalFetch = window.fetch
|
|
|
|
window.fetch = wrappedFetch
|
|
|
|
async function wrappedFetch (...args) {
|
|
const initialStack = getCurrentStack()
|
|
try {
|
|
return await originalFetch.call(window, ...args)
|
|
} catch (err) {
|
|
if (!err.stack) {
|
|
console.warn('FetchDebugger - fetch encountered an Error without a stack', err)
|
|
console.warn('FetchDebugger - overriding stack to point of original call')
|
|
err.stack = initialStack
|
|
}
|
|
throw err
|
|
}
|
|
}
|
|
}
|
|
|
|
function getCurrentStack () {
|
|
try {
|
|
throw new Error('Fake error for generating stack trace')
|
|
} catch (err) {
|
|
return err.stack
|
|
}
|
|
}
|