mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-30 16:18:07 +01:00
3e9d247d4b
The `fetch-with-cache` utility was failing to actually cache anything. It would cache an object with cache time and URL, and would return that instead of a valid response. This resulted in the error: `TypeError: fourByteResponse.json is not a function` The utility was updated to call `.json()` within itself, and cache the JSON response. The function signature was updated as well, to expect an options object instead of just the `cacheRefreshTime` option. The timeout was added to this options object, which helped with testing. The utility method now also handles unsuccessfull responses, and incompatible `fetch` options.
134 lines
3.7 KiB
JavaScript
134 lines
3.7 KiB
JavaScript
import assert from 'assert'
|
|
import nock from 'nock'
|
|
import sinon from 'sinon'
|
|
import proxyquire from 'proxyquire'
|
|
|
|
const fakeLocalStorageHelpers = {}
|
|
const fetchWithCache = proxyquire('./fetch-with-cache', {
|
|
'../../../lib/local-storage-helpers': fakeLocalStorageHelpers,
|
|
}).default
|
|
|
|
describe('Fetch with cache', () => {
|
|
beforeEach(() => {
|
|
fakeLocalStorageHelpers.loadLocalStorageData = sinon.stub()
|
|
fakeLocalStorageHelpers.saveLocalStorageData = sinon.stub()
|
|
})
|
|
afterEach(() => {
|
|
sinon.restore()
|
|
nock.cleanAll()
|
|
})
|
|
|
|
it('fetches a url', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(200, '{"average": 1}')
|
|
|
|
const response = await fetchWithCache('https://fetchwithcache.metamask.io/price')
|
|
assert.deepEqual(response, {
|
|
average: 1,
|
|
})
|
|
})
|
|
|
|
it('returns cached response', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(200, '{"average": 2}')
|
|
|
|
fakeLocalStorageHelpers.loadLocalStorageData.returns({
|
|
'https://fetchwithcache.metamask.io/price': {
|
|
cachedResponse: { average: 1 },
|
|
cachedTime: Date.now(),
|
|
},
|
|
})
|
|
|
|
const response = await fetchWithCache('https://fetchwithcache.metamask.io/price')
|
|
assert.deepEqual(response, {
|
|
average: 1,
|
|
})
|
|
})
|
|
|
|
it('fetches URL again after cache refresh time has passed', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(200, '{"average": 3}')
|
|
|
|
fakeLocalStorageHelpers.loadLocalStorageData.returns({
|
|
'https://fetchwithcache.metamask.io/cached': {
|
|
cachedResponse: { average: 1 },
|
|
cachedTime: Date.now() - 1000,
|
|
},
|
|
})
|
|
|
|
const response = await fetchWithCache('https://fetchwithcache.metamask.io/price', {}, { cacheRefreshTime: 123 })
|
|
assert.deepEqual(response, {
|
|
average: 3,
|
|
})
|
|
})
|
|
|
|
it('should abort the request when the custom timeout is hit', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.delay(100)
|
|
.reply(200, '{"average": 4}')
|
|
|
|
try {
|
|
await fetchWithCache('https://fetchwithcache.metamask.io/price', {}, { timeout: 20 })
|
|
assert.fail('Request should be aborted')
|
|
} catch (e) {
|
|
assert.deepEqual(e.message, 'Aborted')
|
|
}
|
|
})
|
|
|
|
it('throws when the response is unsuccessful', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(500, '{"average": 6}')
|
|
|
|
try {
|
|
await fetchWithCache('https://fetchwithcache.metamask.io/price')
|
|
assert.fail('Request should throw')
|
|
} catch (e) {
|
|
assert.ok(e)
|
|
}
|
|
})
|
|
|
|
it('throws when a POST request is attempted', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.post('/price')
|
|
.reply(200, '{"average": 7}')
|
|
|
|
try {
|
|
await fetchWithCache('https://fetchwithcache.metamask.io/price', { method: 'POST' })
|
|
assert.fail('Request should throw')
|
|
} catch (e) {
|
|
assert.ok(e)
|
|
}
|
|
})
|
|
|
|
it('throws when the request has a truthy body', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(200, '{"average": 8}')
|
|
|
|
try {
|
|
await fetch('https://fetchwithcache.metamask.io/price', { body: 1 })
|
|
assert.fail('Request should throw')
|
|
} catch (e) {
|
|
assert.ok(e)
|
|
}
|
|
})
|
|
|
|
it('throws when the request has an invalid Content-Type header', async () => {
|
|
nock('https://fetchwithcache.metamask.io')
|
|
.get('/price')
|
|
.reply(200, '{"average": 9}')
|
|
|
|
try {
|
|
await fetch('https://fetchwithcache.metamask.io/price', { headers: { 'Content-Type': 'text/plain' } })
|
|
assert.fail('Request should throw')
|
|
} catch (e) {
|
|
assert.ok(e)
|
|
}
|
|
})
|
|
})
|