1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts/lib
Mark Stacey 95f198550e
Declare variables before use (#6806)
While working on #6805, I noticed that many variables were being used
before they were declared. Technically this worked fine in practice
because we were using the `transform-es2015-block-scoping` Babel plugin,
which transforms `let` and `const` to `var`, which is hoisted. However,
after removing that Babel transformation, many things broke.

All instances of variables or classes being used before declared have
been fixed.

The `no-use-before-define` eslint rule has been added to catch these
cases going forward. The rule is disabled for function declarations for
the moment, because those are always hoisted. We could disable that too
if we want to, but it's purely stylistic and would require a lot more
changes.
2019-07-05 14:01:34 -03:00
..
ens-ipfs refactor & change html pages 2019-05-04 18:57:19 +02:00
migrator Add a few missing docblocks to background files 2018-04-18 18:00:22 -02:30
account-tracker.js account tracker - update accounts from balanceChecker contract (#6181) 2019-02-20 09:12:12 -10:00
auto-reload.js Stop reloading dapps on network change allowing dapps to decide if it should refresh or not (#6330) 2019-03-21 12:42:23 -07:00
backend-metametrics.js Send metrics event from backend for on chain transaction failures (#6500) 2019-04-29 03:48:40 -02:30
buy-eth-url.js feature: add Goerli support (#6459) 2019-04-17 15:04:49 -02:30
cleanErrorStack.js eslint --fix . 2018-07-02 18:49:33 -04:00
ComposableObservableStore.js GABA: Integrate AddressBookController (#5847) 2019-03-11 18:40:41 -10:00
createDnodeRemoteGetter.js Refactor ProviderApprovalController to use rpc and publicConfigStore (#6410) 2019-05-03 13:32:05 -04:00
createLoggerMiddleware.js Add a few missing docblocks to background files 2018-04-18 18:00:22 -02:30
createOriginMiddleware.js Add a few missing docblocks to background files 2018-04-18 18:00:22 -02:30
createStreamSink.js Declare variables before use (#6806) 2019-07-05 14:01:34 -03:00
diagnostics-reporter.js eslint --fix . 2018-07-02 18:49:33 -04:00
enums.js code review changes 2018-08-08 03:00:39 -04:00
extractEthjsErrorMessage.js eslint --fix . 2018-07-02 18:49:33 -04:00
get-first-preferred-lang-code.js Fix locale codes contains underscore will never be preferred (#6116) 2019-02-08 16:06:37 -03:30
getObjStructure.js eslint --fix . 2018-07-02 18:49:33 -04:00
hex-to-bn.js Add a few missing docblocks to background files 2018-04-18 18:00:22 -02:30
local-store.js eslint --fix . 2018-07-02 18:49:33 -04:00
message-manager.js Check for unused function arguments (#6583) 2019-05-08 15:51:33 -04:00
nodeify.js lib - nodeify - correctly wrap synchronous functions 2019-03-29 12:37:40 +08:00
notification-manager.js Fixes popups not showing when screen size is odd (#6312) 2019-03-17 18:30:51 -02:30
pending-balance-calculator.js Even more documentation for various controllers and libs. 2018-04-19 13:08:56 -02:30
personal-message-manager.js Check for unused function arguments (#6583) 2019-05-08 15:51:33 -04:00
random-id.js Maintain linting. 2016-11-18 16:27:26 -08:00
reportFailedTxToSentry.js sentry - replace raven-js with sentry/browser 2018-10-20 02:22:50 -04:00
seed-phrase-verifier.js Merge branch 'master' into dm-docs-2 2018-04-20 13:23:17 -02:30
setupFetchDebugging.js ESLint fixes (#5775) 2018-11-16 14:54:55 -10:00
setupMetamaskMeshMetrics.js eslint --fix . 2018-07-02 18:49:33 -04:00
setupSentry.js ESLint fixes (#5775) 2018-11-16 14:54:55 -10:00
stream-utils.js Add a few missing docblocks to background files 2018-04-18 18:00:22 -02:30
typed-message-manager.js Update new method namespace from v2 to v3 2018-09-13 15:42:27 -04:00
util.js Merge branch 'develop' into network-remove-provider-engine 2018-08-14 10:44:42 -07:00