mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-25 03:20:23 +01:00
95f198550e
While working on #6805, I noticed that many variables were being used before they were declared. Technically this worked fine in practice because we were using the `transform-es2015-block-scoping` Babel plugin, which transforms `let` and `const` to `var`, which is hoisted. However, after removing that Babel transformation, many things broke. All instances of variables or classes being used before declared have been fixed. The `no-use-before-define` eslint rule has been added to catch these cases going forward. The rule is disabled for function declarations for the moment, because those are always hoisted. We could disable that too if we want to, but it's purely stylistic and would require a lot more changes.
168 lines
4.9 KiB
Plaintext
168 lines
4.9 KiB
Plaintext
{
|
|
"parser": "babel-eslint",
|
|
"parserOptions": {
|
|
"sourceType": "module",
|
|
"ecmaVersion": 2017,
|
|
"ecmaFeatures": {
|
|
"experimentalObjectRestSpread": true,
|
|
"impliedStrict": true,
|
|
"modules": true,
|
|
"blockBindings": true,
|
|
"arrowFunctions": true,
|
|
"objectLiteralShorthandMethods": true,
|
|
"objectLiteralShorthandProperties": true,
|
|
"templateStrings": true,
|
|
"classes": true,
|
|
"jsx": true
|
|
},
|
|
},
|
|
|
|
"extends": ["plugin:react/recommended"],
|
|
|
|
"env": {
|
|
"es6": true,
|
|
"node": true,
|
|
"browser": true,
|
|
"mocha" : true
|
|
},
|
|
|
|
"plugins": [
|
|
"mocha",
|
|
"chai",
|
|
"react",
|
|
"json"
|
|
],
|
|
|
|
"globals": {
|
|
"document": false,
|
|
"navigator": false,
|
|
"web3": true,
|
|
"window": false,
|
|
"$": false,
|
|
"QUnit": false
|
|
},
|
|
|
|
"rules": {
|
|
"no-restricted-globals": ["error", "event"],
|
|
"accessor-pairs": 2,
|
|
"arrow-spacing": [2, { "before": true, "after": true }],
|
|
"block-spacing": [2, "always"],
|
|
"brace-style": [2, "1tbs", { "allowSingleLine": true }],
|
|
"camelcase": [2, { "properties": "never" }],
|
|
"comma-dangle": [2, "always-multiline"],
|
|
"comma-spacing": [2, { "before": false, "after": true }],
|
|
"comma-style": [2, "last"],
|
|
"constructor-super": 2,
|
|
"curly": [2, "multi-line"],
|
|
"dot-location": [2, "property"],
|
|
"eol-last": 2,
|
|
"eqeqeq": [2, "allow-null"],
|
|
"generator-star-spacing": [2, { "before": true, "after": true }],
|
|
"handle-callback-err": [2, "^(err|error)$" ],
|
|
"indent": "off",
|
|
"jsx-quotes": [2, "prefer-double"],
|
|
"key-spacing": 2,
|
|
"keyword-spacing": [2, { "before": true, "after": true }],
|
|
"new-cap": [2, { "newIsCap": true, "capIsNew": false }],
|
|
"new-parens": 2,
|
|
"no-array-constructor": 2,
|
|
"no-caller": 2,
|
|
"no-class-assign": 2,
|
|
"no-cond-assign": 2,
|
|
"no-const-assign": 2,
|
|
"no-control-regex": 2,
|
|
"no-debugger": 2,
|
|
"no-delete-var": 2,
|
|
"no-dupe-args": 2,
|
|
"no-dupe-class-members": 2,
|
|
"no-dupe-keys": 2,
|
|
"no-duplicate-case": 2,
|
|
"no-duplicate-imports": 2,
|
|
"no-empty-character-class": 2,
|
|
"no-empty-pattern": 2,
|
|
"no-eval": 2,
|
|
"no-ex-assign": 2,
|
|
"no-extend-native": 2,
|
|
"no-extra-bind": 2,
|
|
"no-extra-boolean-cast": 2,
|
|
"no-extra-parens": [2, "functions"],
|
|
"no-fallthrough": 2,
|
|
"no-floating-decimal": 2,
|
|
"no-func-assign": 2,
|
|
"no-implied-eval": 2,
|
|
"no-inner-declarations": [2, "functions"],
|
|
"no-invalid-regexp": 2,
|
|
"no-irregular-whitespace": 2,
|
|
"no-iterator": 2,
|
|
"no-label-var": 2,
|
|
"no-labels": [2, { "allowLoop": false, "allowSwitch": false }],
|
|
"no-lone-blocks": 2,
|
|
"no-mixed-spaces-and-tabs": 2,
|
|
"no-multi-spaces": 2,
|
|
"no-multi-str": 2,
|
|
"no-multiple-empty-lines": [2, { "max": 2 }],
|
|
"no-native-reassign": 2,
|
|
"no-negated-in-lhs": 2,
|
|
"no-new": 2,
|
|
"no-new-func": 2,
|
|
"no-new-object": 2,
|
|
"no-new-require": 2,
|
|
"no-new-symbol": 2,
|
|
"no-new-wrappers": 2,
|
|
"no-obj-calls": 2,
|
|
"no-octal": 2,
|
|
"no-octal-escape": 2,
|
|
"no-path-concat": 2,
|
|
"no-proto": 2,
|
|
"no-redeclare": 2,
|
|
"no-regex-spaces": 2,
|
|
"no-return-assign": [2, "except-parens"],
|
|
"no-self-assign": 2,
|
|
"no-self-compare": 2,
|
|
"no-sequences": 2,
|
|
"no-shadow-restricted-names": 2,
|
|
"no-spaced-func": 2,
|
|
"no-sparse-arrays": 2,
|
|
"no-this-before-super": 2,
|
|
"no-throw-literal": 2,
|
|
"no-trailing-spaces": 2,
|
|
"no-undef": 2,
|
|
"no-undef-init": 2,
|
|
"no-unexpected-multiline": 2,
|
|
"no-unmodified-loop-condition": 2,
|
|
"no-unneeded-ternary": [2, { "defaultAssignment": false }],
|
|
"no-unreachable": 2,
|
|
"no-unsafe-finally": 2,
|
|
"no-unused-vars": [2, { "vars": "all", "args": "all", "argsIgnorePattern": "[_]+" }],
|
|
"no-use-before-define": [2, { "functions": false }],
|
|
"no-useless-call": 2,
|
|
"no-useless-computed-key": 2,
|
|
"no-useless-constructor": 2,
|
|
"no-useless-escape": 2,
|
|
"no-whitespace-before-property": 2,
|
|
"no-with": 2,
|
|
"one-var": [2, { "initialized": "never" }],
|
|
"operator-linebreak": [2, "after", { "overrides": { "?": "ignore", ":": "ignore" } }],
|
|
"padded-blocks": "off",
|
|
"quotes": [2, "single", {"avoidEscape": true, "allowTemplateLiterals": true}],
|
|
"react/no-deprecated": 0,
|
|
"semi": [2, "never"],
|
|
"semi-spacing": [2, { "before": false, "after": true }],
|
|
"space-before-blocks": [2, "always"],
|
|
"space-before-function-paren": [2, "always"],
|
|
"space-in-parens": [2, "never"],
|
|
"space-infix-ops": 2,
|
|
"space-unary-ops": [2, { "words": true, "nonwords": false }],
|
|
"spaced-comment": [2, "always", { "markers": ["global", "globals", "eslint", "eslint-disable", "*package", "!", ","], "exceptions": ["=", "-"] } ],
|
|
"strict": 0,
|
|
"template-curly-spacing": [2, "never"],
|
|
"use-isnan": 2,
|
|
"valid-typeof": 2,
|
|
"wrap-iife": [2, "any"],
|
|
"yield-star-spacing": [2, "both"],
|
|
"yoda": [2, "never"],
|
|
"prefer-const": 2,
|
|
"mocha/no-exclusive-tests": "error"
|
|
}
|
|
}
|