1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
metamask-extension/app
Dan J Miller efaaf4fab2
Use tokenList to get token details, when available, in getTokenStanda… (#17891)
* Use tokenList to get token details, when available, in getTokenStandardAndDetails

Previously, every call to getTokenStandardAndDetails would fetch data via the provider.
This would result in at least 3 network requests whenever that method is called for an
ERC20 token, contributing to unneccesary loading and lagging in multiple places.
This commit takes advantage of stored data we already have available to avoid the unnecessary
loading.

* Lint fix

* Fix build-quote test

* bump coverage targets

* Pass provider to token-util, for use in ethers Contract module

* Check all possible sources of ERC20 token data before async call to assetsContractController

* Add and update tests

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Remove unnecessary this.ethQuery changes

* Use metamask-eth-abis instead of human-standard-token-abi in token-util.ts

* Add explanatory comments to getTokenStandardAndDetails

* lint fix

* Cleanup

* fix test

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* update error message

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2023-03-08 14:05:45 -03:30
..
_locales delay chain validation (#17413) 2023-03-08 16:33:27 +00:00
build-types [MMI] Adds mmi build type + manifest files and images (#17842) 2023-03-01 09:38:15 +00:00
fonts
images Bridge tokens by redirecting to Portfolio from wallet overview page (#17952) 2023-03-06 11:34:06 -08:00
manifest Update minimum browser versions (#12847) 2023-02-24 11:39:56 -03:30
scripts Use tokenList to get token details, when available, in getTokenStanda… (#17891) 2023-03-08 14:05:45 -03:30
vendor/trezor
background.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
home.html [MMI] Conditional change title in home if buildType is MMI (#17898) 2023-03-02 10:18:46 -06:00
loading.html
notification.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
popup.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
trezor-usb-permissions.html