mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
8ffebb294b
There are a few issues encountered when running `yarn setup` on new
Apple Silicon (aka M1, aka arm64) Macs:
* The script halts when attempting to run the install step for
the `chromedriver` package with the message "Only Mac 64 bits
supported". This is somewhat misleading as it seems to indicate that
chromedriver can only be installed on a 64-bit Mac. However, what I
think is happening is that the installation script for `chromedriver`
is not able to detect that an arm64 CPU *is* a 64-bit CPU. After
looking through the `chromedriver` repo, it appears that 87.0.1 is the
first version that adds a proper check ([1]).
Note that upgrading chromedriver caused the Chrome-specific tests to
fail intermittently on CI. I was not able to 100% work out the reason
for this, but ensuring that X (which provides a way for Chrome to run
in a GUI setting from the command line) is available seems to fix
these issues.
* The script also halts when attempting to run the install step for
the `electron` package. This happens because for the version of
`electron` we are using (9.4.2), there is no available binary for
arm64. It appears that Electron 11.x was the first version to support
arm64 Macs ([2]). This is a bit trickier to resolve because we don't
explicitly rely on `electron` — that's brought in by `react-devtools`.
The first version of `react-devtools` that relies on `electron` 11.x
is 4.11.0 ([3]).
[1]: 469dd0a6ee
[2]: https://www.electronjs.org/blog/apple-silicon
[3]: https://github.com/facebook/react/blob/main/packages/react-devtools/CHANGELOG.md#4110-april-9-2021
201 lines
6.1 KiB
JavaScript
201 lines
6.1 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
const path = require('path');
|
|
const { promises: fs, constants: fsConstants } = require('fs');
|
|
const yargs = require('yargs/yargs');
|
|
const { hideBin } = require('yargs/helpers');
|
|
const ttest = require('ttest');
|
|
const { retry } = require('../../development/lib/retry');
|
|
const { exitWithError } = require('../../development/lib/exit-with-error');
|
|
const { withFixtures, tinyDelayMs } = require('./helpers');
|
|
const { PAGES } = require('./webdriver/driver');
|
|
|
|
const DEFAULT_NUM_SAMPLES = 20;
|
|
const ALL_PAGES = Object.values(PAGES);
|
|
|
|
async function measurePage(pageName) {
|
|
let metrics;
|
|
await withFixtures({ fixtures: 'imported-account' }, async ({ driver }) => {
|
|
await driver.delay(tinyDelayMs);
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
await driver.findElement('.selected-account__name');
|
|
await driver.navigate(pageName);
|
|
await driver.delay(1000);
|
|
metrics = await driver.collectMetrics();
|
|
});
|
|
return metrics;
|
|
}
|
|
|
|
function calculateResult(calc) {
|
|
return (result) => {
|
|
const calculatedResult = {};
|
|
for (const key of Object.keys(result)) {
|
|
calculatedResult[key] = calc(result[key]);
|
|
}
|
|
return calculatedResult;
|
|
};
|
|
}
|
|
const calculateSum = (array) => array.reduce((sum, val) => sum + val);
|
|
const calculateAverage = (array) => calculateSum(array) / array.length;
|
|
const minResult = calculateResult((array) => Math.min(...array));
|
|
const maxResult = calculateResult((array) => Math.max(...array));
|
|
const averageResult = calculateResult((array) => calculateAverage(array));
|
|
const standardDeviationResult = calculateResult((array) => {
|
|
if (array.length === 1) {
|
|
return 0;
|
|
}
|
|
const average = calculateAverage(array);
|
|
const squareDiffs = array.map((value) => Math.pow(value - average, 2));
|
|
return Math.sqrt(calculateAverage(squareDiffs));
|
|
});
|
|
// 95% margin of error calculated using Student's t-distribution
|
|
const calculateMarginOfError = (array) =>
|
|
ttest(array).confidence()[1] - calculateAverage(array);
|
|
const marginOfErrorResult = calculateResult((array) =>
|
|
array.length === 1 ? 0 : calculateMarginOfError(array),
|
|
);
|
|
|
|
async function profilePageLoad(pages, numSamples, retries) {
|
|
const results = {};
|
|
for (const pageName of pages) {
|
|
const runResults = [];
|
|
for (let i = 0; i < numSamples; i += 1) {
|
|
let result;
|
|
await retry({ retries }, async () => {
|
|
result = await measurePage(pageName);
|
|
});
|
|
runResults.push(result);
|
|
}
|
|
|
|
if (runResults.some((result) => result.navigation.lenth > 1)) {
|
|
throw new Error(`Multiple navigations not supported`);
|
|
} else if (
|
|
runResults.some((result) => result.navigation[0].type !== 'navigate')
|
|
) {
|
|
throw new Error(
|
|
`Navigation type ${
|
|
runResults.find((result) => result.navigation[0].type !== 'navigate')
|
|
.navigation[0].type
|
|
} not supported`,
|
|
);
|
|
}
|
|
|
|
const result = {
|
|
firstPaint: runResults.map((metrics) => metrics.paint['first-paint']),
|
|
domContentLoaded: runResults.map(
|
|
(metrics) =>
|
|
metrics.navigation[0] && metrics.navigation[0].domContentLoaded,
|
|
),
|
|
load: runResults.map(
|
|
(metrics) => metrics.navigation[0] && metrics.navigation[0].load,
|
|
),
|
|
domInteractive: runResults.map(
|
|
(metrics) =>
|
|
metrics.navigation[0] && metrics.navigation[0].domInteractive,
|
|
),
|
|
};
|
|
|
|
results[pageName] = {
|
|
min: minResult(result),
|
|
max: maxResult(result),
|
|
average: averageResult(result),
|
|
standardDeviation: standardDeviationResult(result),
|
|
marginOfError: marginOfErrorResult(result),
|
|
};
|
|
}
|
|
return results;
|
|
}
|
|
|
|
async function isWritable(directory) {
|
|
try {
|
|
await fs.access(directory, fsConstants.W_OK);
|
|
return true;
|
|
} catch (error) {
|
|
if (error.code !== 'EACCES') {
|
|
throw error;
|
|
}
|
|
return false;
|
|
}
|
|
}
|
|
|
|
async function getFirstParentDirectoryThatExists(directory) {
|
|
let nextDirectory = directory;
|
|
for (;;) {
|
|
try {
|
|
await fs.access(nextDirectory, fsConstants.F_OK);
|
|
return nextDirectory;
|
|
} catch (error) {
|
|
if (error.code !== 'ENOENT') {
|
|
throw error;
|
|
} else if (nextDirectory === path.dirname(nextDirectory)) {
|
|
throw new Error('Failed to find parent directory that exists');
|
|
}
|
|
nextDirectory = path.dirname(nextDirectory);
|
|
}
|
|
}
|
|
}
|
|
|
|
async function main() {
|
|
const { argv } = yargs(hideBin(process.argv)).usage(
|
|
'$0 [options]',
|
|
'Run a page load benchmark',
|
|
(_yargs) =>
|
|
_yargs
|
|
.option('pages', {
|
|
array: true,
|
|
default: ['home'],
|
|
description:
|
|
'Set the page(s) to be benchmarked. This flag can accept multiple values (space-separated).',
|
|
choices: ALL_PAGES,
|
|
})
|
|
.option('samples', {
|
|
default: DEFAULT_NUM_SAMPLES,
|
|
description: 'The number of times the benchmark should be run.',
|
|
type: 'number',
|
|
})
|
|
.option('out', {
|
|
description:
|
|
'Output filename. Output printed to STDOUT of this is omitted.',
|
|
type: 'string',
|
|
normalize: true,
|
|
})
|
|
.option('retries', {
|
|
default: 0,
|
|
description:
|
|
'Set how many times each benchmark sample should be retried upon failure.',
|
|
type: 'number',
|
|
}),
|
|
);
|
|
|
|
const { pages, samples, out, retries } = argv;
|
|
|
|
let outputDirectory;
|
|
let existingParentDirectory;
|
|
if (out) {
|
|
outputDirectory = path.dirname(out);
|
|
existingParentDirectory = await getFirstParentDirectoryThatExists(
|
|
outputDirectory,
|
|
);
|
|
if (!(await isWritable(existingParentDirectory))) {
|
|
throw new Error('Specified output file directory is not writable');
|
|
}
|
|
}
|
|
|
|
const results = await profilePageLoad(pages, samples, retries);
|
|
|
|
if (out) {
|
|
if (outputDirectory !== existingParentDirectory) {
|
|
await fs.mkdir(outputDirectory, { recursive: true });
|
|
}
|
|
await fs.writeFile(out, JSON.stringify(results, null, 2));
|
|
} else {
|
|
console.log(JSON.stringify(results, null, 2));
|
|
}
|
|
}
|
|
|
|
main().catch((error) => {
|
|
exitWithError(error);
|
|
});
|