1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-27 04:46:10 +01:00
metamask-extension/app/scripts
Mark Stacey e720843517
Fix popup not opening (#8314)
MetaMask would sometimes get into a state where the notification popup
would never open. This could happen if the notification window was
closed shortly after being opened. After this happened, no popups would
show up until after the extension was reset.

This was happening because the background thought the popup was already
open. The variable it uses to track whether the popup was open or not
was being set to `true` immediately after the background asked the
browser to open a new window, before a handler was attached that could
respond to the window being closed.

Removing this line seems to solve the problem.

This line was added originally in #5437, which dealt with batch
transactions. Batches of transactions seem to work just fine without
this line though (from local testing), and I can't think of why this
would be required.

Closes #7051
2020-04-09 20:43:32 -03:00
..
account-import-strategies Clean up "JSON File" import strategy test output (#7855) 2020-01-17 19:59:47 -03:30
controllers Connect flow via popup (#8269) 2020-04-07 16:08:15 -02:30
lib Fix Sentry error processing for errors missing a stack (#8179) 2020-03-12 10:51:05 -03:00
migrations Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
platforms Use @metamask/etherscan-link@1.1.0 (#8294) 2020-04-06 13:38:44 -02:30
background.js Fix popup not opening (#8314) 2020-04-09 20:43:32 -03:00
chromereload.js Fix console.error references 2016-08-29 17:32:39 -07:00
contentscript.js Merge pull request #8056 from whymarrh/arrow-parens 2020-02-17 15:26:43 -07:00
first-time-state.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
inpage.js update inpage-provider; minor fixes (#7997) 2020-02-06 07:57:54 -08:00
metamask-controller.js Connect flow via popup (#8269) 2020-04-07 16:08:15 -02:30
phishing-detect.js Replace METAMASK_UI_TYPE global with helper function (#8279) 2020-04-01 19:28:10 -03:00
README.md add READMEs to folders, re #3427 2018-03-14 15:33:22 +02:00
ui.js Replace METAMASK_UI_TYPE global with helper function (#8279) 2020-04-01 19:28:10 -03:00

Main MetaMask Code

This folder contains the core-code.

Currently, it is organized mostly based on file category, like:

controllers, migrations, lib

Ongoing Task

Refactor code-structure, thus the subsystems are reflected on the filesystem.

Examples