1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/pages
Mark Stacey 22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
..
add-collectible Feat/collectibles the return (#12970) 2021-12-13 17:41:10 -06:00
asset Feat/collectibles the return (#12970) 2021-12-13 17:41:10 -06:00
confirm-add-suggested-token Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
confirm-approve Using EIP-1559 V2 for swaps (#12966) 2021-12-12 04:56:28 +05:30
confirm-decrypt-message Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
confirm-deploy-contract Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
confirm-encryption-public-key Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
confirm-import-token Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
confirm-send-ether Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
confirm-send-token Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
confirm-token-transaction-base Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
confirm-transaction Hardening property check for stopPropagation in ConfirmTxScreen (#12158) 2021-09-21 11:58:39 -07:00
confirm-transaction-base Using EIP-1559 V2 for swaps (#12966) 2021-12-12 04:56:28 +05:30
confirm-transaction-switch Replace hardcoded sent ether label on confirm screen (#11802) 2021-09-15 16:54:51 -05:00
confirmation Allow templates without alerts (#13150) 2022-01-03 11:32:15 -03:30
connected-accounts Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
connected-sites Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
create-account Fix account name duplicates (#12867) 2021-12-16 07:11:55 -03:30
error remove the ui/app and ui/lib folders (#10911) 2021-04-28 14:53:59 -05:00
first-time-flow Update ESLint config to v8 (#12886) 2021-12-09 15:36:24 -03:30
home Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
import-token Fix isMainnet propType error (#12951) 2021-12-02 14:46:46 -03:30
keychains Make restore vault a form so an user can submit via keyboard (#12989) 2021-12-10 14:32:13 -05:00
lock remove the ui/app and ui/lib folders (#10911) 2021-04-28 14:53:59 -05:00
mobile-sync Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
onboarding-flow Organizing storybook to echo app folder structure (#12796) 2021-12-01 11:27:57 -08:00
permissions-connect Choose accounts refactor (#13039) 2021-12-14 18:54:46 -05:00
routes Feat/collectibles the return (#12970) 2021-12-13 17:41:10 -06:00
send Fix order of account list (#12999) 2021-12-10 10:46:24 -06:00
settings Update ESLint config to v8 (#12886) 2021-12-09 15:36:24 -03:30
swaps Using EIP-1559 V2 for swaps (#12966) 2021-12-12 04:56:28 +05:30
unlock-page Fix unlock-page component for new Storybook format (#12894) 2021-12-06 15:08:13 -08:00
index.js remove the ui/app and ui/lib folders (#10911) 2021-04-28 14:53:59 -05:00
pages.scss Using EIP-1559 V2 for swaps (#12966) 2021-12-12 04:56:28 +05:30