1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
metamask-extension/app
Mark Stacey 22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
..
_locales Add more missing appName messages (#13140) 2021-12-21 21:36:20 -03:30
build-types Add Chrome store policy compliant names/descriptions (#13142) 2021-12-22 16:25:27 -03:30
fonts Add euclid fontface (#9018) 2020-07-27 17:15:44 -05:00
images EIP-1559 V2: Advanced gas fee modal - base fee and priority fee trends (#13025) 2021-12-21 14:01:43 -05:00
manifest Add platform-specific build type manifest modifications (#12638) 2021-11-10 19:33:59 -03:30
scripts Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
vendor/trezor Update postMessage structure for TrezorConnect 8 (#10192) 2021-01-21 11:12:54 -06:00
background.html Lavamoat build system integration for WebApp (#12242) 2021-10-05 12:06:31 -10:00
home.html Lavamoat build system integration for WebApp (#12242) 2021-10-05 12:06:31 -10:00
loading.html refactor & change html pages 2019-05-04 18:57:19 +02:00
notification.html Lavamoat build system integration for WebApp (#12242) 2021-10-05 12:06:31 -10:00
phishing.html lockdown - breakout making globalThis properties non-writable (#12258) 2021-10-01 08:53:12 -10:00
popup.html Lavamoat build system integration for WebApp (#12242) 2021-10-05 12:06:31 -10:00
trezor-usb-permissions.html trezor v5 working on firefox 2018-08-05 02:43:02 -04:00