1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-29 15:50:28 +01:00
metamask-extension/app/scripts/lib
Mark Stacey ddeaeb5ba5 Fix Sentry breadcrumb collection during initialization (again) (#20532)
Sentry breadcrumb collection during initialization was broken in #20529
because we failed to consider that the `getSentryState` check was also
used for an opt-in check in the `beforeBreadcrumb` hook.

I had assumed that `getSentryState` was only used to get state to add
additional context to an error report. But the function has a second
purpose: to get state for the purposes of checking whether the user has
opted into MetaMetrics. In this second case, `mostRecentRetrievedState`
is sometimes unset (which violates an assumption made in #20529)

The `getMostRecentPersistedState` hook removed in #20529 has been
restored, ensuring that the `getSentryState` function returns Sentry
state after loading state for the first time, but before the first
error has occurred.

This mistake didn't cause e2e tests to fail because multiple errors are
currently thrown in the background upon initialization on `develop`
(relating to Snow scuttling). These errors were early enough that they
happened before the console logs that our breadcrumb test was testing
for. When #20529 was ported onto the v10.34.5 RC, these errors were not
present so the test failed correctly.
2023-08-18 18:26:50 -02:30
..
ens-ipfs Deprecating the Rinkeby, Ropsten, and Kovan test networks (#15989) 2022-09-28 20:26:01 -07:00
middleware Convert Transaction constants to typescript (#17149) 2023-01-18 08:47:29 -06:00
migrator Log before and after each migration run (#20424) 2023-08-16 14:38:30 -02:30
rpc-method-middleware Approval flow for add & switch network (#19656) 2023-06-29 16:51:56 +01:00
segment Persisting segment events in MetaMetricsController store (#16198) 2022-11-08 04:33:03 +05:30
account-tracker.js Fix firsttimeloaded logic (#18344) 2023-04-06 12:13:01 -02:30
account-tracker.test.js Upgrading the Import Account modal (#17763) 2023-03-06 09:48:28 -08:00
cleanErrorStack.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
cleanErrorStack.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
ComposableObservableStore.js Initialize composable observable store after update (#20468) 2023-08-18 11:16:17 -02:30
ComposableObservableStore.test.js Initialize composable observable store after update (#20468) 2023-08-18 11:16:17 -02:30
createDupeReqFilterMiddleware.js Adding middleware to filter out duplicate requests from DAPP (#16730) 2022-12-02 21:08:12 +05:30
createDupeReqFilterMiddleware.test.js Privacy - Update metametrics copy during onboarding (#16825) 2022-12-07 12:56:57 -06:00
createLoggerMiddleware.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
createMetamaskMiddleware.js Update eth-json-rpc-middleware from v9 to v10 (#17591) 2023-02-27 13:19:08 -03:30
createMetaRPCHandler.js Persist state in metaRPCHandler so that we are sure state is persisted before sending back response to actions (#15978) 2022-10-10 17:10:44 -05:00
createMetaRPCHandler.test.js Remove nodeify (#13003) 2021-12-08 18:06:53 -03:30
createOnboardingMiddleware.js Deprecate extensionizer for webextension-polyfill (#13960) 2022-03-18 14:07:05 -05:00
createOriginMiddleware.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
createRPCMethodTrackingMiddleware.js Fix issue with requests with empty data being forwarded to opensea (#18598) 2023-04-17 09:54:25 +05:30
createRPCMethodTrackingMiddleware.test.js Fix issue with requests with empty data being forwarded to opensea (#18598) 2023-04-17 09:54:25 +05:30
createStreamSink.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
createTabIdMiddleware.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
extractEthjsErrorMessage.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
get-first-preferred-lang-code.js ensure that we default users with browser language code 'zh' to the supported 'zh_CN' language code (#16329) 2022-10-31 16:48:51 -05:00
getObjStructure.js remove exclusions for mismatched object jsdoc type casing (#15351) 2022-07-27 08:28:05 -05:00
local-store.js Improve Sentry state pre-initialization (#20491) 2023-08-17 14:22:31 -02:30
local-store.test.js Improve Sentry state pre-initialization (#20491) 2023-08-17 14:22:31 -02:30
metaRPCClientFactory.js Update @metamask/safe-event-emitter (#18419) 2023-04-03 15:57:39 -02:30
metaRPCClientFactory.test.js Fix rpc and tests (#15570) 2022-08-16 18:21:35 +05:30
network-store.js Fix pre-initialization UI error state capture (#20529) 2023-08-18 16:35:03 -02:30
notification-manager.js Update @metamask/safe-event-emitter (#18419) 2023-04-03 15:57:39 -02:30
notification-manager.test.ts fix(17855): persist popup when sw is restarted (#17855) 2023-03-02 16:50:00 +00:00
security-provider-helpers.test.ts Adopt security provider request from core (#18520) 2023-04-18 08:33:32 +01:00
security-provider-helpers.ts Adopt security provider request from core (#18520) 2023-04-18 08:33:32 +01:00
seed-phrase-verifier.js Refactor KeyringTypes constant (#17490) 2023-03-21 12:13:22 -02:30
seed-phrase-verifier.test.js Refactor KeyringTypes constant (#17490) 2023-03-21 12:13:22 -02:30
sentry-filter-events.ts Capture Sentry errors prior to initialization (#20265) (#20330) 2023-07-31 20:35:50 -02:30
setup-initial-state-hooks.js Fix Sentry breadcrumb collection during initialization (again) (#20532) 2023-08-18 18:26:50 -02:30
setupSentry.js Fix Sentry breadcrumbs collection during initialization (#20521) 2023-08-18 06:07:35 -02:30
setupSentry.test.js Sanitize privacy sensitive data before sending to sentry. (#16780) 2022-12-16 11:56:23 -03:30
stream-utils.js Minor scripts/ui.js file cleanup (#16566) 2022-11-18 20:57:01 +07:00
util.test.js Convert Transaction constants to typescript (#17149) 2023-01-18 08:47:29 -06:00
util.ts Convert app//scripts/lib/util.js to typescript (#17330) 2023-01-23 10:18:22 -06:00