mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
96929d99c0
What - modify `ui/app/helpers/utils/transactions.util.js` and `ui/lib/account-link.js` to strip trailing slashes if they are present. - added relevant tests not just for the new scenario, but also the general scenarios for these functions, as there previously was no test coverage for these two functions. Why - Current behaviour, when user enters a block explorer URL when configuring a custom RPC, and that block explorer URL contains a trailing `/`. - e.g. `https://block.explorer/` - this results in a double-slash (`//`) in the transaction and account URLs generated by MetaMask. - e.g. `https://block.explorer/tx/0xabcd...`, `https://block.explorer/account/0xabcd...` - This needs to be handled using a router redirect on the server of the block explorer, and this changes would avoid that requirement.
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
import getAccountLink from '../../../ui/lib/account-link'
|
|
import assert from 'assert'
|
|
|
|
describe('Account link', function () {
|
|
describe('getAccountLink', function () {
|
|
it('should return the correct block explorer url for an account', function () {
|
|
const tests = [
|
|
{
|
|
expected: 'https://etherscan.io/address/0xabcd',
|
|
network: 1,
|
|
address: '0xabcd',
|
|
},
|
|
{
|
|
expected: 'https://ropsten.etherscan.io/address/0xdef0',
|
|
network: 3,
|
|
address: '0xdef0',
|
|
rpcPrefs: {},
|
|
},
|
|
{
|
|
// test handling of `blockExplorerUrl` for a custom RPC
|
|
expected: 'https://block.explorer/address/0xabcd',
|
|
network: 31,
|
|
address: '0xabcd',
|
|
rpcPrefs: {
|
|
blockExplorerUrl: 'https://block.explorer',
|
|
},
|
|
},
|
|
{
|
|
// test handling of trailing `/` in `blockExplorerUrl` for a custom RPC
|
|
expected: 'https://another.block.explorer/address/0xdef0',
|
|
network: 33,
|
|
address: '0xdef0',
|
|
rpcPrefs: {
|
|
blockExplorerUrl: 'https://another.block.explorer/',
|
|
},
|
|
},
|
|
]
|
|
|
|
tests.forEach(({ expected, address, network, rpcPrefs }) => {
|
|
assert.equal(getAccountLink(address, network, rpcPrefs), expected)
|
|
})
|
|
})
|
|
})
|
|
})
|