1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-25 20:02:58 +01:00
metamask-extension/development/build
Mark Stacey b124ac29fc
Improve detection of task process exit (#10776)
Our build script waits for the `close` event to determine whether the
task has exited. The `exit` event is a better representation of this,
because if a stream is shared between multiple processes, the process
may exit without the `close` event being emitted.

We aren't sharing streams between processes, so this edge case doesn't
apply to us. This just seemed like a more suitable event to listen to,
since we care about the process exiting not the stream ending.

See this description of the `close` event from the Node.js
documentation [1]:

>The `'close'` event is emitted when the stdio streams of a child
>process have been closed. This is distinct from the `'exit'` event,
>since multiple processes might share the same stdio streams.

And see this description of the `exit` event:

>The `'exit'` event is emitted after the child process ends.

[1]: https://nodejs.org/docs/latest-v14.x/api/child_process.html#child_process_event_exit
2021-03-31 13:13:17 -02:30
..
display.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
etc.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
index.js Add Lavamoat to build system (#9939) 2021-02-22 22:43:29 +08:00
manifest.js Build - refactor background process to use html (#10769) 2021-03-31 11:12:28 +08:00
sass-compiler.js Add Lavamoat to build system (#9939) 2021-02-22 22:43:29 +08:00
scripts.js build - refactor build system for easier configuration (#10718) 2021-03-26 12:26:19 +08:00
static.js build - fix use of empty file to replace unused js files (#10780) 2021-03-31 16:13:37 +08:00
styles.js Reduce build warnings related to Sass (#10494) 2021-02-23 13:04:14 -03:30
task.js Improve detection of task process exit (#10776) 2021-03-31 13:13:17 -02:30