1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/app
Mark Stacey dbd14d796c
Clear beforeunload handler after button is pressed (#7346)
On the signature request and transaction confirmation notification
pages, the closure of the notification UI implies that the request has
been rejected. However, this rejection is being submitted even when the
window is closed as a result of the user explicitly confirming or
rejecting. In practice, I suspect this has no effect because the
transaction, after being explicitly confirmed or rejected, has already
been moved out of a pending state. But just in case there is some
present or future edge case that might be affected, the `beforeunload`
handler is now removed once the user has explicitly made a choice.

This mistake was introduced recently in #7333
2019-11-04 14:03:57 -04:00
..
components Clear beforeunload handler after button is pressed (#7346) 2019-11-04 14:03:57 -04:00
css Refactor new-account.js (#7312) 2019-10-29 12:12:41 -04:00
ducks Remove logging of action.value of set_next_nonce (#7233) 2019-09-30 19:17:45 -03:00
helpers Adds Wyre Widget (#6434) 2019-11-04 11:13:24 -03:30
pages Clear beforeunload handler after button is pressed (#7346) 2019-11-04 14:03:57 -04:00
selectors Add Estimated time to pending tx (#6924) 2019-10-31 23:21:28 -02:30
store ENS Reverse Resolution support (#7177) 2019-11-01 15:24:00 -02:30