mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00

History

ricky 5f254f7325 Add advanced setting to enable editing nonce on confirmation screens (#7089 ) * Add UseNonce toggle * Get the toggle actually working and dispatching * Display nonce field on confirmation page * Remove console.log * Add placeholder * Set customNonceValue * Add nonce key/value to txParams * remove customNonceValue from component state * Use translation file and existing CSS class * Use existing TextField component * Remove console.log * Fix lint nits * Okay this sorta works? * Move nonce toggle to advanced tab * Set min to 0 * Wrap value in Number() * Add customNonceMap * Update custom nonce translation * Update styles * Reset CustomNonce * Fix lint * Get tests passing * Add customNonceValue to defaults * Fix test * Fix comments * Update tests * Use camel case * Ensure custom nonce can only be whole number * Correct font size for custom nonce input * UX improvements for custom nonce feature * Fix advanced-tab-component tests for custom nonce changes * Update title of nonce toggle in settings * Remove unused locale message * Cast custom nonce to string in confirm-transaction-base.component * Handle string conversion and invalid values for custom nonces in handler * Don't call getNonceLock in tx controller if there is a custom nonce * Set nonce details for cases where nonce is customized * Fix incorrectly use value for deciding whether to getnoncelock in approveTransaction * Default nonceLock to empty object in approveTransaction * Reapply use on nonceLock in cases where customNonceValue in approveTransaction. * Show warning message if custom nonce is higher than MetaMask's next nonce * Fix e2e test failure caused by custom nonce and 3box toggle conflict * Update nonce warning message to include the suggested nonce * Handle nextNonce comparison and update logic in lifecycle * Default nonce field to suggested nonce * Clear custom nonce on reject or confirm * Fix bug where nonces are not shown in tx list on self sent transactions * Ensure custom nonce is reset after tx is created in background * Convert customNonceValue to number in approve tranasction controller * Lint fix * Call getNextNonce after updating custom nonce		2019-09-27 00:30:36 -04:00
..
lib	Enable indent linting via ESLint (#6936 )	2019-07-31 10:17:11 -10:00
enums.js	Group transactions by nonce (#5886 )	2018-12-09 12:48:06 -08:00
index.js	Add advanced setting to enable editing nonce on confirmation screens (#7089 )	2019-09-27 00:30:36 -04:00
pending-tx-tracker.js	Enable indent linting via ESLint (#6936 )	2019-07-31 10:17:11 -10:00
README.md	Cleaned up some typos and JSDocs in Transactions	2018-04-23 09:43:18 -07:00
tx-gas-utils.js	Set a default value for code in _determineTransactionCategory (#6604 )	2019-05-14 14:14:07 -04:00
tx-state-manager.js	transactions:tx-state-manager - optionally take a function as a search param (#7078 )	2019-08-29 14:57:28 +02:00

README.md

Transaction Controller

Transaction Controller is an aggregate of sub-controllers and trackers exposed to the MetaMask controller.

txStateManager responsible for the state of a transaction and storing the transaction
pendingTxTracker watching blocks for transactions to be include and emitting confirmed events
txGasUtil gas calculations and safety buffering
nonceTracker calculating nonces

Flow diagram of processing a transaction

txMeta's & txParams

A txMeta is the "meta" object it has all the random bits of info we need about a transaction on it. txParams are sacred every thing on txParams gets signed so it must be a valid key and be hex prefixed except for the network number. Extra stuff must go on the txMeta!

Here is a txMeta too look at:

txMeta = {
  "id": 2828415030114568, // unique id for this txMeta used for look ups
  "time": 1524094064821, // time of creation
  "status": "confirmed",
  "metamaskNetworkId": "1524091532133", //the network id for the transaction
  "loadingDefaults": false, // used to tell the ui when we are done calculatyig gass defaults
  "txParams": { // the txParams object
    "from": "0x8acce2391c0d510a6c5e5d8f819a678f79b7e675",
    "to": "0x8acce2391c0d510a6c5e5d8f819a678f79b7e675",
    "value": "0x0",
    "gasPrice": "0x3b9aca00",
    "gas": "0x7b0c",
    "nonce": "0x0"
  },
  "history": [{ //debug
            "id": 2828415030114568,
            "time": 1524094064821,
            "status": "unapproved",
            "metamaskNetworkId": "1524091532133",
            "loadingDefaults": true,
            "txParams": {
              "from": "0x8acce2391c0d510a6c5e5d8f819a678f79b7e675",
              "to": "0x8acce2391c0d510a6c5e5d8f819a678f79b7e675",
              "value": "0x0"
            }
          },
          [
            {
              "op": "add",
              "path": "/txParams/gasPrice",
              "value": "0x3b9aca00"
            },
            ...], // I've removed most of history for this
  "gasPriceSpecified": false, //whether or not the user/dapp has specified gasPrice
  "gasLimitSpecified": false, //whether or not the user/dapp has specified gas
  "estimatedGas": "5208",
  "origin": "MetaMask", //debug
  "nonceDetails": {
    "params": {
      "highestLocallyConfirmed": 0,
      "highestSuggested": 0,
      "nextNetworkNonce": 0
    },
    "local": {
      "name": "local",
      "nonce": 0,
      "details": {
        "startPoint": 0,
        "highest": 0
      }
    },
    "network": {
      "name": "network",
      "nonce": 0,
      "details": {
        "baseCount": 0
      }
    }
  },
  "rawTx": "0xf86980843b9aca00827b0c948acce2391c0d510a6c5e5d8f819a678f79b7e67580808602c5b5de66eea05c01a320b96ac730cb210ca56d2cb71fa360e1fc2c21fa5cf333687d18eb323fa02ed05987a6e5fd0f2459fcff80710b76b83b296454ad9a37594a0ccb4643ea90", // used for rebroadcast
  "hash": "0xa45ba834b97c15e6ff4ed09badd04ecd5ce884b455eb60192cdc73bcc583972a",
  "submittedTime": 1524094077902 // time of the attempt to submit the raw tx to the network, used in the ui to show the retry button
}