metamask-extension/createJsonRpcClient.test.js at d9826e938526515e03191801696dd85e129df638 - metamask-extension - git.berlin

m/metamask-extension

mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00

Zachary Belford cd2249f193

Add tests for custom JSON-RPC network client (#16337 )

Previously we had written tests for `createInfuraClient`, which creates a middleware stack designed to connect to an Infura provider. These tests exercise various RPC methods that relate to the behavior that the middleware provides (mainly around caching). 

Now we need to write the same tests but for `createJsonRpcClient`, which creates a middleware stack designed to connect to a non-Infura RPC endpoint. To do this, we had to:

- Consolidate the tests for both types of RPC client into a single test file.
- Add conditions around tests or assertions in tests to account for differences in behavior between the two sets of middleware stacks.
- Relocate code in `createJsonRpcClient` which slows down `eth_estimateGas` calls just for tests so that this behavior can be disabled in the network client tests.

Eventually, as we unify the network controllers in this repo and in the core repo, we will move these tests into the core repo.

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>

2023-01-06 10:10:17 -07:00

6 lines

153 B

JavaScript

Raw Blame History

 import { testsForProviderType } from './provider-api-tests/shared-tests';
 describe('createJsonRpcClient', () => {
   testsForProviderType('custom');
 });