mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
5ee1291662
Previously all browser globals were allowed to be used anywhere by ESLint because we had set the `env` property to `browser` in the ESLint config. This has made it easy to accidentally use browser globals (e.g. #8338), so it has been removed. Instead we now have a short list of allowed globals. All browser globals are now accessed as properties on `window`. Unfortunately this change resulted in a few different confusing unit test errors, as some of our unit tests setup assumed that a particular global would be used via `window` or `global`. In particular, `window.fetch` didn't work correctly because it wasn't patched by the AbortController polyfill (only `global.fetch` was being patched). The `jsdom-global` package we were using complicated matters by setting all of the JSDOM `window` properties directly on `global`, overwriting the `AbortController` for example. The `helpers.js` test setup module has been simplified somewhat by removing `jsdom-global` and constructing the JSDOM instance manually. The JSDOM window is set on `window`, and a few properties are set on `global` as well as needed by various dependencies. `node-fetch` and the AbortController polyfill/patch now work as expected as well, though `fetch` is only available on `window` now.
63 lines
1.3 KiB
JavaScript
63 lines
1.3 KiB
JavaScript
import log from 'loglevel'
|
|
|
|
const FIXTURE_SERVER_HOST = 'localhost'
|
|
const FIXTURE_SERVER_PORT = 12345
|
|
const FIXTURE_SERVER_URL = `http://${FIXTURE_SERVER_HOST}:${FIXTURE_SERVER_PORT}/state.json`
|
|
|
|
/**
|
|
* A read-only network-based storage wrapper
|
|
*/
|
|
class ReadOnlyNetworkStore {
|
|
constructor () {
|
|
this._initialized = false
|
|
this._initializing = this._init()
|
|
this._state = undefined
|
|
}
|
|
|
|
/**
|
|
* Declares this store as compatible with the current browser
|
|
*/
|
|
isSupported = true
|
|
|
|
/**
|
|
* Initializes by loading state from the network
|
|
*/
|
|
async _init () {
|
|
try {
|
|
const response = await window.fetch(FIXTURE_SERVER_URL)
|
|
if (response.ok) {
|
|
this._state = await response.json()
|
|
}
|
|
} catch (error) {
|
|
log.debug(`Error loading network state: '${error.message}'`)
|
|
} finally {
|
|
this._initialized = true
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Returns state
|
|
* @returns {Promise<object>}
|
|
*/
|
|
async get () {
|
|
if (!this._initialized) {
|
|
await this._initializing
|
|
}
|
|
return this._state
|
|
}
|
|
|
|
/**
|
|
* Set state
|
|
* @param {Object} state - The state to set
|
|
* @returns {Promise<void>}
|
|
*/
|
|
async set (state) {
|
|
if (!this._initialized) {
|
|
await this._initializing
|
|
}
|
|
this._state = state
|
|
}
|
|
}
|
|
|
|
export default ReadOnlyNetworkStore
|