mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-27 12:56:01 +01:00
d359429f04
* Stop GasFeeController polling when pop closes * Stop estimate gas polling on window unload * lint + comments * Improve client closed logic * lint * Add back _beforeUnload on unmount in gas-modal-page-container * Add full check and call onClientClosed method for notifcation environment * Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type * remove unused method * move controller manipulation logic from background.js to metamask-controller, disaggregate methods * add beforeunload handling to reset gas polling tokens from root of send page * cleanup, lint and address feedback * clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller * mock new methods to fix tests * final bit of cleanup + comments Co-authored-by: Dan Miller <danjm.com@gmail.com>
273 lines
9.0 KiB
JavaScript
273 lines
9.0 KiB
JavaScript
import React from 'react';
|
|
import sinon from 'sinon';
|
|
import { shallowWithContext } from '../../../../../test/lib/render-helpers';
|
|
import { getGasFeeEstimatesAndStartPolling } from '../../../../store/actions';
|
|
|
|
import PageContainer from '../../../ui/page-container';
|
|
|
|
import { Tab } from '../../../ui/tabs';
|
|
import GasModalPageContainer from './gas-modal-page-container.component';
|
|
|
|
jest.mock('../../../../store/actions', () => ({
|
|
disconnectGasFeeEstimatePoller: jest.fn(),
|
|
getGasFeeEstimatesAndStartPolling: jest
|
|
.fn()
|
|
.mockImplementation(() => Promise.resolve()),
|
|
addPollingTokenToAppState: jest.fn(),
|
|
}));
|
|
|
|
const propsMethodSpies = {
|
|
cancelAndClose: sinon.spy(),
|
|
onSubmit: sinon.spy(),
|
|
};
|
|
|
|
const mockGasPriceButtonGroupProps = {
|
|
buttonDataLoading: false,
|
|
className: 'gas-price-button-group',
|
|
gasButtonInfo: [
|
|
{
|
|
feeInPrimaryCurrency: '$0.52',
|
|
feeInSecondaryCurrency: '0.0048 ETH',
|
|
timeEstimate: '~ 1 min 0 sec',
|
|
priceInHexWei: '0xa1b2c3f',
|
|
},
|
|
{
|
|
feeInPrimaryCurrency: '$0.39',
|
|
feeInSecondaryCurrency: '0.004 ETH',
|
|
timeEstimate: '~ 1 min 30 sec',
|
|
priceInHexWei: '0xa1b2c39',
|
|
},
|
|
{
|
|
feeInPrimaryCurrency: '$0.30',
|
|
feeInSecondaryCurrency: '0.00354 ETH',
|
|
timeEstimate: '~ 2 min 1 sec',
|
|
priceInHexWei: '0xa1b2c30',
|
|
},
|
|
],
|
|
handleGasPriceSelection: 'mockSelectionFunction',
|
|
noButtonActiveByDefault: true,
|
|
showCheck: true,
|
|
newTotalFiat: 'mockNewTotalFiat',
|
|
newTotalEth: 'mockNewTotalEth',
|
|
};
|
|
const mockInfoRowProps = {
|
|
originalTotalFiat: 'mockOriginalTotalFiat',
|
|
originalTotalEth: 'mockOriginalTotalEth',
|
|
newTotalFiat: 'mockNewTotalFiat',
|
|
newTotalEth: 'mockNewTotalEth',
|
|
sendAmount: 'mockSendAmount',
|
|
transactionFee: 'mockTransactionFee',
|
|
extraInfoRow: { label: 'mockLabel', value: 'mockValue' },
|
|
};
|
|
|
|
const GP = GasModalPageContainer.prototype;
|
|
describe('GasModalPageContainer Component', () => {
|
|
let wrapper;
|
|
|
|
beforeEach(() => {
|
|
wrapper = shallowWithContext(
|
|
<GasModalPageContainer
|
|
cancelAndClose={propsMethodSpies.cancelAndClose}
|
|
onSubmit={propsMethodSpies.onSubmit}
|
|
updateCustomGasPrice={() => 'mockupdateCustomGasPrice'}
|
|
updateCustomGasLimit={() => 'mockupdateCustomGasLimit'}
|
|
gasPriceButtonGroupProps={mockGasPriceButtonGroupProps}
|
|
infoRowProps={mockInfoRowProps}
|
|
customGasPriceInHex="mockCustomGasPriceInHex"
|
|
customGasLimitInHex="mockCustomGasLimitInHex"
|
|
insufficientBalance={false}
|
|
disableSave={false}
|
|
customPriceIsExcessive={false}
|
|
/>,
|
|
);
|
|
});
|
|
|
|
afterEach(() => {
|
|
propsMethodSpies.cancelAndClose.resetHistory();
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('componentDidMount', () => {
|
|
it('should call getGasFeeEstimatesAndStartPolling', () => {
|
|
jest.clearAllMocks();
|
|
expect(getGasFeeEstimatesAndStartPolling).not.toHaveBeenCalled();
|
|
wrapper.instance().componentDidMount();
|
|
expect(getGasFeeEstimatesAndStartPolling).toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe('render', () => {
|
|
it('should render a PageContainer compenent', () => {
|
|
expect(wrapper.find(PageContainer)).toHaveLength(1);
|
|
});
|
|
|
|
it('should pass correct props to PageContainer', () => {
|
|
const { title, subtitle, disabled } = wrapper.find(PageContainer).props();
|
|
expect(title).toStrictEqual('customGas');
|
|
expect(subtitle).toStrictEqual('customGasSubTitle');
|
|
expect(disabled).toStrictEqual(false);
|
|
});
|
|
|
|
it('should pass the correct onCancel and onClose methods to PageContainer', () => {
|
|
const { onCancel, onClose } = wrapper.find(PageContainer).props();
|
|
expect(propsMethodSpies.cancelAndClose.callCount).toStrictEqual(0);
|
|
onCancel();
|
|
expect(propsMethodSpies.cancelAndClose.callCount).toStrictEqual(1);
|
|
onClose();
|
|
expect(propsMethodSpies.cancelAndClose.callCount).toStrictEqual(2);
|
|
});
|
|
|
|
it('should pass the correct renderTabs property to PageContainer', () => {
|
|
jest
|
|
.spyOn(GasModalPageContainer.prototype, 'renderTabs')
|
|
.mockImplementation(() => 'mockTabs');
|
|
const renderTabsWrapperTester = shallowWithContext(
|
|
<GasModalPageContainer customPriceIsExcessive={false} />,
|
|
{ context: { t: (str1, str2) => (str2 ? str1 + str2 : str1) } },
|
|
);
|
|
const { tabsComponent } = renderTabsWrapperTester
|
|
.find(PageContainer)
|
|
.props();
|
|
expect(tabsComponent).toStrictEqual('mockTabs');
|
|
GasModalPageContainer.prototype.renderTabs.mockClear();
|
|
});
|
|
});
|
|
|
|
describe('renderTabs', () => {
|
|
beforeEach(() => {
|
|
sinon.spy(GP, 'renderBasicTabContent');
|
|
sinon.spy(GP, 'renderAdvancedTabContent');
|
|
sinon.spy(GP, 'renderInfoRows');
|
|
});
|
|
|
|
afterEach(() => {
|
|
GP.renderBasicTabContent.restore();
|
|
GP.renderAdvancedTabContent.restore();
|
|
GP.renderInfoRows.restore();
|
|
});
|
|
|
|
it('should render a Tabs component with "Basic" and "Advanced" tabs', () => {
|
|
const renderTabsResult = wrapper.instance().renderTabs();
|
|
const renderedTabs = shallowWithContext(renderTabsResult);
|
|
expect(renderedTabs.props().className).toStrictEqual('tabs');
|
|
|
|
const tabs = renderedTabs.find(Tab);
|
|
expect(tabs).toHaveLength(2);
|
|
|
|
expect(tabs.at(0).props().name).toStrictEqual('basic');
|
|
expect(tabs.at(1).props().name).toStrictEqual('advanced');
|
|
|
|
expect(tabs.at(0).childAt(0).props().className).toStrictEqual(
|
|
'gas-modal-content',
|
|
);
|
|
expect(tabs.at(1).childAt(0).props().className).toStrictEqual(
|
|
'gas-modal-content',
|
|
);
|
|
});
|
|
|
|
it('should call renderInfoRows with the expected props', () => {
|
|
expect(GP.renderInfoRows.callCount).toStrictEqual(0);
|
|
|
|
wrapper.instance().renderTabs();
|
|
|
|
expect(GP.renderInfoRows.callCount).toStrictEqual(2);
|
|
|
|
expect(GP.renderInfoRows.getCall(0).args).toStrictEqual([
|
|
'mockNewTotalFiat',
|
|
'mockNewTotalEth',
|
|
'mockSendAmount',
|
|
'mockTransactionFee',
|
|
]);
|
|
expect(GP.renderInfoRows.getCall(1).args).toStrictEqual([
|
|
'mockNewTotalFiat',
|
|
'mockNewTotalEth',
|
|
'mockSendAmount',
|
|
'mockTransactionFee',
|
|
]);
|
|
});
|
|
|
|
it('should not render the basic tab if hideBasic is true', () => {
|
|
wrapper = shallowWithContext(
|
|
<GasModalPageContainer
|
|
cancelAndClose={propsMethodSpies.cancelAndClose}
|
|
onSubmit={propsMethodSpies.onSubmit}
|
|
updateCustomGasPrice={() => 'mockupdateCustomGasPrice'}
|
|
updateCustomGasLimit={() => 'mockupdateCustomGasLimit'}
|
|
gasPriceButtonGroupProps={mockGasPriceButtonGroupProps}
|
|
infoRowProps={mockInfoRowProps}
|
|
customGasPriceInHex="mockCustomGasPriceInHex"
|
|
customGasLimitInHex="mockCustomGasLimitInHex"
|
|
insufficientBalance={false}
|
|
disableSave={false}
|
|
customPriceIsExcessive={false}
|
|
hideBasic
|
|
/>,
|
|
);
|
|
const renderTabsResult = wrapper.instance().renderTabs();
|
|
|
|
const renderedTabs = shallowWithContext(renderTabsResult);
|
|
const tabs = renderedTabs.find(Tab);
|
|
expect(tabs).toHaveLength(1);
|
|
expect(tabs.at(0).props().name).toStrictEqual('advanced');
|
|
});
|
|
});
|
|
|
|
describe('renderBasicTabContent', () => {
|
|
it('should render', () => {
|
|
const renderBasicTabContentResult = wrapper
|
|
.instance()
|
|
.renderBasicTabContent(mockGasPriceButtonGroupProps);
|
|
|
|
expect(
|
|
renderBasicTabContentResult.props.gasPriceButtonGroupProps,
|
|
).toStrictEqual(mockGasPriceButtonGroupProps);
|
|
});
|
|
});
|
|
|
|
describe('renderInfoRows', () => {
|
|
it('should render the info rows with the passed data', () => {
|
|
const baseClassName = 'gas-modal-content__info-row';
|
|
const renderedInfoRowsContainer = shallowWithContext(
|
|
wrapper
|
|
.instance()
|
|
.renderInfoRows(
|
|
'mockNewTotalFiat',
|
|
' mockNewTotalEth',
|
|
' mockSendAmount',
|
|
' mockTransactionFee',
|
|
),
|
|
);
|
|
|
|
expect(
|
|
renderedInfoRowsContainer.childAt(0).hasClass(baseClassName),
|
|
).toStrictEqual(true);
|
|
|
|
const renderedInfoRows = renderedInfoRowsContainer.childAt(0).children();
|
|
expect(renderedInfoRows).toHaveLength(4);
|
|
expect(
|
|
renderedInfoRows.at(0).hasClass(`${baseClassName}__send-info`),
|
|
).toStrictEqual(true);
|
|
expect(
|
|
renderedInfoRows.at(1).hasClass(`${baseClassName}__transaction-info`),
|
|
).toStrictEqual(true);
|
|
expect(
|
|
renderedInfoRows.at(2).hasClass(`${baseClassName}__total-info`),
|
|
).toStrictEqual(true);
|
|
expect(
|
|
renderedInfoRows.at(3).hasClass(`${baseClassName}__fiat-total-info`),
|
|
).toStrictEqual(true);
|
|
|
|
expect(renderedInfoRows.at(0).text()).toStrictEqual(
|
|
'sendAmount mockSendAmount',
|
|
);
|
|
expect(renderedInfoRows.at(1).text()).toStrictEqual(
|
|
'transactionFee mockTransactionFee',
|
|
);
|
|
expect(renderedInfoRows.at(2).text()).toStrictEqual(
|
|
'newTotal mockNewTotalEth',
|
|
);
|
|
expect(renderedInfoRows.at(3).text()).toStrictEqual('mockNewTotalFiat');
|
|
});
|
|
});
|
|
});
|