1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts/controllers
Erik Marks cef95f8733
Stop storing request and response objects in the permission activity log (#14485)
We currently store the JSON-RPC request and response objects in the permission activity log. The utility of doing this was always rather dubious, but never problematic. Until now.

In Flask, as the restricted methods have expanded in number, user secrets may be included on JSON-RPC message objects. This PR removes these properties from the permission activity log, and adds a migration which does the same to existing log objects. We don't interact with the log objects anywhere in our codebase, but we don't want unexpected properties to cause errors in the future should any log objects be retained.

This PR also updates relevant tests and test data. It makes a minor functional change to how a request is designated as a success or failure, but this should not change any behavior in practice.
2022-04-21 08:44:15 -07:00
..
ens use safer toChecksum utility (#11117) 2021-05-17 16:19:39 -05:00
network Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
permissions Stop storing request and response objects in the permission activity log (#14485) 2022-04-21 08:44:15 -07:00
transactions TransactionsControllerTest: catch uncaught errors (#14196) 2022-03-30 11:13:25 -03:00
alert.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
app-state.js More nft ux fixes (#13388) 2022-01-27 11:26:33 -06:00
cached-balances.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
cached-balances.test.js Use strict assertion mode everywhere (#11012) 2021-05-07 17:08:24 -02:30
detect-tokens.js Update DetectTokenController for token detection V2 (#14216) 2022-04-13 12:23:41 -04:00
detect-tokens.test.js Turning OFF token detection for test nets (#12232) 2021-09-29 14:53:56 -04:00
incoming-transactions.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
incoming-transactions.test.js Add JSDoc ESLint rules (#12112) 2022-01-07 12:27:33 -03:30
metametrics.js Dark Mode: Implement Metrics (#14455) 2022-04-18 11:31:44 -05:00
metametrics.test.js Dark Mode: Implement Metrics (#14455) 2022-04-18 11:31:44 -05:00
onboarding.js fix registerOnboarding method to correctly access completedOnboarding state value (#13723) 2022-02-22 18:59:26 -06:00
preferences.js Enable Token Detection by default on supported networks (#14002) 2022-03-31 09:47:19 -04:00
preferences.test.js Adding new settings dropdown for Dark mode in Experimental tab (#13097) 2022-03-07 12:53:19 -06:00
swaps.js Swaps timer improvements, optional refresh rates and fix for a notification UI (#14300) 2022-04-04 15:14:50 +02:00
swaps.test.js Add support for Smart Transactions (#12676) 2022-02-18 17:48:38 +01:00
threebox.js eth-json-rpc-middleware@8.0.0 (#10738) 2021-11-11 12:26:49 -08:00