1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/app
Mark Stacey cdfa2e66fd
Hide retry button for on-chain failures (#9506)
On-chain failed transactions have a transaction status of `confirmed`,
and should not be retried. Our retry function doesn't handle on-chain
failures yet, so it would inevitably fail due to the transaction having
the same nonce as a confirmed on-chain transaction.

When determining whether to show the retry button in the UI, we had
mistakenly been using a `status` variable that determined whether we
should show "Failed" on that transaction in the activity log. That
display status includes both network and on-chain failures, unlike
the `txMeta.status` property.

The `showRetry` logic has been updated to ensure it's only shown when
`txMeta.status` is `failed`, meaning on-chain failures will no longer
show the retry button. Additionally, the display-specific `status`
variable has been renamed to `displayedStatusKey`, to indicate that it
is a string that corresponds to a localized message, and that it's the
status meant for display purposes.
2020-10-07 14:59:38 -07:00
..
components Hide retry button for on-chain failures (#9506) 2020-10-07 14:59:38 -07:00
contexts add segment implementation of metametrics (#9382) 2020-09-14 12:04:05 -05:00
css Feature/hide seedphrase when restoring vault (#9329) 2020-09-02 11:45:09 -04:00
ducks Stop passing a gas param to the estimateGas call initiated in the swaps controller (#9501) 2020-10-07 16:30:17 -02:30
helpers Check specified chain ID against endpoint return value (#9491) 2020-10-07 11:58:22 -02:30
hooks Hide retry button for on-chain failures (#9506) 2020-10-07 14:59:38 -07:00
pages Prevent user from submitting swap if they do not have enough for the max gas fee (#9500) 2020-10-07 09:55:38 -07:00
selectors Fix missing app header on Home screen (#9498) 2020-10-07 14:15:39 -02:30
store Stop passing a gas param to the estimateGas call initiated in the swaps controller (#9501) 2020-10-07 16:30:17 -02:30