1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-26 13:20:26 +02:00
metamask-extension/test/unit/migrations/047-test.js
Mark Stacey a71cc2b137
Fix display of incoming transactions (#8942)
The `metamaskNetworkId` property in the `txMeta` for incoming
transactions was incorrectly set as a Number instead of a String. This
change was made accidentally as part of #8627.

As a result incoming transactions were being excluded from the
transaction list, as they didn't have a matching network ID.

`metamaskNetworkId` is now set to a string, and a migration has been
added to ensure `metamaskNetworkId` is converted to a string for any
incoming transactions in state.
2020-07-08 16:48:39 -03:00

110 lines
2.8 KiB
JavaScript

import { strict as assert } from 'assert'
import migration47 from '../../../app/scripts/migrations/047'
describe('migration #47', function () {
it('should update the version metadata', async function () {
const oldStorage = {
'meta': {
'version': 46,
},
'data': {},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(newStorage.meta, {
'version': 47,
})
})
it('should stringify transactions metamaskNetworkId values', async function () {
const oldStorage = {
meta: {},
data: {
TransactionsController: {
transactions: [
{ foo: 'bar', metamaskNetworkId: 2 },
{ foo: 'bar' },
{ foo: 'bar', metamaskNetworkId: 0 },
{ foo: 'bar', metamaskNetworkId: 42 },
],
},
foo: 'bar',
},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(newStorage.data, {
TransactionsController: {
transactions: [
{ foo: 'bar', metamaskNetworkId: '2' },
{ foo: 'bar' },
{ foo: 'bar', metamaskNetworkId: '0' },
{ foo: 'bar', metamaskNetworkId: '42' },
],
},
foo: 'bar',
})
})
it('should do nothing if transactions metamaskNetworkId values are already strings', async function () {
const oldStorage = {
meta: {},
data: {
TransactionsController: {
transactions: [
{ foo: 'bar', metamaskNetworkId: '2' },
{ foo: 'bar' },
{ foo: 'bar', metamaskNetworkId: '0' },
{ foo: 'bar', metamaskNetworkId: '42' },
],
},
foo: 'bar',
},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(oldStorage.data, newStorage.data)
})
it('should do nothing if transactions state does not exist', async function () {
const oldStorage = {
meta: {},
data: {
TransactionsController: {
bar: 'baz',
},
foo: 'bar',
},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(oldStorage.data, newStorage.data)
})
it('should do nothing if transactions state is empty', async function () {
const oldStorage = {
meta: {},
data: {
TransactionsController: {
transactions: [],
bar: 'baz',
},
foo: 'bar',
},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(oldStorage.data, newStorage.data)
})
it('should do nothing if state is empty', async function () {
const oldStorage = {
meta: {},
data: {},
}
const newStorage = await migration47.migrate(oldStorage)
assert.deepEqual(oldStorage.data, newStorage.data)
})
})