mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-12 04:37:13 +01:00
432d6508ba
* Stringify gas estimate in backend, before it is serialized and sent to ui * Fix send.utils.test.js
480 lines
15 KiB
JavaScript
480 lines
15 KiB
JavaScript
import sinon from 'sinon';
|
|
import { rawEncode } from 'ethereumjs-abi';
|
|
|
|
import {
|
|
multiplyCurrencies,
|
|
addCurrencies,
|
|
conversionGTE,
|
|
conversionUtil,
|
|
} from '../../helpers/utils/conversion-util';
|
|
|
|
import { GAS_LIMITS } from '../../../shared/constants/gas';
|
|
import {
|
|
calcGasTotal,
|
|
estimateGasForSend,
|
|
doesAmountErrorRequireUpdate,
|
|
generateTokenTransferData,
|
|
getAmountErrorObject,
|
|
getGasFeeErrorObject,
|
|
getToAddressForGasUpdate,
|
|
calcTokenBalance,
|
|
isBalanceSufficient,
|
|
isTokenBalanceSufficient,
|
|
removeLeadingZeroes,
|
|
} from './send.utils';
|
|
|
|
import {
|
|
INSUFFICIENT_FUNDS_ERROR,
|
|
INSUFFICIENT_TOKENS_ERROR,
|
|
} from './send.constants';
|
|
|
|
jest.mock('../../helpers/utils/conversion-util', () => ({
|
|
addCurrencies: jest.fn((a, b) => {
|
|
let [a1, b1] = [a, b];
|
|
if (String(a).match(/^0x.+/u)) {
|
|
a1 = Number(String(a).slice(2));
|
|
}
|
|
if (String(b).match(/^0x.+/u)) {
|
|
b1 = Number(String(b).slice(2));
|
|
}
|
|
return a1 + b1;
|
|
}),
|
|
conversionUtil: jest.fn((val) => parseInt(val, 16)),
|
|
conversionGTE: jest.fn((obj1, obj2) => obj1.value >= obj2.value),
|
|
multiplyCurrencies: jest.fn((a, b) => `${a}x${b}`),
|
|
conversionGreaterThan: (obj1, obj2) => obj1.value > obj2.value,
|
|
conversionLessThan: (obj1, obj2) => obj1.value < obj2.value,
|
|
}));
|
|
|
|
jest.mock('../../helpers/utils/token-util', () => ({
|
|
calcTokenAmount: (a, d) => `calc:${a}${d}`,
|
|
}));
|
|
|
|
jest.mock('ethereumjs-abi', () => ({
|
|
rawEncode: jest.fn().mockReturnValue(16, 1100),
|
|
}));
|
|
|
|
describe('send utils', () => {
|
|
describe('calcGasTotal()', () => {
|
|
it('should call multiplyCurrencies with the correct params and return the multiplyCurrencies return', () => {
|
|
const result = calcGasTotal(12, 15);
|
|
expect(result).toStrictEqual('12x15');
|
|
expect(multiplyCurrencies).toHaveBeenCalledWith(12, 15, {
|
|
multiplicandBase: 16,
|
|
multiplierBase: 16,
|
|
toNumericBase: 'hex',
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('doesAmountErrorRequireUpdate()', () => {
|
|
const config = {
|
|
'should return true if balances are different': {
|
|
balance: 0,
|
|
prevBalance: 1,
|
|
expectedResult: true,
|
|
},
|
|
'should return true if gasTotals are different': {
|
|
gasTotal: 0,
|
|
prevGasTotal: 1,
|
|
expectedResult: true,
|
|
},
|
|
'should return true if token balances are different': {
|
|
tokenBalance: 0,
|
|
prevTokenBalance: 1,
|
|
sendToken: { address: '0x0' },
|
|
expectedResult: true,
|
|
},
|
|
'should return false if they are all the same': {
|
|
balance: 1,
|
|
prevBalance: 1,
|
|
gasTotal: 1,
|
|
prevGasTotal: 1,
|
|
tokenBalance: 1,
|
|
prevTokenBalance: 1,
|
|
sendToken: { address: '0x0' },
|
|
expectedResult: false,
|
|
},
|
|
};
|
|
Object.entries(config).forEach(([description, obj]) => {
|
|
it(`${description}`, () => {
|
|
expect(doesAmountErrorRequireUpdate(obj)).toStrictEqual(
|
|
obj.expectedResult,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('generateTokenTransferData()', () => {
|
|
it('should return undefined if not passed a send token', () => {
|
|
expect(
|
|
generateTokenTransferData({
|
|
toAddress: 'mockAddress',
|
|
amount: '0xa',
|
|
sendToken: undefined,
|
|
}),
|
|
).toBeUndefined();
|
|
});
|
|
|
|
it('should call abi.rawEncode with the correct params', () => {
|
|
generateTokenTransferData({
|
|
toAddress: 'mockAddress',
|
|
amount: 'ab',
|
|
sendToken: { address: '0x0' },
|
|
});
|
|
expect(rawEncode.mock.calls[0].toString()).toStrictEqual(
|
|
[
|
|
['address', 'uint256'],
|
|
['mockAddress', '0xab'],
|
|
].toString(),
|
|
);
|
|
});
|
|
|
|
it('should return encoded token transfer data', () => {
|
|
expect(
|
|
generateTokenTransferData({
|
|
toAddress: 'mockAddress',
|
|
amount: '0xa',
|
|
sendToken: { address: '0x0' },
|
|
}),
|
|
).toStrictEqual('0xa9059cbb');
|
|
});
|
|
});
|
|
|
|
describe('getAmountErrorObject()', () => {
|
|
const config = {
|
|
'should return insufficientFunds error if isBalanceSufficient returns false': {
|
|
amount: 15,
|
|
balance: 1,
|
|
conversionRate: 3,
|
|
gasTotal: 17,
|
|
primaryCurrency: 'ABC',
|
|
expectedResult: { amount: INSUFFICIENT_FUNDS_ERROR },
|
|
},
|
|
'should not return insufficientFunds error if sendToken is truthy': {
|
|
amount: '0x0',
|
|
balance: 1,
|
|
conversionRate: 3,
|
|
gasTotal: 17,
|
|
primaryCurrency: 'ABC',
|
|
sendToken: { address: '0x0', symbol: 'DEF', decimals: 0 },
|
|
decimals: 0,
|
|
tokenBalance: 'sometokenbalance',
|
|
expectedResult: { amount: null },
|
|
},
|
|
'should return insufficientTokens error if token is selected and isTokenBalanceSufficient returns false': {
|
|
amount: '0x10',
|
|
balance: 100,
|
|
conversionRate: 3,
|
|
decimals: 10,
|
|
gasTotal: 17,
|
|
primaryCurrency: 'ABC',
|
|
sendToken: { address: '0x0' },
|
|
tokenBalance: 123,
|
|
expectedResult: { amount: INSUFFICIENT_TOKENS_ERROR },
|
|
},
|
|
};
|
|
Object.entries(config).forEach(([description, obj]) => {
|
|
it(`${description}`, () => {
|
|
expect(getAmountErrorObject(obj)).toStrictEqual(obj.expectedResult);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('getGasFeeErrorObject()', () => {
|
|
const config = {
|
|
'should return insufficientFunds error if isBalanceSufficient returns false': {
|
|
balance: 16,
|
|
conversionRate: 3,
|
|
gasTotal: 17,
|
|
primaryCurrency: 'ABC',
|
|
expectedResult: { gasFee: INSUFFICIENT_FUNDS_ERROR },
|
|
},
|
|
'should return null error if isBalanceSufficient returns true': {
|
|
balance: 16,
|
|
conversionRate: 3,
|
|
gasTotal: 15,
|
|
primaryCurrency: 'ABC',
|
|
expectedResult: { gasFee: null },
|
|
},
|
|
};
|
|
Object.entries(config).forEach(([description, obj]) => {
|
|
it(`${description}`, () => {
|
|
expect(getGasFeeErrorObject(obj)).toStrictEqual(obj.expectedResult);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('calcTokenBalance()', () => {
|
|
it('should return the calculated token balance', () => {
|
|
expect(
|
|
calcTokenBalance({
|
|
sendToken: {
|
|
address: '0x0',
|
|
decimals: 11,
|
|
},
|
|
usersToken: {
|
|
balance: 20,
|
|
},
|
|
}),
|
|
).toStrictEqual('calc:2011');
|
|
});
|
|
});
|
|
|
|
describe('isBalanceSufficient()', () => {
|
|
it('should correctly call addCurrencies and return the result of calling conversionGTE', () => {
|
|
const result = isBalanceSufficient({
|
|
amount: 15,
|
|
balance: 100,
|
|
conversionRate: 3,
|
|
gasTotal: 17,
|
|
primaryCurrency: 'ABC',
|
|
});
|
|
expect(addCurrencies).toHaveBeenCalledWith(15, 17, {
|
|
aBase: 16,
|
|
bBase: 16,
|
|
toNumericBase: 'hex',
|
|
});
|
|
expect(conversionGTE).toHaveBeenCalledWith(
|
|
{
|
|
value: 100,
|
|
fromNumericBase: 'hex',
|
|
fromCurrency: 'ABC',
|
|
conversionRate: 3,
|
|
},
|
|
{
|
|
value: 32,
|
|
fromNumericBase: 'hex',
|
|
conversionRate: 3,
|
|
fromCurrency: 'ABC',
|
|
},
|
|
);
|
|
|
|
expect(result).toStrictEqual(true);
|
|
});
|
|
});
|
|
|
|
describe('isTokenBalanceSufficient()', () => {
|
|
it('should correctly call conversionUtil and return the result of calling conversionGTE', () => {
|
|
const result = isTokenBalanceSufficient({
|
|
amount: '0x10',
|
|
tokenBalance: 123,
|
|
decimals: 10,
|
|
});
|
|
|
|
expect(conversionUtil).toHaveBeenCalledWith('0x10', {
|
|
fromNumericBase: 'hex',
|
|
});
|
|
|
|
expect(conversionGTE).toHaveBeenCalledWith(
|
|
{
|
|
value: 123,
|
|
fromNumericBase: 'hex',
|
|
},
|
|
{
|
|
value: 'calc:1610',
|
|
},
|
|
);
|
|
|
|
expect(result).toStrictEqual(false);
|
|
});
|
|
});
|
|
|
|
describe('estimateGasForSend', () => {
|
|
const baseMockParams = {
|
|
blockGasLimit: '0x64',
|
|
selectedAddress: 'mockAddress',
|
|
to: '0xisContract',
|
|
estimateGasMethod: sinon.stub().callsFake(({ to }) => {
|
|
if (typeof to === 'string' && to.match(/willFailBecauseOf:/u)) {
|
|
throw new Error(to.match(/:(.+)$/u)[1]);
|
|
}
|
|
return '0xabc16';
|
|
}),
|
|
};
|
|
const baseexpectedCall = {
|
|
from: 'mockAddress',
|
|
gas: '0x64x0.95',
|
|
to: '0xisContract',
|
|
value: '0xff',
|
|
};
|
|
|
|
beforeEach(() => {
|
|
global.eth = {
|
|
getCode: sinon
|
|
.stub()
|
|
.callsFake((address) =>
|
|
Promise.resolve(address.match(/isContract/u) ? 'not-0x' : '0x'),
|
|
),
|
|
};
|
|
});
|
|
|
|
afterEach(() => {
|
|
baseMockParams.estimateGasMethod.resetHistory();
|
|
global.eth.getCode.resetHistory();
|
|
});
|
|
|
|
it('should call ethQuery.estimateGasForSend with the expected params', async () => {
|
|
const result = await estimateGasForSend(baseMockParams);
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(1);
|
|
expect(baseMockParams.estimateGasMethod.getCall(0).args[0]).toStrictEqual(
|
|
{
|
|
gasPrice: undefined,
|
|
value: undefined,
|
|
...baseexpectedCall,
|
|
},
|
|
);
|
|
expect(result).toStrictEqual('0xabc16');
|
|
});
|
|
|
|
it('should call ethQuery.estimateGasForSend with the expected params when initialGasLimitHex is lower than the upperGasLimit', async () => {
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
blockGasLimit: '0xbcd',
|
|
});
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(1);
|
|
expect(baseMockParams.estimateGasMethod.getCall(0).args[0]).toStrictEqual(
|
|
{
|
|
gasPrice: undefined,
|
|
value: undefined,
|
|
...baseexpectedCall,
|
|
gas: '0xbcdx0.95',
|
|
},
|
|
);
|
|
expect(result).toStrictEqual('0xabc16x1.5');
|
|
});
|
|
|
|
it('should call ethQuery.estimateGasForSend with a value of 0x0 and the expected data and to if passed a sendToken', async () => {
|
|
const result = await estimateGasForSend({
|
|
data: 'mockData',
|
|
sendToken: { address: 'mockAddress' },
|
|
...baseMockParams,
|
|
});
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(1);
|
|
expect(baseMockParams.estimateGasMethod.getCall(0).args[0]).toStrictEqual(
|
|
{
|
|
...baseexpectedCall,
|
|
gasPrice: undefined,
|
|
value: '0x0',
|
|
data: '0xa9059cbb',
|
|
to: 'mockAddress',
|
|
},
|
|
);
|
|
expect(result).toStrictEqual('0xabc16');
|
|
});
|
|
|
|
it('should call ethQuery.estimateGasForSend without a recipient if the recipient is empty and data passed', async () => {
|
|
const data = 'mockData';
|
|
const to = '';
|
|
const result = await estimateGasForSend({ ...baseMockParams, data, to });
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(1);
|
|
expect(baseMockParams.estimateGasMethod.getCall(0).args[0]).toStrictEqual(
|
|
{
|
|
gasPrice: undefined,
|
|
value: '0xff',
|
|
data,
|
|
from: baseexpectedCall.from,
|
|
gas: baseexpectedCall.gas,
|
|
},
|
|
);
|
|
expect(result).toStrictEqual('0xabc16');
|
|
});
|
|
|
|
it(`should return ${GAS_LIMITS.SIMPLE} if ethQuery.getCode does not return '0x'`, async () => {
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(0);
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
to: '0x123',
|
|
});
|
|
expect(result).toStrictEqual(GAS_LIMITS.SIMPLE);
|
|
});
|
|
|
|
it(`should return ${GAS_LIMITS.SIMPLE} if not passed a sendToken or truthy to address`, async () => {
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(0);
|
|
const result = await estimateGasForSend({ ...baseMockParams, to: null });
|
|
expect(result).toStrictEqual(GAS_LIMITS.SIMPLE);
|
|
});
|
|
|
|
it(`should not return ${GAS_LIMITS.SIMPLE} if passed a sendToken`, async () => {
|
|
expect(baseMockParams.estimateGasMethod.callCount).toStrictEqual(0);
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
to: '0x123',
|
|
sendToken: { address: '0x0' },
|
|
});
|
|
expect(result).not.toStrictEqual(GAS_LIMITS.SIMPLE);
|
|
});
|
|
|
|
it(`should return ${GAS_LIMITS.BASE_TOKEN_ESTIMATE} if passed a sendToken but no to address`, async () => {
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
to: null,
|
|
sendToken: { address: '0x0' },
|
|
});
|
|
expect(result).toStrictEqual(GAS_LIMITS.BASE_TOKEN_ESTIMATE);
|
|
});
|
|
|
|
it(`should return the adjusted blockGasLimit if it fails with a 'Transaction execution error.'`, async () => {
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
to: 'isContract willFailBecauseOf:Transaction execution error.',
|
|
});
|
|
expect(result).toStrictEqual('0x64x0.95');
|
|
});
|
|
|
|
it(`should return the adjusted blockGasLimit if it fails with a 'gas required exceeds allowance or always failing transaction.'`, async () => {
|
|
const result = await estimateGasForSend({
|
|
...baseMockParams,
|
|
to:
|
|
'isContract willFailBecauseOf:gas required exceeds allowance or always failing transaction.',
|
|
});
|
|
expect(result).toStrictEqual('0x64x0.95');
|
|
});
|
|
|
|
it(`should reject other errors`, async () => {
|
|
await expect(
|
|
estimateGasForSend({
|
|
...baseMockParams,
|
|
to: 'isContract willFailBecauseOf:some other error',
|
|
}),
|
|
).rejects.toThrow('some other error');
|
|
});
|
|
});
|
|
|
|
describe('getToAddressForGasUpdate()', () => {
|
|
it('should return empty string if all params are undefined or null', () => {
|
|
expect(getToAddressForGasUpdate(undefined, null)).toStrictEqual('');
|
|
});
|
|
|
|
it('should return the first string that is not defined or null in lower case', () => {
|
|
expect(getToAddressForGasUpdate('A', null)).toStrictEqual('a');
|
|
expect(getToAddressForGasUpdate(undefined, 'B')).toStrictEqual('b');
|
|
});
|
|
});
|
|
|
|
describe('removeLeadingZeroes()', () => {
|
|
it('should remove leading zeroes from int when user types', () => {
|
|
expect(removeLeadingZeroes('0')).toStrictEqual('0');
|
|
expect(removeLeadingZeroes('1')).toStrictEqual('1');
|
|
expect(removeLeadingZeroes('00')).toStrictEqual('0');
|
|
expect(removeLeadingZeroes('01')).toStrictEqual('1');
|
|
});
|
|
|
|
it('should remove leading zeroes from int when user copy/paste', () => {
|
|
expect(removeLeadingZeroes('001')).toStrictEqual('1');
|
|
});
|
|
|
|
it('should remove leading zeroes from float when user types', () => {
|
|
expect(removeLeadingZeroes('0.')).toStrictEqual('0.');
|
|
expect(removeLeadingZeroes('0.0')).toStrictEqual('0.0');
|
|
expect(removeLeadingZeroes('0.00')).toStrictEqual('0.00');
|
|
expect(removeLeadingZeroes('0.001')).toStrictEqual('0.001');
|
|
expect(removeLeadingZeroes('0.10')).toStrictEqual('0.10');
|
|
});
|
|
|
|
it('should remove leading zeroes from float when user copy/paste', () => {
|
|
expect(removeLeadingZeroes('00.1')).toStrictEqual('0.1');
|
|
});
|
|
});
|
|
});
|