1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts
Mark Stacey cb503d9403
Refactor assignment of "Background" metrics category (#9168)
The "Background" metrics category was being set in the
`backgroundMetaMetricsEvent` function. This function might not
necessarily include any event at all though, so setting it here seemed
inappropriate. It would also crash if `eventData.eventOpts` was not
set, which is not great since that property is optional.

The background category is now set in the `sendBackgroundMetaMetrics`
function in `metamask-controller`. This method is used solely for event
data, so it would make sense for this category to be always set.

There is no functional difference, since `backgroundMetaMetricsEvent`
is called solely by `sendBackgroundMetaMetrics`.
2020-08-10 12:38:56 -03:00
..
account-import-strategies Clean up "JSON File" import strategy test output (#7855) 2020-01-17 19:59:47 -03:30
controllers Add web3 usage metrics, prepare for web3 removal (#9144) 2020-08-07 12:28:23 -07:00
lib Refactor assignment of "Background" metrics category (#9168) 2020-08-10 12:38:56 -03:00
migrations Enable guard-for-in rule (#9000) 2020-07-21 18:40:45 -02:30
platforms Fix callback-return issues (#8996) 2020-07-17 20:19:52 -02:30
background.js Use eslint@6.8.0 (#8978) 2020-07-14 12:50:41 -02:30
chromereload.js Fix console.error references 2016-08-29 17:32:39 -07:00
contentscript.js Use eslint@6.8.0 (#8978) 2020-07-14 12:50:41 -02:30
first-time-state.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
inpage.js Add web3 usage metrics, prepare for web3 removal (#9144) 2020-08-07 12:28:23 -07:00
metamask-controller.js Refactor assignment of "Background" metrics category (#9168) 2020-08-10 12:38:56 -03:00
phishing-detect.js blacklist -> blocklist; whitelist -> safelist 2020-06-08 17:49:36 -07:00
ui.js Restore state snapshot for Sentry errors (#9028) 2020-07-17 12:09:38 -03:00