mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-23 10:30:04 +01:00
c7233e2cc7
* Fixed Vivek's bug Fixes #5850 What was happening: It seems that his MetaMask had crashed while some new transactions had been loading defaults. He probably had a network connectivity issue to Infura (which we are working with Infura to address). As a result of this network cutout, his three unapproved transactions were not marked failed, and were not marked as `loadingDefaults = false`, as their gas prices had not yet been estimated. Normally this behavior is supposed to clean itself up when the transaction controller starts up, via the `TransactionController._onBootCleanUp()` function, but in this case, during unlock, that function was unable to do its job because when it requested the transaction list, the current network was in the `loading` state, making it proceed as if there were no pending transactions. To fix this, I am doing two things: - Setting transactions to loadingDefaults = false in more catch blocks. - Calling `onBootCleanUp()` when the network store's status changes, so that it will re-trigger when loading completes. * Fixed reference * Fixed infinite loop bug Was refreshing the tx list on every tx state change instead of just network changes, creating an infinite loop. * Add notes to tx updates to clarify logs |
||
|---|---|---|
| .. | ||
| network | ||
| transactions | ||
| address-book.js | ||
| balance.js | ||
| blacklist.js | ||
| computed-balances.js | ||
| currency.js | ||
| detect-tokens.js | ||
| infura.js | ||
| preferences.js | ||
| provider-approval.js | ||
| README.md | ||
| recent-blocks.js | ||
| shapeshift.js | ||
| token-rates.js | ||
| user-actions.js | ||
Controllers
Different controllers (in the sense of *VC *View-Controller).