mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
1419c14fb6
The `currentPath` parameter passed to our metrics utility had been passed the full URL rather than just the path, contrary to what the name would imply. We only used the path portion, so passing the full URL did lead to complications. Now just the `pathname` is passed in, rather than the full URL. This simplifies the metrics logic, and it incidentally fixes two bugs. The main bug fixed is regarding Firefox metrics. Previously we had assumed the `currentPath` would start with `chrome-extension://`, which of course was not true on Firefox. This lead to us incorrectly parsing the `currentPath`, so path tracking was broken for Firefox events. This broken parsing is now bypassed entirely, so metrics should now work the same on Firefox as on Chrome. The second bug was that we were incorrectly setting the tracking URL for background events during tests. As a result, we were incorrectly detecting ourselves as an internal site that had referred the user to us. But this was not of major concern, since it only affected test metrics (which get sent to the development Matomo project). Lastly, this change let us discard the `pathname` parameter used in the `overrides` parameter of the `metricsEvent` function. Now that `currentPath` is equivalent to `pathname`, the `pathname` parameter is redundant. |
||
|---|---|---|
| .. | ||
| add-token | ||
| asset | ||
| confirm-add-suggested-token | ||
| confirm-add-token | ||
| confirm-approve | ||
| confirm-decrypt-message | ||
| confirm-deploy-contract | ||
| confirm-encryption-public-key | ||
| confirm-send-ether | ||
| confirm-send-token | ||
| confirm-token-transaction-base | ||
| confirm-transaction | ||
| confirm-transaction-base | ||
| confirm-transaction-switch | ||
| connected-accounts | ||
| connected-sites | ||
| create-account | ||
| error | ||
| first-time-flow | ||
| home | ||
| keychains | ||
| lock | ||
| mobile-sync | ||
| permissions-connect | ||
| routes | ||
| send | ||
| settings | ||
| unlock-page | ||
| index.js | ||
| index.scss | ||