1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00
metamask-extension/test
Mark Stacey bd23a49013
Revert "Moved subscribe and filter into network controller (#16693)" (#18129)
* Revert "Moved subscribe and filter into network controller (#16693)"

This reverts commit 6f6984fa58. That
commit was an RPC middleware refactor intended to move the subscribe
and filter middleware into the network controller, to simplify the
process of sharing this middleware between clients.

This refactor resulted in `eth_subscribe` notifications being sent on
the wrong connections, causing the UI to break in some cases (the UI
`provider` connection does not support notifications). This happened
because the `setupProviderEngine` function runs per-connection,
whereas the engine setup inside the network controller is global. The
global network client cannot support notifications because it has no
way to route them; they'll need to stay in the per-connection provider
engine.

Closes #17467

* Add e2e test

An e2e test has been added that confirms subscriptions are only
broadcast to the site that registered them. This test fails on
`develop`.
2023-03-15 12:16:31 -02:30
..
data Migrate network configurations (previously frequentRpcListDetail) from PreferencesController to NetworkController (#17421) 2023-03-09 15:00:28 -06:00
e2e Revert "Moved subscribe and filter into network controller (#16693)" (#18129) 2023-03-15 12:16:31 -02:30
helpers Removal of enzyme pkge dep (#17261) 2023-02-14 12:14:00 -06:00
jest Migrate network configurations (previously frequentRpcListDetail) from PreferencesController to NetworkController (#17421) 2023-03-09 15:00:28 -06:00
lib Extract out confirm-data and confirm-hex-data components from confirm-transaction-base.component.js (#17822) 2023-03-09 10:38:37 +05:30
mocks remove exclusions for mismatched object jsdoc type casing (#15351) 2022-07-27 08:28:05 -05:00
stub Update eth-json-rpc-middleware from v9 to v10 (#17591) 2023-02-27 13:19:08 -03:30
unit-global Add lockdown e2e test (#12562) 2021-11-02 17:01:01 -07:00
env.js Adding static icon names to test env file (#16078) 2022-11-18 22:28:38 +05:30
merge-coverage.js decrease coverage threshold that requires bump (#17544) 2023-02-02 16:43:55 -06:00
run-unit-tests.js split unit tests (#16455) 2023-01-11 12:23:38 -06:00
setup.js Disable typechecking while running Mocha tests (#17701) 2023-02-12 14:34:35 -07:00