mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-29 23:58:06 +01:00
5ee1291662
Previously all browser globals were allowed to be used anywhere by ESLint because we had set the `env` property to `browser` in the ESLint config. This has made it easy to accidentally use browser globals (e.g. #8338), so it has been removed. Instead we now have a short list of allowed globals. All browser globals are now accessed as properties on `window`. Unfortunately this change resulted in a few different confusing unit test errors, as some of our unit tests setup assumed that a particular global would be used via `window` or `global`. In particular, `window.fetch` didn't work correctly because it wasn't patched by the AbortController polyfill (only `global.fetch` was being patched). The `jsdom-global` package we were using complicated matters by setting all of the JSDOM `window` properties directly on `global`, overwriting the `AbortController` for example. The `helpers.js` test setup module has been simplified somewhat by removing `jsdom-global` and constructing the JSDOM instance manually. The JSDOM window is set on `window`, and a few properties are set on `global` as well as needed by various dependencies. `node-fetch` and the AbortController polyfill/patch now work as expected as well, though `fetch` is only available on `window` now.
78 lines
3.1 KiB
JavaScript
78 lines
3.1 KiB
JavaScript
const reactTriggerChange = require('react-trigger-change')
|
|
const {
|
|
timeout,
|
|
queryAsync,
|
|
} = require('../../lib/util')
|
|
const fetchMockResponses = require('../../data/fetch-mocks.json')
|
|
|
|
QUnit.module('confirm sig requests')
|
|
|
|
QUnit.test('successful confirmation of sig requests', (assert) => {
|
|
const done = assert.async()
|
|
runConfirmSigRequestsTest(assert).then(done).catch((err) => {
|
|
assert.notOk(err, `Error was thrown: ${err.stack}`)
|
|
done()
|
|
})
|
|
})
|
|
|
|
global.ethQuery = global.ethQuery || {}
|
|
|
|
async function runConfirmSigRequestsTest (assert) {
|
|
const selectState = await queryAsync($, 'select')
|
|
selectState.val('confirm sig requests')
|
|
reactTriggerChange(selectState[0])
|
|
|
|
const realFetch = window.fetch.bind(window)
|
|
window.fetch = (...args) => {
|
|
if (args[0] === 'https://ethgasstation.info/json/ethgasAPI.json') {
|
|
return Promise.resolve({ json: () => Promise.resolve(JSON.parse(fetchMockResponses.ethGasBasic)) })
|
|
} else if (args[0] === 'https://ethgasstation.info/json/predictTable.json') {
|
|
return Promise.resolve({ json: () => Promise.resolve(JSON.parse(fetchMockResponses.ethGasPredictTable)) })
|
|
} else if (args[0].match(/chromeextensionmm/)) {
|
|
return Promise.resolve({ json: () => Promise.resolve(JSON.parse(fetchMockResponses.metametrics)) })
|
|
}
|
|
return realFetch.fetch(...args)
|
|
}
|
|
|
|
const pendingRequestItem = $.find('.transaction-list-item .transaction-list-item__grid')
|
|
|
|
if (pendingRequestItem[0]) {
|
|
pendingRequestItem[0].click()
|
|
}
|
|
|
|
await timeout(1000)
|
|
|
|
let confirmSigHeadline = await queryAsync($, '.request-signature__headline')
|
|
assert.equal(confirmSigHeadline[0].textContent, 'Your signature is being requested')
|
|
|
|
let confirmSigRowValue = await queryAsync($, '.request-signature__row-value')
|
|
assert.equal(confirmSigRowValue[0].textContent, 'Hi, Alice!')
|
|
assert.equal(confirmSigRowValue[1].textContent, '1337')
|
|
|
|
let confirmSigSignButton = await queryAsync($, 'button.btn-secondary.btn--large')
|
|
confirmSigSignButton[0].click()
|
|
await timeout(1000)
|
|
confirmSigHeadline = await queryAsync($, '.request-signature__headline')
|
|
assert.equal(confirmSigHeadline[0].textContent, 'Your signature is being requested')
|
|
|
|
confirmSigRowValue = await queryAsync($, '.request-signature__row-value')
|
|
assert.ok(confirmSigRowValue[0].textContent.match(/^#\sTerms\sof\sUse/))
|
|
|
|
confirmSigSignButton = await queryAsync($, 'button.btn-secondary.btn--large')
|
|
confirmSigSignButton[0].click()
|
|
await timeout(1000)
|
|
confirmSigHeadline = await queryAsync($, '.request-signature__headline')
|
|
assert.equal(confirmSigHeadline[0].textContent, 'Your signature is being requested')
|
|
|
|
const confirmSigMessage = await queryAsync($, '.request-signature__notice')
|
|
assert.ok(confirmSigMessage[0].textContent.match(/^Signing\sthis\smessage/))
|
|
|
|
confirmSigRowValue = await queryAsync($, '.request-signature__row-value')
|
|
assert.equal(confirmSigRowValue[0].textContent, '0x879a053d4800c6354e76c7985a865d2922c82fb5b3f4577b2fe08b998954f2e0')
|
|
|
|
confirmSigSignButton = await queryAsync($, 'button.btn-secondary.btn--large')
|
|
confirmSigSignButton[0].click()
|
|
|
|
await timeout(2000)
|
|
}
|