mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-28 23:06:37 +01:00
ec7e7fdf6d
* Fix fallback gas estimation Our fallback gas estimation was failing due to a bug in the `@metamask/controller-utils` package. This was causing gas estimation to fail completely on certain networks (those not supported by our gas estimation APIs and non EIP-1559 compatibile), and it was causing the fallback gas estimation operation (in case our API was down) to fail across all networks. Fixes https://github.com/MetaMask/metamask-extension/issues/19735 * Add e2e tests E2E tests have been added to capture gas estimation. Cases are added for our API, for the fallback estimate, and for non-EIP-1559 estimates. As part of this work, the legacy gas API had to be disabled. This was being used in e2e tests but was dead code in production. It needed to be disabled to ensure the code under test was reachable. * Fix gas API referenced in e2e test * Update unit test snapshots
48 lines
1.5 KiB
JavaScript
48 lines
1.5 KiB
JavaScript
import React from 'react';
|
|
import PropTypes from 'prop-types';
|
|
import { useSelector } from 'react-redux';
|
|
|
|
import {
|
|
checkNetworkAndAccountSupports1559,
|
|
txDataSelector,
|
|
} from '../../../selectors';
|
|
import { isLegacyTransaction } from '../../../helpers/utils/transactions.util';
|
|
import GasDetailsItem from '../gas-details-item';
|
|
import { getCurrentDraftTransaction } from '../../../ducks/send';
|
|
import { TransactionEnvelopeType } from '../../../../shared/constants/transaction';
|
|
import { ConfirmLegacyGasDisplay } from './confirm-legacy-gas-display';
|
|
|
|
const ConfirmGasDisplay = ({ userAcknowledgedGasMissing = false }) => {
|
|
const { txParams } = useSelector((state) => txDataSelector(state));
|
|
|
|
const draftTransaction = useSelector(getCurrentDraftTransaction);
|
|
const transactionType = draftTransaction?.transactionType;
|
|
let isLegacyTxn;
|
|
if (transactionType) {
|
|
isLegacyTxn = transactionType === TransactionEnvelopeType.legacy;
|
|
} else {
|
|
isLegacyTxn = isLegacyTransaction(txParams);
|
|
}
|
|
|
|
const networkAndAccountSupports1559 = useSelector(
|
|
checkNetworkAndAccountSupports1559,
|
|
);
|
|
const supportsEIP1559 = networkAndAccountSupports1559 && !isLegacyTxn;
|
|
const dataTestId = 'confirm-gas-display';
|
|
|
|
return supportsEIP1559 ? (
|
|
<GasDetailsItem
|
|
data-testid={dataTestId}
|
|
userAcknowledgedGasMissing={userAcknowledgedGasMissing}
|
|
/>
|
|
) : (
|
|
<ConfirmLegacyGasDisplay data-testid={dataTestId} />
|
|
);
|
|
};
|
|
|
|
ConfirmGasDisplay.propTypes = {
|
|
userAcknowledgedGasMissing: PropTypes.bool,
|
|
};
|
|
|
|
export default ConfirmGasDisplay;
|