1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
metamask-extension/development
Mark Stacey b124ac29fc
Improve detection of task process exit (#10776)
Our build script waits for the `close` event to determine whether the
task has exited. The `exit` event is a better representation of this,
because if a stream is shared between multiple processes, the process
may exit without the `close` event being emitted.

We aren't sharing streams between processes, so this edge case doesn't
apply to us. This just seemed like a more suitable event to listen to,
since we care about the process exiting not the stream ending.

See this description of the `close` event from the Node.js
documentation [1]:

>The `'close'` event is emitted when the stdio streams of a child
>process have been closed. This is distinct from the `'exit'` event,
>since multiple processes might share the same stdio streams.

And see this description of the `exit` event:

>The `'exit'` event is emitted after the child process ends.

[1]: https://nodejs.org/docs/latest-v14.x/api/child_process.html#child_process_event_exit
2021-03-31 13:13:17 -02:30
..
build Improve detection of task process exit (#10776) 2021-03-31 13:13:17 -02:30
lib @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
announcer.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
auto-changelog.sh Add shellcheck lint (#7392) 2019-11-19 10:46:10 -05:00
chromereload.js Build - refactor background process to use html (#10769) 2021-03-31 11:12:28 +08:00
create-static-server.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
empty.js Build - refactor background process to use html (#10769) 2021-03-31 11:12:28 +08:00
generate-migration.sh Fixing migration script generation paths (#10664) 2021-03-17 12:21:46 +08:00
gource-viz.sh dev - move gource instructions from docs to development script 2019-09-10 22:05:16 +08:00
metamaskbot-build-announce.js Add Lavamoat to build system (#9939) 2021-02-22 22:43:29 +08:00
missing-locale-strings.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
mock-3box.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
mock-segment.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
README.md add READMEs to folders, re #3427 2018-03-14 15:33:22 +02:00
require-react-devtools.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
run-ganache.sh Use .sh file extension for all Bash scripts (#10499) 2021-02-23 12:56:41 -03:30
sentry-publish.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
sentry-upload-artifacts.sh Improve Sentry publish script (#7417) 2019-12-05 17:59:48 -04:00
shellcheck.sh Add lint:shellcheck:package (#7568) 2019-12-11 15:52:08 -05:00
show-deps-install-scripts.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
source-map-explorer.sh Excluding sourcemaps comment in production builds (#10695) 2021-03-22 19:41:23 -07:00
sourcemap-validator.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
static-server.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
verify-locale-strings.js Add Custom Network UI (#10310) 2021-02-22 10:20:42 -06:00

Development

Several files which are needed for developing on(!) MetaMask.

Usually each files contains information about its scope / usage.