1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts
Mark Stacey 99b8f2d544
Fix provider approval metadata ()
* Omit MetaMask `extensionId` from site metadata

The site metadata was updated in  to include the extension id of
the extension connecting to MetaMask. This was done to allow external
extensions to connect with MetaMask, so that we could show the id on
the provider approval screen.

Unbeknownst to me at the time, the extension id was being set for all
connections to MetaMask from dapps. The id was set to MetaMask's id,
because the connections are made through MetaMask's contentscript.

This has been updated to only set the id when accepting a connection
from a different extension.

* Fix `siteMetadata` property names

In  a few things were added to the site metadata, so the provider
approval controller was middleware was updated to accept the site
metadata as an object rather than accepting each property as a separate
parameter. Unfortunately we failed to notice that the site name and
icon were named differently in the site metadata than they were in the
provider approval controller, so the names of those properties were
unintentionally changed in the controller state.

The provider approval controller has been updated to restore the
original property names of `siteTitle` and `siteIcon`. An unused prop
that was added to the provider approval page in  has also been
removed.
2019-11-04 17:28:50 -04:00
..
account-import-strategies account-import-strategies - ensure privateKey is prefixed before converting to buffer 2018-06-13 21:06:33 -07:00
controllers Fix provider approval metadata () 2019-11-04 17:28:50 -04:00
lib Add web3 deprecation warning () 2019-10-31 21:56:02 -02:30
migrations Add a/b test for full screen transaction confirmations () 2019-09-24 17:08:38 -04:00
platforms Close window after opening fullscreen () 2019-08-08 11:50:32 -03:00
background.js Fix provider approval metadata () 2019-11-04 17:28:50 -04:00
chromereload.js Fix console.error references 2016-08-29 17:32:39 -07:00
contentscript.js Remove reload from Share Address button () 2019-08-09 15:00:59 -02:30
createStandardProvider.js Refactor ProviderApprovalController to use rpc and publicConfigStore () 2019-05-03 13:32:05 -04:00
edge-encryptor.js Enable indent linting via ESLint () 2019-07-31 10:17:11 -10:00
first-time-state.js controllers - network - move default config out of first-time-state 2018-05-02 18:03:59 -07:00
inpage.js Add web3 deprecation warning () 2019-10-31 21:56:02 -02:30
metamask-controller.js ENS Reverse Resolution support () 2019-11-01 15:24:00 -02:30
phishing-detect.js Rename accountManager usages () 2019-07-10 16:31:48 -02:30
README.md add READMEs to folders, re 2018-03-14 15:33:22 +02:00
ui.js Freeze Promise global on boot () 2019-10-24 06:54:32 -07:00

Main MetaMask Code

This folder contains the core-code.

Currently, it is organized mostly based on file category, like:

controllers, migrations, lib

Ongoing Task

Refactor code-structure, thus the subsystems are reflected on the filesystem.

Examples