1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/app/helpers/utils
bguiz 96929d99c0 fix: handle trailing / in block explorer URLs
What

- modify `ui/app/helpers/utils/transactions.util.js` and
  `ui/lib/account-link.js` to strip trailing slashes
  if they are present.
- added relevant tests not just for the new scenario,
  but also the general scenarios for these functions,
  as there previously was no test coverage for these
  two functions.

Why

- Current behaviour, when user enters a block explorer URL
  when configuring a custom RPC, and that block explorer URL
  contains a trailing `/`.
  - e.g. `https://block.explorer/`
  - this results in a double-slash (`//`) in the transaction
    and account URLs generated by MetaMask.
  - e.g. `https://block.explorer/tx/0xabcd...`,
    `https://block.explorer/account/0xabcd...`
  - This needs to be handled using a router redirect
    on the server of the block explorer,
    and this changes would avoid that requirement.
2020-05-14 17:15:17 +08:00
..
common.util.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
common.util.test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
confirm-tx.util.js Reorganize selectors directory (#8497) 2020-05-02 12:41:17 -07:00
confirm-tx.util.test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
conversion-util.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
conversion-util.test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
conversions.util.js Improved UX for sweeping accounts (#6488) 2019-05-20 14:08:08 -02:30
fetch-with-cache.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
fetch-with-cache.test.js Update fetchWithCacheTests to use assert.rejects (#8334) 2020-04-14 13:03:33 -02:30
formatters.js Folder restructure (#6304) 2019-03-21 20:33:30 -02:30
gas-time-estimates.util.js Add Estimated time to pending tx (#6924) 2019-10-31 23:21:28 -02:30
i18n-helper.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
i18n-helper.test.js Translation helper: substitute react components and component wrapping substrings (#8129) 2020-03-11 12:30:05 -02:30
metametrics.util.js Fix Matomo dimension IDs (#8579) 2020-05-13 10:12:07 -03:00
switch-direction.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
token-util.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
transactions.util.js fix: handle trailing / in block explorer URLs 2020-05-14 17:15:17 +08:00
transactions.util.test.js fix: handle trailing / in block explorer URLs 2020-05-14 17:15:17 +08:00
util.js Fix connected sites modal styling; add shortenUrl function (#8409) 2020-04-27 08:36:08 -07:00
util.test.js Remove unused sinon sandboxes (#8063) 2020-02-17 21:31:09 -04:00