1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/test
bguiz 96929d99c0 fix: handle trailing / in block explorer URLs
What

- modify `ui/app/helpers/utils/transactions.util.js` and
  `ui/lib/account-link.js` to strip trailing slashes
  if they are present.
- added relevant tests not just for the new scenario,
  but also the general scenarios for these functions,
  as there previously was no test coverage for these
  two functions.

Why

- Current behaviour, when user enters a block explorer URL
  when configuring a custom RPC, and that block explorer URL
  contains a trailing `/`.
  - e.g. `https://block.explorer/`
  - this results in a double-slash (`//`) in the transaction
    and account URLs generated by MetaMask.
  - e.g. `https://block.explorer/tx/0xabcd...`,
    `https://block.explorer/account/0xabcd...`
  - This needs to be handled using a router redirect
    on the server of the block explorer,
    and this changes would avoid that requirement.
2020-05-14 17:15:17 +08:00
..
data Consolidate selector tests (#8510) 2020-05-05 07:05:16 -07:00
e2e Refactor asset list items (#8586) 2020-05-13 17:41:15 -03:00
integration Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
lib Delete Balance controller and pending balances calculator (#8542) 2020-05-06 20:19:28 -03:00
stub Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
unit fix: handle trailing / in block explorer URLs 2020-05-14 17:15:17 +08:00
unit-global Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
web3 Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
base.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
env.js Remove cross-env (#7950) 2020-01-30 14:11:26 -03:30
flat.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
helper.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
setup.js Remove obs-store babel register handling (#8413) 2020-04-27 07:54:42 -07:00