1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/app/selectors
Mark Stacey 95a95ee4bc
Refactor transaction list token filtering (#8669)
The transaction list now filters by token in the `TransactionList`
component instead of in the transaction selector. This was done in
preparation for the asset page work.

Technically this approach is slightly less efficient than before, as
we're now filtering the transactions after they've been grouped
together rather than beforehand. The difference is minimal though, and
this method is more correct.

The old filtering was broken because it inappropriately filtered out
cancel transactions. Cancel transactions always have the `to` address
set to the same as the `from` address, and the token filter only
returned transactions where the `to` address was set to the token
address.

Now that we're only filtering by the `to` address of the initial
transaction, token transaction groups will be included in their
entirety, including any cancel transactions.
2020-05-28 00:11:15 -03:00
..
tests Refactor transaction list token filtering (#8669) 2020-05-28 00:11:15 -03:00
confirm-transaction.js Consolidate and dedupe send selectors (#8506) 2020-05-04 12:06:28 -07:00
custom-gas.js Rename preferencesSelector selector to getPreferences (#8647) 2020-05-26 03:41:58 -02:30
first-time-flow.js Consolidate send, onboarding selectors (#8501) 2020-05-04 08:22:34 -07:00
index.js Consolidate and dedupe send selectors (#8506) 2020-05-04 12:06:28 -07:00
permissions.js Localize permission descriptions (#8661) 2020-05-27 18:15:10 -02:30
selectors.js Localize permission descriptions (#8661) 2020-05-27 18:15:10 -02:30
send.js Delete recent blocks controller (#8575) 2020-05-12 12:40:33 -07:00
tokens.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
transactions.js Refactor transaction list token filtering (#8669) 2020-05-28 00:11:15 -03:00