mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-27 04:46:10 +01:00
5b5b67a985
A race condition exists where after adding an unapproved transaction, it could be mutated and then replaced when the default gas parameters are set. This happens because the transaction is added to state and broadcast before the default gas parameters are set, because calculating the default gas parameters to use takes some time. Once they've been calculated, the false assumption was made that the transaction hadn't changed. The method responsible for setting the default gas now retrieves an up-to-date copy of `txMeta`, and conditionally sets the defaults only if they haven't yet been set. This race condition was introduced in #2962, though that PR also added a loading screen that avoided this issue by preventing the user from interacting with the transaction until after the gas had been estimated. Unfortunately this loading screen was not carried forward to the new UI. |
||
|---|---|---|
| .. | ||
| network | ||
| permissions | ||
| transactions | ||
| balance-controller.spec.js | ||
| cached-balances-test.js | ||
| detect-tokens-test.js | ||
| ens-controller-test.js | ||
| incoming-transactions-test.js | ||
| infura-controller-test.js | ||
| metamask-controller-test.js | ||
| preferences-controller-test.js | ||
| token-rates-controller.js | ||